From: "plaisthos (Code Review)" Date: Tue, 31 Mar 2026 16:24:02 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <4a0dea37ab3f88ebad3177b20512b149f7f7986c-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="84ZSVoZU3bo="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: openvpn-devel --84ZSVoZU3bo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable plaisthos has uploaded a new patch set (#2). ( http://gerrit.openvpn.net/c/= openvpn/+/1587?usp=3Demail ) Change subject: Use ASN1_BIT_STRING_get_bit to check for netscape certifica= te usage ...................................................................... Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead of accessing the internal, we have to use a method now to check these attributes. The bit counting in ANS.1 and of this method is a bit strange and it will count bits from the left instead of the right, so the previous mask of 0x80 for clients is now 0 and 0x40 for server is now 1. Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2 Signed-off-by: Arne Schwabe --- M src/openvpn/ssl_verify_openssl.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1587/2 diff --git a/src/openvpn/ssl_verify_openssl.c b/src/openvpn/ssl_verify_open= ssl.c index 08946cd..7c0cbb3 100644 --- a/src/openvpn/ssl_verify_openssl.c +++ b/src/openvpn/ssl_verify_openssl.c @@ -624,7 +624,8 @@ { ASN1_BIT_STRING *ns; ns =3D X509_get_ext_d2i(peer_cert, NID_netscape_cert_type, NUL= L, NULL); - result =3D (ns && ASN1_STRING_length(ns) > 0 && (ASN1_STRING_g= et0_data(ns)[0] & NS_SSL_CLIENT)) ? SUCCESS : FAILURE; + // bit 0 is to check if certificate is the client certificate + result =3D ASN1_BIT_STRING_get_bit(ns, 0) ? SUCCESS : FAILURE; if (result =3D=3D SUCCESS) { msg(M_WARN, "X509: Certificate is a client certificate yet= it's purpose " @@ -650,9 +651,9 @@ */ if (result =3D=3D FAILURE) { - ASN1_BIT_STRING *ns; - ns =3D X509_get_ext_d2i(peer_cert, NID_netscape_cert_type, NUL= L, NULL); - result =3D (ns && ASN1_STRING_length(ns) > 0 && (ASN1_STRING_g= et0_data(ns)[0] & NS_SSL_SERVER)) ? SUCCESS : FAILURE; + ASN1_BIT_STRING *ns =3D X509_get_ext_d2i(peer_cert, NID_netsca= pe_cert_type, NULL, NULL); + // Server bit is 1 for ASN1_BIT_STRING_get_bit + result =3D ASN1_BIT_STRING_get_bit(ns, 1) ? SUCCESS : FAILURE; if (result =3D=3D SUCCESS) { msg(M_WARN, "X509: Certificate is a server certificate yet= it's purpose " -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1587?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2 Gerrit-Change-Number: 1587 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-CC: openvpn-devel --84ZSVoZU3bo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

plaisthos uploaded patch set #2 to this change.

View Change

Use ASN1_BIT_STRING_get_bit to check for netscape certificate usage
=
The ASN_BIT_STRING object has become opaque in OpenSSL 4.0. So instead<= br>of accessing the internal, we have to use a method now to check theseattributes.

The bit counting in ANS.1 and of this method is a bit s= trange and
it will count bits from the left instead of the right, so the= previous
mask of 0x80 for clients is now 0 and 0x40 for server is now 1= .

Change-Id: I77500d435f212a4bf42ee8cfca07d0285fe694f2
Signed-off= -by: Arne Schwabe <arne@...1227...>
---
M src/openvpn/ssl_verif= y_openssl.c
1 file changed, 5 insertions(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes=
/87/1587/2
diff --git a/src/openvpn/ssl_verify_openssl.c b/src/open=
vpn/ssl_verify_openssl.c
index 08946cd..7c0cbb3 100644
--- a/src/openvpn/ssl_verify_openssl.c
+++ b/sr= c/openvpn/ssl_verify_openssl.c
@@ -624,7 +624,8 @@ {
ASN1_BIT_STRING *ns;=
ns =3D X509_get_ext_d2i(peer_cert, NID_netscape_cert= _type, NULL, NULL);
- = result =3D (ns && ASN1_STRING_length(ns) > 0 &&= ; (ASN1_STRING_get0_data(ns)[0] & NS_SSL_CLIENT)) ? SUCCESS : FAILURE;<= /span>
+ // bit 0= is to check if certificate is the client certificate
+ result =3D ASN1_BIT_STRING_ge= t_bit(ns, 0) ? SUCCESS : FAILURE;
if (result = =3D=3D SUCCESS)
{
= msg(M_WARN, "X509: Certificate is a client certificate yet it'= ;s purpose "
@@ -650,9 +651,9 @@
= */
if (result =3D=3D FAILURE)
{

- = ASN1_BIT_STRING *ns;
= - ns =3D X509_get_ext_d2i(peer_cert, NID_netscape_cert_type, NUL= L, NULL);
- = result =3D (ns && ASN1_STRING_length(ns) > 0 && (ASN1_ST= RING_get0_data(ns)[0] & NS_SSL_SERVER)) ? SUCCESS : FAILURE;
= + ASN1_BIT_STRING *n= s =3D X509_get_ext_d2i(peer_cert, NID_netscape_cert_type, NULL, NULL);
+ // Server bi= t is 1 for ASN1_BIT_STRING_get_bit
+ result =3D ASN1_BIT_STRING_get_bit(ns, 1) ? SUCC= ESS : FAILURE;
if (result =3D=3D SUCCESS)
{
msg(M_WARN, &qu= ot;X509: Certificate is a server certificate yet it's purpose "

To view, visit change 1587. To unsubscribe, o= r for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I77500d435f212a4bf42ee8cfca0= 7d0285fe694f2
Gerrit-Change-Number: 1587
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --84ZSVoZU3bo=--