From: Vasily Averin Subject: Re: [PATCH memcg 0/1] false global OOM triggered by memcg-limited task Date: Mon, 18 Oct 2021 22:18:53 +0300 Message-ID: <4a30aa18-e2a2-693c-8237-b75fffac9838@virtuozzo.com> References: <9d10df01-0127-fb40-81c3-cc53c9733c3e@virtuozzo.com> <6b751abe-aa52-d1d8-2631-ec471975cc3a@virtuozzo.com> <27dc0c49-a0d6-875b-49c6-0ef5c0cc3ac8@virtuozzo.com> <153f7aa6-39ef-f064-8745-a9489e088239@virtuozzo.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Date:Message-ID:From: Subject; bh=4jQhvYjT9e4GBOeEOpVGTS9SaUVXdZehoAqLumPkuB4=; b=BJk6ixEhC6GggosfS drD0XYECS0NtOWJdkYysnHFAK3NUBY+8RheLTcA44GdguZbNpj3BRm189Gyzn1Px/cF3Y/O/nx2El BkFfXhQpsHXlqPQeOunogHD6a/FRsulQdWnndAg0XUNt5LOBKuKiAefJ3xBLBOy6yqbngYxkO41TM =; In-Reply-To: <153f7aa6-39ef-f064-8745-a9489e088239-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org> Content-Language: en-US List-ID: Content-Type: text/plain; charset="us-ascii" To: Shakeel Butt , Michal Hocko Cc: Johannes Weiner , Vladimir Davydov , Andrew Morton , Roman Gushchin , Uladzislau Rezki , Vlastimil Babka , Mel Gorman , Cgroups , Linux MM , LKML , kernel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org On 18.10.2021 21:52, Vasily Averin wrote: > On 18.10.2021 18:07, Shakeel Butt wrote: >> On Mon, Oct 18, 2021 at 5:27 AM Michal Hocko wrote: >>> >>> [restore the cc list] >>> >>> On Mon 18-10-21 15:14:26, Vasily Averin wrote: >>>> On 18.10.2021 14:53, Michal Hocko wrote: >>>>> On Mon 18-10-21 13:05:35, Vasily Averin wrote: >>>>>> On 18.10.2021 12:04, Michal Hocko wrote: >>>>>> Here we call try_charge_memcg() that return success and approve the allocation, >>>>>> however then we hit into kmem limit and fail the allocation. >>>>> >>>>> Just to make sure I understand this would be for the v1 kmem explicit >>>>> limit, correct? >>>> >>>> yes, I mean this limit. >>> >>> OK, thanks for the clarification. This is a known problem. Have a look >>> at I think we consider that one to 0158115f702b ("memcg, kmem: deprecate >>> kmem.limit_in_bytes"). We are reporting the deprecated and to-be removed >>> status since 2019 without any actual report sugested by the kernel >>> message. Maybe we should try and remove it and see whether that prompts >>> some pushback. >>> >> >> Yes, I think now should be the right time to take the next step for >> deprecation of kmem limits: >> https://lore.kernel.org/all/20201118175726.2453120-1-shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org/ > > Are you going to push it to stable kernels too? Btw CONFIG_MEMCG_KMEM=y is set both in RHEL8 kernels and in ubuntu 20.04 LTS kernel 5.11.0-37.