From: Shirish Pargaonkar Subject: Re: [linux-cifs-client] [CIFS] [PATCH] warn on EINVAL error on posix open, and turn off posix open if server broken for this call Date: Wed, 4 Mar 2009 13:29:38 -0600 Message-ID: <4a4634330903041129w2c65011fvb048c45cf94fa896@mail.gmail.com> References: <524f69650903041102v415a807m8a93f0462458a51@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jeremy Allison , Jeff Layton , linux-fsdevel , "linux-cifs-client@lists.samba.org" , samba-technical To: Steve French Return-path: Received: from yw-out-2324.google.com ([74.125.46.28]:8376 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754632AbZCDT3k (ORCPT ); Wed, 4 Mar 2009 14:29:40 -0500 Received: by yw-out-2324.google.com with SMTP id 5so2268720ywh.1 for ; Wed, 04 Mar 2009 11:29:38 -0800 (PST) In-Reply-To: <524f69650903041102v415a807m8a93f0462458a51@mail.gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Mar 4, 2009 at 1:02 PM, Steve French wrote: > Attached is patch to workaround the problem found in posix open to > Samba versions 3.3.1 and earlier > (create works, but open would fail with invalid parameter) - it > disables requests to try posix open after > a first failure. > > > > -- > Thanks, > > Steve > > _______________________________________________ > linux-cifs-client mailing list > linux-cifs-client@lists.samba.org > https://lists.samba.org/mailman/listinfo/linux-cifs-client > > Steve, I think I will have to apply similar logic in cifs_lookup for lookup intents i.e. when cifs_posix_open fails with the same return code, follow the usual lookup path, I do not have to disable posix opens though as Simo said. Would be wasting a transaction in the process though in case of samba servers that have this problem. Regards, Shirish