From: "flichtenheld (Code Review)" Date: Wed, 13 Dec 2023 10:49:18 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <4a9873105cbd02457fc0b4684df2face7a66e139-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="sEDNxrUcScg="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: forked-test-driver: Show test output always List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --sEDNxrUcScg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/479?usp=3Demail ) Change subject: forked-test-driver: Show test output always ...................................................................... Patch Set 3: (1 comment) This change is ready for review. File forked-test-driver: http://gerrit.openvpn.net/c/openvpn/+/479/comment/bf08f7d3_1455cd09 : PS1, Line 112: "$@" 2>&1 | tee -a "$log_file" > breaks exit status without set -o pipefail. Which is probably not portabl= e... [=E2=80=A6] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/479?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I11e0091482d9acee89ca018374cb8d96d22f8514 Gerrit-Change-Number: 479 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Wed, 13 Dec 2023 10:49:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --sEDNxrUcScg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File forked-test-driver:

    • Patch Set #1, Line 112: "$@" 2>&1 | = tee -a "$log_file"

      breaks exit status witho= ut set -o pipefail. Which is probably not portable... [=E2=80=A6]

      Done

      <= /li>

To view, visit change 479. To unsubscribe, or for help wri= ting mail filters, visit set= tings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I11e0091482d9acee89ca018374c= b8d96d22f8514
Gerrit-Change-Number: 479
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Wed, 13 Dec 2023 10:49:18= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--sEDNxrUcScg=--