Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EC48C4332F for ; Thu, 13 Oct 2022 07:29:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D85418455E; Thu, 13 Oct 2022 09:29:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="abVQGkQo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8530D84607; Thu, 13 Oct 2022 09:29:29 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2115.outbound.protection.outlook.com [40.107.20.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DABB58454A for ; Thu, 13 Oct 2022 09:29:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Us8eQSjRv6yIT5IWajND6BzXIKP3tyaYzYMGq7Hi2UCFWBrUFWgXuysEb/MSvmBMmQqI54EqXaRfbTe4gD9o+zLobyunwRmUFvtVPVSvQWo0IPeNnM92Xhrx7piBD6XBVKXZ/EKBT1VttVmm3/gJnBCW6ArxmSlHCImarE1WTqRcJUPwbMdaCpyWDKqtUQEvsHeAYXbjJgSXvc/PoiqSYxzsUgL6LYidLhWf5QFzg4KqFh3++VzQyX1uYbNQUVxu7zTBrEb7o7Rk9NYe9jw5xy0jLVYgproL3ekQphVCazEWVwL2ZUPIpyCI3ezeY55boLUpNJUzg/2CeUiYZvis9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ua7yM+VVfpp8EgOO1SaS2l9ipP4P8imyENUB8WILPDs=; b=GWVSxXXAGeGPtjH/CIfE8RvifXNB1MeMN8EmdJSTgIEqbgQzt4APqGzfaCbuS7sZ1r8+iw50tFHoE/+s4CcUAZP3OFI5fraaxPYIcSwIlN+WDV8L/E0/nmdKA8klzu5tOtJpPWDr77lxDKzRplhf8pLxt87ylhz3S7Qu7yTEk1nQhpriCeyCP2boBsR8G/+DuapkQTnm4cmOFP3SmeZCusDLWQ5FjNEnsnlg/d8Tc9IrXVfv0hA4KjIoSAPHNqZBBHPHAQropXw3iu97dddku2hxxddhsxz7yLLIAhoX/TsfkF6RNegzpwEYfjgB9mkN4t5Tm0BlsPULK/cLp5g3Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ua7yM+VVfpp8EgOO1SaS2l9ipP4P8imyENUB8WILPDs=; b=abVQGkQoF1xFYUGeQntu710KmaQLhl04mYexn9BvwdpYL902g6iWWbYEs9nBR/8I5zgvJZYvIM0jo90o/wHQPoCdVxoUweB3DFHtbwKZvqxUMSBuqG5Eqv/jZtRHYuIjDuKwi3caY3bm5oI2rgsRS+jnayjwAM/5DBnUsr4CalQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=prevas.dk; Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) by DB8PR10MB3337.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:113::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Thu, 13 Oct 2022 07:29:25 +0000 Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::dc91:193:719e:5fb0]) by DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::dc91:193:719e:5fb0%8]) with mapi id 15.20.5676.044; Thu, 13 Oct 2022 07:29:25 +0000 Message-ID: <4abe5029-b8fd-efdc-3144-b89a8dec3fe4@prevas.dk> Date: Thu, 13 Oct 2022 09:29:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] image: Suppress string truncation warning Content-Language: en-US To: Michal Suchanek , u-boot@lists.denx.de Cc: Andre Przywara , Heinrich Schuchardt , Jan Kiszka , Philippe Reynes , Sean Anderson , Simon Glass , Steven Lawrance References: <20221012194725.5628-1-msuchanek@suse.de> From: Rasmus Villemoes In-Reply-To: <20221012194725.5628-1-msuchanek@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MM0P280CA0109.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:9::7) To DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR10MB5266:EE_|DB8PR10MB3337:EE_ X-MS-Office365-Filtering-Correlation-Id: e4391e98-6363-4948-cbab-08daaceca78f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0q8TUvnjEQw+5AAIKg8mJFCPG/UxhEbI0A42xKpzcTCULu+v2Nz+yDKl3EJmUM8BACyucWxLK85Xa2rSP/hMABDkIr0+tuAJrbJGZcuteLJ05iIbsrNjHugsNTlVLR+SJaIje0/zy8cpg82B/9SiGCEizgeoaXFLVnnleDKM0RvJtsBoQ5NzmXzbJ+ZahVC89e2XfjUSYsF+84/v6C4Ep1JJoqOtrhvR6KKA7jI+19ndP2ehhZ0zHLLlAVZoX0DrVh8Jmw3A7uhvsECJx1g4IsrI4BnB3rqogJfo+uMVxuyeKMmzdCM9lFzWoewxi+En8DVHx/gshxZ0SsYrHfkDHV9O58YSRrlgyPsUSMaqFo1ZVlK7BAJon0Or6RNllycFmrXKR/adBS13UVqrrJFcdR6jK8cY16Cgf0EFPNcPRa7Lm18RY0jIXrRG/mhDGLRhhx1IC0UCyScbFTHrN0l4Cutdn3EXv3W8w9hcSpdMqXNsIK0Om3kZyB4bAOov0KThou/uO91oBeJQ8RCcgvXy40Mzzja0rqHun99etkW0aZOTJkNtpHUt828UDOCm7vVdvKd+U72JSwJrS+RD8c0HxbFsvdLaJS8/eTtu1kk5Dwu2rdcxPd+c25ABdZj26SWoe13dPggPUYjm44Zq8e14zMYAouCWchbZeBCqpwU1nAf6HUKrwi6wkpBf9vLt/bQwarLsHHMmkEQHSf1l7dZ0xZocPJEGvxpNB0R1/8XrvVtAY8xF7rIg9l6S4S0qrntAEMPDbfiXxWkTyq5k/Gu/kyxi+L7EvTgFi/NeDvqTGmGS5fpEhtFsgqlv3AS0u3qU0ZNIB09gnRj6orXfbvrCYxP4Uqf//b6Fze+legZ5xkY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(396003)(39850400004)(376002)(136003)(366004)(346002)(451199015)(478600001)(6666004)(6506007)(36756003)(6486002)(52116002)(31696002)(86362001)(38100700002)(38350700002)(966005)(2616005)(6512007)(186003)(83380400001)(8676002)(4326008)(66476007)(41300700001)(31686004)(2906002)(5660300002)(66946007)(316002)(26005)(8976002)(44832011)(8936002)(66556008)(54906003)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmQ1dDFZaHg0NXRWTE5nN3dyQjdSVVlWdVpLWGdpWE9MY09FbStzcUVvLzQx?= =?utf-8?B?Y1B6NVB5OU1NU1JQdTVHdnBrYUdTWHExUjlxYm83R2NLTlF0bGlzSHZQUk9i?= =?utf-8?B?TFMrTWxiNldwVzFIQTV6YVdpamJRRm1TQ3RTSDU3OVhtR1R5a2JvV1o4cG5K?= =?utf-8?B?YTUyQy9sS2t5RmordHN6eTlGbkZRWlc5QkRIaDVxdlU4MW05NTRXT0pHQkZw?= =?utf-8?B?ZG1HSmw3V1RQeW9qWXREQjZkd2swRkR2emhuV3FKWEhJcVFmTE11WE5QYk5l?= =?utf-8?B?ajdmQXJ0ZDdMbVdhYlBjSjRSbXFBZ2tRNXVCNWN5TVRvd1l1VkhqYU1IcWEx?= =?utf-8?B?cHQvdUU5eTN1SzVHL1JRWHlNS0pyMloxZmZtOE9MdThvWWd1QlJPWGt2OU8x?= =?utf-8?B?Z0R5VFhJTW40TkYwRWVCdyt1ZURiMmZ6eG4yQ0xPUVo4Qk52WEZGWWpNakFu?= =?utf-8?B?aVJvQnRObFdYSWNVeTBrdEZXYmVhMXVXcUpTL21ISi9obHRvc1BDQlgyaGUz?= =?utf-8?B?Mk1wOHdocGNRL0hKc2RYUXZ0aTMvaGZFK1FKZ3hGUVJxamF6UjFxWjJ0VmZR?= =?utf-8?B?cEptR29lcVB6UWxtb2JGcVg1YUtTbEx1dWNKeGxHMHplRUlabmtKYTZGRXEw?= =?utf-8?B?ZUNmaTJHYXFxZ2J1clIyY0VWVjdBbGU4YmxMY3ZWYzdMZjVTT2x0eThuTVJN?= =?utf-8?B?V0NtVGY1ZmUwa01hSmJ3emNZNFVWVjJDenNIWDUxdTlIK203d1B0T25RRmVS?= =?utf-8?B?enlBdXBqOGhjSXREak9XQi9aaSt2UkpQdk1LTVkzQTNoSXBhazhBUDU4aFRO?= =?utf-8?B?OTVXNGQ3eWwwYzhRbmlUMjJGMEY4OFVHN21LdithbitSODg5OW9sa3BJZU1H?= =?utf-8?B?czlkS2lnbU50dlpHb1Z4WXVwL0tEeElBQzFVWWpMeERXNlFXQ2hBMzJGTnht?= =?utf-8?B?RnV2S1kxS1A3dHBrWFdnYi9rakRlRTFBdGNTaUF5RnpXaVJqUzhtMjRxaGJk?= =?utf-8?B?cXQvRlBPcDBabjVsTXNYQXFlMXVrTEQwOTY0RGpDQTk3UkQ3Yy80UWxlRnpw?= =?utf-8?B?Y0xsUWVtMG5PUU5hWE5TQXYrZnp0SnNDWVp4NjJ2T1J3NHYyNGNLUTBxd1hT?= =?utf-8?B?Qkl2NWpNRjRvMEh3MURSWVJ5bm1CTjJ3Rjd4dGg2STVBNlFpdWg2VUhOVHZC?= =?utf-8?B?eEJMWjVTSkVqSEJlN3pDQk1vZVBJa2ozL0l6d3ZSNGFtQ0gxdWF1cVV5UEZM?= =?utf-8?B?Z3hiRjh0RCtzUmNKdEdMQWp5WkNaUmZIOTNBd29LTEVDcm1GdXJoU2JDdkdZ?= =?utf-8?B?eWdZejE3ZHJtcXNQVUVqaGxucnp2K3R5dHhWNzFnTStsRGdGNGl2TWNqcDdx?= =?utf-8?B?ZStSblBEZXdwZFQ2amZTQlJHbmJaN2s1emdSWlNHOE5RRWhjWWJKQ1d2bEds?= =?utf-8?B?SXVBaGhuWHg5MDFmaWx0SlRUUlcwM3RySXpacTZMckx3VGJyYXBlZDEwendz?= =?utf-8?B?Vi90SWxOSnF0QTZCYm5GUThFRTNCSm5jV3gxZUJuWktnY3dDbG14cXZjOE9H?= =?utf-8?B?VnlubXYwMHBrQU5zMit1WXFaTk9ETm5xWmRpeG9EWlljUFEyRnhxQ1RkaU4r?= =?utf-8?B?aEhucitpblRORmM1RzM2QTZ5K01sbi9NZmFYUXd4SWpZbFVzOFV4U2lnMnJh?= =?utf-8?B?RVBjVzEvOXBPVGRzdHpoUGNNK050bE8rVE4rdHVBNGpyTjg2SEpEeUFUbTll?= =?utf-8?B?ZkZVK1JOUlAwRjVqUUw1WnhsNnF0aEl6dlJBY3IxUEdhMHp6N2lKOThyeTR0?= =?utf-8?B?WElOczNUa3N4TFJRb2Y4UGNITnIrYTJ1Z3ZFOEpxYk1rZDFVSEFWdTFhbms2?= =?utf-8?B?cGJIemlxMUlNb3BXaGFQN0wzc2NkZGdod29IV0gxY0NhWXZKY2hXWTdhVjcw?= =?utf-8?B?bmJNUHh3MlpSajRwYXd2SHphN3NTanRCa1RwaEY5Z0VGZ1hDVnI4T1VlaGRj?= =?utf-8?B?U3gyUkpaVmN0YkpQYzVlYWdwQXR2ZmRBSWRhSmdlbGxLMTV0VGxsNlExRDhC?= =?utf-8?B?cXNuLzhkWnhPb2VyUkxLdklaQm1HeVRMQStIMFplK1hkRmlyM1MrUkhNSFhx?= =?utf-8?B?MU1DdTBITm9MbDdrZWliM0pFL2licE1JQW0vWmY1anpqTk5wMU1kQW9PYjB6?= =?utf-8?B?THc9PQ==?= X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: e4391e98-6363-4948-cbab-08daaceca78f X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 07:29:25.1230 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DN9j93eRUE3NJXQZrvclZ2ewhNE+mBKY6UT6ANPFNrN6tv5E6yYts/IkeXrNc4RRjGNsl1CHQKDdQVvdYyUIShiMdsKG8833M6L5LSWOeRM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3337 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 12/10/2022 21.47, Michal Suchanek wrote: > In file included from ../tools/imagetool.h:24, > from ../tools/default_image.c:16: > In function ‘image_set_name’, > inlined from ‘image_set_header’ at ../tools/default_image.c:133:2: > ../include/image.h:786:9: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] > 786 | strncpy(image_get_name(hdr), name, IH_NMLEN); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > There is no standard function that can be used to make the copy without > a warning. True, but the compiler does give a way to inform that the destination is not _supposed_ to be a nul-terminated string. https://lore.kernel.org/u-boot/dad17a9f-d823-1e8b-3381-53961294521c@prevas.dk/ And our include/linux/compiler_attributes.h indeed already exposes that __nonstring attribute. Perhaps try applying that to the ih_name member. It may also be necessary to drop the image_get_name() indirection and just use hdr->ih_name directly; though gcc obviously sees through it to account for the size of the destination buffer (otherwise it couldn't warn), I'm not sure it won't lose that attribute. Rasmus