From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Engine relative MMIO Date: Mon, 20 May 2019 07:19:58 +0100 Message-ID: <4afc2fff-64a9-be97-d695-d595838df64a@linux.intel.com> References: <20190513194552.6600-1-John.C.Harrison@Intel.com> <2f07e749-7e44-d3ae-08a7-2b45b811419c@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7100289175 for ; Mon, 20 May 2019 06:20:01 +0000 (UTC) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John Harrison , Intel-GFX@Lists.FreeDesktop.Org Cc: Chris P List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE3LzA1LzIwMTkgMDI6MjUsIEpvaG4gSGFycmlzb24gd3JvdGU6Cj4gT24gNS8xNS8yMDE5 IDAxOjUyLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4KPj4gT24gMTMvMDUvMjAxOSAyMDo0NSwg Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbSB3cm90ZToKPj4+IEZyb206IEpvaG4gSGFycmlzb24g PEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4+Pgo+Pj4gV2l0aCB2aXJ0dWFsIGVuZ2luZXMs IGl0IGlzIG5vIGxvbmdlciBwb3NzaWJsZSB0byBrbm93IHdoaWNoIHNwZWNpZmljCj4+PiBwaHlz aWNhbCBlbmdpbmUgYSBnaXZlbiByZXF1ZXN0IHdpbGwgYmUgZXhlY3V0ZWQgb24gYXQgdGhlIHRp bWUgdGhhdAo+Pj4gcmVxdWVzdCBpcyBnZW5lcmF0ZWQuIFRoaXMgbWVhbnMgdGhhdCB0aGUgcmVx dWVzdCBpdHNlbGYgbXVzdCBiZSBlbmdpbmUKPj4+IGFnbm9zdGljIC0gYW55IGRpcmVjdCByZWdp c3RlciB3cml0ZXMgbXVzdCBiZSByZWxhdGl2ZSB0byB0aGUgZW5naW5lCj4+PiBhbmQgbm90IGFi c29sdXRlIGFkZHJlc3Nlcy4KPj4+Cj4+PiBUaGUgTFJJIGNvbW1hbmQgaGFzIHN1cHBvcnQgZm9y IGVuZ2luZSByZWxhdGl2ZSBhZGRyZXNzaW5nLiBIb3dldmVyLAo+Pj4gdGhlIG1lY2hhbmlzbSBp cyBub3QgdHJhbnNwYXJlbnQgdG8gdGhlIGRyaXZlci4gVGhlIHNjaGVtZSBmb3IgR2VuMTEKPj4+ IChNSV9MUklfQUREX0NTX01NSU9fU1RBUlQpIHJlcXVpcmVzIHRoZSBMUkkgYWRkcmVzcyB0byBo YXZlIG5vCj4+PiBhYnNvbHV0ZSBlbmdpbmUgYmFzZSBjb21wb25lbnQuIFRoZSBoYXJkd2FyZSB0 aGVuIGFkZHMgb24gdGhlIGNvcnJlY3QKPj4+IGVuZ2luZSBvZmZzZXQgYXQgZXhlY3V0aW9uIHRp bWUuCj4+Pgo+Pj4gRHVlIHRvIHRoZSBub24tdHJpdmlhbCBhbmQgZGlmZmVyaW5nIHNjaGVtZXMg b24gZGlmZmVyZW50IGhhcmR3YXJlLCBpdAo+Pj4gaXMgbm90IHBvc3NpYmxlIHRvIHNpbXBseSB1 cGRhdGUgdGhlIGNvZGUgdGhhdCBjcmVhdGVzIHRoZSBMUkkKPj4+IGNvbW1hbmRzIHRvIHNldCBh IHJlbWFwIGZsYWcgYW5kIGxldCB0aGUgaGFyZHdhcmUgZ2V0IG9uIHdpdGggaXQuCj4+PiBJbnN0 ZWFkLCB0aGlzIHBhdGNoIGFkZHMgZnVuY3Rpb24gd3JhcHBlcnMgZm9yIGdlbmVyYXRpbmcgdGhl IExSSQo+Pj4gY29tbWFuZCBpdHNlbGYgYW5kIHRoZW4gZm9yIGNvbnN0cnVjdGluZyB0aGUgY29y cmVjdCBhZGRyZXNzIHRvIHVzZQo+Pj4gd2l0aCB0aGUgTFJJLgo+Pj4KPj4+IHYyOiBGaXggYnVp bGQgYnJlYWsgaW4gR1ZULiBSZW1vdmUgZmxhZ3MgcGFyYW1ldGVyIFtyZXZpZXcgZmVlZGJhY2sK Pj4+IGZyb20gQ2hyaXMgV10uCj4+Pgo+Pj4gdjM6IEZpeCBidWlsZCBicmVhayBpbiBzZWxmdGVz dC4gUmViYXNlIHRvIG5ld2VyIGJhc2UgdHJlZSBhbmQgZml4Cj4+PiBtZXJnZSBjb25mbGljdC4K Pj4+Cj4+PiB2NDogTW9yZSByZWJhc2luZy4gUm1vdmVkIHJlbGF0aXZlIGFkZHJlc3Npbmcgc3Vw cG9ydCBmcm9tIEdlbjctOSBvbmx5Cj4+PiBjb2RlIHBhdGhzIFtyZXZpZXcgZmVlZGJhY2sgZnJv bSBDaHJpcyBXXS4KPj4+Cj4+PiB2NTogTW9yZSByZWJhc2luZyAobmV3ICdndCcgZGlyZWN0b3J5 KS4gRml4IHdoaXRlIHNwYWNlIGlzc3VlLiBVc2UKPj4+IENPUFkgY2xhc3MgcmF0aGVyIHRoYW4g QkNTMCBpZCBmb3IgY2hlY2tpbmcgYWdhaW5zdCBCQ1MgZW5naW5lLgo+Pj4KPj4+IFNpZ25lZC1v ZmYtYnk6IEpvaG4gSGFycmlzb24gPEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4+PiBDQzog Um9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+Pj4gQ0M6IFR2cnRrbyBVcnN1 bGluIDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5jb20+Cj4+PiBDQzogV2lsc29uLCBDaHJp cyBQIDxjaHJpcy5wLndpbHNvbkBpbnRlbC5jb20+Cj4+PiAtLS0KPj4+IMKgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2d0L2ludGVsX2VuZ2luZS5owqDCoMKgwqDCoMKgwqAgfMKgIDQgKwo+Pj4gwqAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfZW5naW5lX2NzLmPCoMKgwqDCoCB8IDExICsr Kwo+Pj4gwqAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfZ3B1X2NvbW1hbmRzLmjCoCB8 wqAgNiArLQo+Pj4gwqAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbHJjLmPCoMKgwqDC oMKgwqDCoMKgwqDCoCB8IDc5ICsrKysrKysrKystLS0tLS0tLS0KPj4+IMKgIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2d0L2ludGVsX2xyY19yZWcuaMKgwqDCoMKgwqDCoCB8wqAgNCArLQo+Pj4gwqAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbW9jcy5jwqDCoMKgwqDCoMKgwqDCoMKgIHwg MTcgKystLQo+Pj4gwqAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfcmluZ2J1ZmZlci5j wqDCoMKgIHwgNDUgKysrKysrKysrLS0KPj4+IMKgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2lu dGVsX3dvcmthcm91bmRzLmPCoMKgIHzCoCA0ICstCj4+PiDCoCAuLi4vZ3B1L2RybS9pOTE1L2d0 L3NlbGZ0ZXN0X3dvcmthcm91bmRzLmPCoMKgwqAgfMKgIDkgKystCj4+PiDCoCBkcml2ZXJzL2dw dS9kcm0vaTkxNS9ndnQvbW1pb19jb250ZXh0LmPCoMKgwqDCoMKgwqAgfCAxNiArKystCj4+PiDC oCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2NtZF9wYXJzZXIuY8KgwqDCoMKgwqDCoMKgIHzC oCA0ICstCj4+PiDCoCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmPCoMKg wqDCoMKgwqAgfCAxMiArLS0KPj4+IMKgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4 ZWNidWZmZXIuY8KgwqDCoCB8wqAgMyArLQo+Pj4gwqAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9wZXJmLmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8IDE5ICsrKy0tCj4+PiDCoCAxNCBm aWxlcyBjaGFuZ2VkLCAxNTQgaW5zZXJ0aW9ucygrKSwgNzkgZGVsZXRpb25zKC0pCj4+Pgo+Pj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2VuZ2luZS5oIAo+Pj4g Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9lbmdpbmUuaAo+Pj4gaW5kZXggOTM1OWIz YTdhZDljLi4zNTA2Yzk5MjE4MmMgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9ndC9pbnRlbF9lbmdpbmUuaAo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50 ZWxfZW5naW5lLmgKPj4+IEBAIC01NDYsNCArNTQ2LDggQEAgc3RhdGljIGlubGluZSBib29sIGlu amVjdF9wcmVlbXB0X2hhbmcoc3RydWN0IAo+Pj4gaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqZXhl Y2xpc3RzKQo+Pj4gwqAgwqAgI2VuZGlmCj4+PiDCoCArYm9vbCBpOTE1X2VuZ2luZV9oYXNfcmVs YXRpdmVfbHJpKGNvbnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgCj4+PiAqZW5naW5lKTsKPj4+ ICt1MzIgaTkxNV9nZXRfbHJpX2NtZChjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmUsIHUzMiAKPj4+IHdvcmRfY291bnQpOwo+Pj4gK3UzMiBpOTE1X2dldF9scmlfcmVnKGNvbnN0 IHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgCj4+PiBpOTE1X3JlZ190IHJlZyk7Cj4+ PiArCj4+PiDCoCAjZW5kaWYgLyogX0lOVEVMX1JJTkdCVUZGRVJfSF8gKi8KPj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9lbmdpbmVfY3MuYyAKPj4+IGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfZW5naW5lX2NzLmMKPj4+IGluZGV4IDRjMzc1M2Mx YjU3My4uMjMzMjk1ZDY4OWQyIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv Z3QvaW50ZWxfZW5naW5lX2NzLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2lu dGVsX2VuZ2luZV9jcy5jCj4+PiBAQCAtMjUzLDYgKzI1MywxNyBAQCBzdGF0aWMgdTMyIF9fZW5n aW5lX21taW9fYmFzZShzdHJ1Y3QgCj4+PiBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+Pj4gwqDC oMKgwqDCoCByZXR1cm4gYmFzZXNbaV0uYmFzZTsKPj4+IMKgIH0KPj4+IMKgICtib29sIGk5MTVf ZW5naW5lX2hhc19yZWxhdGl2ZV9scmkoY29uc3Qgc3RydWN0IGludGVsX2VuZ2luZV9jcyAKPj4+ ICplbmdpbmUpCj4+PiArewo+Pj4gK8KgwqDCoCBpZiAoSU5URUxfR0VOKGVuZ2luZS0+aTkxNSkg PCAxMSkKPj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gZmFsc2U7Cj4+PiArCj4+PiArwqDCoMKg IGlmIChlbmdpbmUtPmNsYXNzID09IENPUFlfRU5HSU5FX0NMQVNTKQo+Pj4gK8KgwqDCoMKgwqDC oMKgIHJldHVybiBmYWxzZTsKPj4+ICsKPj4+ICvCoMKgwqAgcmV0dXJuIHRydWU7Cj4+Cj4+IEkg dGhpbmsgZW5naW5lLT5mbGFncyB3b3VsZCBiZSBiZXR0ZXIuIEF0IGxlYXN0IGl0IGlzIG9uZSBj b25kaXRpb25hbCAKPj4gaW5zdGVhZCBvZiB0d28gYXQgcnVudGltZSwgZXZlbiBvbmUgdG9vIG1h bnkgZm9yIHNvbWV0aGluZyB0aGF0IGlzIAo+PiBpbnZhcmlhbnQuCj4+Cj4+PiArfQo+Pj4gKwo+ Pj4gwqAgc3RhdGljIHZvaWQgX19zcHJpbnRfZW5naW5lX25hbWUoY2hhciAqbmFtZSwgY29uc3Qg c3RydWN0IAo+Pj4gZW5naW5lX2luZm8gKmluZm8pCj4+PiDCoCB7Cj4+PiDCoMKgwqDCoMKgIFdB Uk5fT04oc25wcmludGYobmFtZSwgSU5URUxfRU5HSU5FX0NTX01BWF9OQU1FLCAiJXMldSIsCj4+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfZ3B1X2NvbW1hbmRz LmggCj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2dwdV9jb21tYW5kcy5oCj4+ PiBpbmRleCBhMzRlY2U1M2E3NzEuLmU3Nzg0YjNmYjc1OSAxMDA2NDQKPj4+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2dwdV9jb21tYW5kcy5oCj4+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9ncHVfY29tbWFuZHMuaAo+Pj4gQEAgLTEyMyw5ICsxMjMs MTMgQEAKPj4+IMKgwqAgKsKgwqAgc2ltcGx5IGlnbm9yZXMgdGhlIHJlZ2lzdGVyIGxvYWQgdW5k ZXIgY2VydGFpbiBjb25kaXRpb25zLgo+Pj4gwqDCoCAqIC0gT25lIGNhbiBhY3R1YWxseSBsb2Fk IGFyYml0cmFyeSBtYW55IGFyYml0cmFyeSByZWdpc3RlcnM6IAo+Pj4gU2ltcGx5IGlzc3VlIHgK Pj4+IMKgwqAgKsKgwqAgYWRkcmVzcy92YWx1ZSBwYWlycy4gRG9uJ3Qgb3ZlcmR1ZSBpdCwgdGhv dWdoLCB4IDw9IDJeNCBtdXN0IAo+Pj4gaG9sZCEKPj4+ICsgKiAtIE5ld2VyIGhhcmR3YXJlIHN1 cHBvcnRzIGVuZ2luZSByZWxhdGl2ZSBhZGRyZXNzZXMgYnV0IG9sZGVyIAo+Pj4gaGFyZHdhcmUg ZG9lcwo+Pj4gKyAqwqDCoCBub3QuIFNvIG5ldmVyIGNhbGwgTUlfTFJJIGRpcmVjdGx5LCBhbHdh eXMgdXNlIHRoZSAKPj4+IGk5MTVfZ2V0X2xyaV9jbWQoKQo+Pj4gKyAqwqDCoCBhbmQgaTkxNV9n ZXRfbHJpX3JlZygpIGhlbHBlciBmdW5jdGlvbnMuCj4+PiDCoMKgICovCj4+PiAtI2RlZmluZSBN SV9MT0FEX1JFR0lTVEVSX0lNTSh4KcKgwqDCoCBNSV9JTlNUUigweDIyLCAyKih4KS0xKQo+Pj4g KyNkZWZpbmUgX19NSV9MT0FEX1JFR0lTVEVSX0lNTSh4KcKgwqDCoCBNSV9JTlNUUigweDIyLCAy Kih4KS0xKQo+Pgo+PiBTbyB3ZSBlbmQgdXAgd2l0aCBjb2RlIHVzaW5nIF9fTUlfTE9BRF9SRUdJ U1RFUl9JTU0gZm9yIGFic29sdXRlLCBhbmQgCj4+IGk5MTVfZ2V0X2xyaV9jbWQgZm9yIHJlbGF0 aXZlIGFkZHJlc3NpbmcuIE9uZSBpcyBhIG1hY3JvLCBhbm90aGVyIGlzIGEgCj4+IGZ1bmN0aW9u IGNhbGwsIGFuZCBuYW1pbmcvY2FzZSBpcyBkaWZmZXJlbnQuCj4gCj4gTm8uIFRoZSBfX01fTF9S X0lNTSB2ZXJzaW9uIGlzIGZvciBvbGQgY29kZSB0aGF0IGNhbiBvbmx5IHJ1biBvbiAKPiBwcmUt R2VuMTEgZGV2aWNlcy4gVGhlIGhlbHBlciBmdW5jdGlvbiBpcyBmb3IgYWxsIG90aGVyIGNvZGUu IFRoZSBjYWxsZXIgCj4gZG9lcyBub3Qga25vdyAob3IgY2FyZSkgd2hldGhlciBpdCBzaG91bGQg YmUgdXNpbmcgYWJzb2x1dGUgb3IgcmVsYXRpdmUgCj4gYWRkcmVzc2luZy4gVGhhdCBpcyB0aGUg cG9pbnQgb2YgdGhlIGhlbHBlci4KPiAKPiBTZWUgZWFybGllciBkaXNjdXNzaW9uIGFib3V0IHdh bnRpbmcgdG8gbWFrZSBpdCB0b3RhbGx5IG9idmlvdXMgdGhhdCAKPiB1c2luZyB0aGUgc2ltcGxl IG1hY3JvIHZlcnNpb24gaXMgdGhlIHdyb25nIHRoaW5nIHRvIGRvIGluIG5ldyBjb2RlLgo+IAo+ IAo+PiAuLi4KPj4KPj4gVGhlbiBhbGwgY2FsbCBzaXRlcyBjYW4gdXNlIGp1c3QgdGhpcyBzaW5n bGUgaGVscGVyIGFuZCB0aGUgbmFtaW5nIAo+PiByZW1haW5zIGZhbWlsaWFyLgo+Pgo+IAo+IEkg b3JpZ2luYWxseSBoYWQgYSBzaW5nbGUgaGVscGVyIHRvIGJlIHVzZWQgaW4gYWxsIGNhbGwgc2l0 ZXMuIENocmlzIAo+IG9iamVjdGVkIHZpb2xlbnRseSB0byB0aGUgaWRlYSBvZiBjYWxsaW5nIGEg aGVscGVyIGluIGNvZGUgdGhhdCBpcyAKPiBwdXJlbHkgcHJlLUdlbjExIGFuZCB0aHVzIGhhcyBu byBuZWVkIG9mIHRoZSBoZWxwZXIuCj4gCj4gT24gdGhlIG90aGVyIGhhbmQsIFJvZHJpZ28gYWdy ZWVkIHdpdGggeW91IHRoYXQgdXNpbmcgdGhlIGhlbHBlciAKPiBldmVyeXdoZXJlIHdhcyBjbGVh bmVyLiBTbyBpdCBpcyBub3cgYSAyIHZzIDEgdm90ZS4uLgoKTWF5YmUgbGVhdmluZyB0aGUgbGVn YWN5IGNvZGUgdXNlIHRoZSBleGlzdGluZyBNSV9MT0FEX1JFR0lTVEVSX0lNTSAKdGhlbiwgYW5k IGp1c3QgY2FsbGluZyB0aGUgbmV3IG9uZSBNSV9MT0FEX1JFR0lTVEVSX0lNTV9SRUwgd291bGQg YmUgCnBhc3NhYmxlPyBJdCB3b3VsZCBzYXRpc2Z5IG15IGNvbXBsYWludCB0aGF0IHR3byBoZWxw ZXJzIGxvb2sgc28gCnJhZGljYWxseSBkaWZmZXJlbnQuIFdvdWxkIG1ha2UgQ2hyaXMgaGFwcHkg YW5kIHdvdWxkIG1ha2UgdGhlIHBhdGNoIApzbWFsbGVyIEkgdGhpbmsuCgpSZWdhcmRzLAoKVHZy dGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==