Content-Type: multipart/mixed; boundary="===============6255666293306090434==" MIME-Version: 1.0 From: Keller, Jacob E To: kbuild-all@lists.01.org Subject: Re: [PATCH] ethernet/intel: fix PTP_1588_CLOCK dependencies Date: Tue, 27 Jul 2021 07:25:04 +0000 Message-ID: <4b305f11-8cb5-03cd-07bd-12625cf35949@intel.com> In-Reply-To: List-Id: --===============6255666293306090434== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 7/26/2021 5:27 AM, Arnd Bergmann wrote: > On Mon, Jul 26, 2021 at 12:29 PM kernel test robot wrot= e: > = >>>> drivers/i2c/Kconfig:8:error: recursive dependency detected! >> drivers/i2c/Kconfig:8: symbol I2C is selected by IGB >> drivers/net/ethernet/intel/Kconfig:87: symbol IGB depends on PTP_1588= _CLOCK >> drivers/ptp/Kconfig:8: symbol PTP_1588_CLOCK is implied by MLX4_EN >> drivers/net/ethernet/mellanox/mlx4/Kconfig:6: symbol MLX4_EN depends = on NET_VENDOR_MELLANOX >> drivers/net/ethernet/mellanox/Kconfig:6: symbol NET_VENDOR_MELLANOX d= epends on I2C >> For a resolution refer to Documentation/kbuild/kconfig-language.rst >> subsection "Kconfig recursive dependency limitations" > = > Sorry about this, the patch I was testing with has this additional hunk > = > @@ -88,7 +88,7 @@ config IGB > tristate "Intel(R) 82575/82576 PCI-Express Gigabit Ethernet suppo= rt" > depends on PCI > depends on PTP_1588_CLOCK || !PTP_1588_CLOCK > - select I2C > + depends on I2C > select I2C_ALGOBIT > help > This driver supports Intel(R) 82575/82576 gigabit ethernet fami= ly of > = > that I even describe in the changelog but forgot to include in the patch = I sent. > = > Arnd > = With this hunk applied, everything looks good to me. Thanks for the fix! It would be nice if this sort of dependency had a keyword or some other slightly more intuitive way of handling it. We could make run-time IS_REACHABLE checks so that the functions which call into enable PTP support were disabled at run time in that case, I suppose as an alternative fix to this.... Acked-by: Jacob Keller --===============6255666293306090434==--