Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3201C43461 for ; Wed, 16 Sep 2020 08:01:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3812D2083B for ; Wed, 16 Sep 2020 08:01:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="idT3QiXX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3812D2083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kISNs-0004xf-7X for qemu-devel@archiver.kernel.org; Wed, 16 Sep 2020 04:01:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kISN3-0004Nc-3u for qemu-devel@nongnu.org; Wed, 16 Sep 2020 04:00:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53713) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kISMw-0002dy-GM for qemu-devel@nongnu.org; Wed, 16 Sep 2020 04:00:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600243245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TCGiChUSkYqdT+AHpHEpBa+8QltjNXCQrvKsHv1lud4=; b=idT3QiXXqld0FxJFLBoAluJ2X5kKeVfS9/YY62JpRInykufsFChrfsgqYHwNFsidl9wxHz 1nBnkPN1gZQeqWIDBv1MeUXZ9RQ25wCQ92S6+tEkGZx8kbvpmUjgHvU5G5z/78OvUA9Rog SHMVox+KNjVk7V5F4Kzz7+1rM3I6an0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-533-Y5FvVkb-PlODYpO5ZQbxrA-1; Wed, 16 Sep 2020 04:00:43 -0400 X-MC-Unique: Y5FvVkb-PlODYpO5ZQbxrA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3055989BBA1; Wed, 16 Sep 2020 08:00:39 +0000 (UTC) Received: from thuth.remote.csb (ovpn-113-19.ams2.redhat.com [10.36.113.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id B1C1E81C4D; Wed, 16 Sep 2020 08:00:16 +0000 (UTC) Subject: Re: [PATCH v6 3/8] s390/sclp: read sccb from mem based on provided length To: Collin Walling , qemu-devel@nongnu.org, qemu-s390x@nongnu.org References: <20200915194416.107460-1-walling@linux.ibm.com> <20200915194416.107460-4-walling@linux.ibm.com> From: Thomas Huth Message-ID: <4bb9871d-e4d3-bd28-6718-548a32d21961@redhat.com> Date: Wed, 16 Sep 2020 10:00:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200915194416.107460-4-walling@linux.ibm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/16 02:16:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, mst@redhat.com, pbonzini@redhat.com, sumanthk@linux.ibm.com, mihajlov@linux.ibm.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 15/09/2020 21.44, Collin Walling wrote: > The header contained within the SCCB passed to the SCLP service call > contains the actual length of the SCCB. Instead of allocating a static > 4K size for the work sccb, let's allow for a variable size determined > by the value in the header. The proper checks are already in place to > ensure the SCCB length is sufficent to store a full response and that > the length does not cross any explicitly-set boundaries. > > Signed-off-by: Collin Walling > --- > hw/s390x/event-facility.c | 2 +- > hw/s390x/sclp.c | 55 ++++++++++++++++++++++----------------- > include/hw/s390x/sclp.h | 2 +- > 3 files changed, 33 insertions(+), 26 deletions(-) Reviewed-by: Thomas Huth