Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F6E5C001B0 for ; Thu, 10 Aug 2023 15:26:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 57655867D0; Thu, 10 Aug 2023 17:26:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1691681166; bh=YRpoRlNLFsb6VaBfy2CA6vmZNohZdlXSqywjjnmi9xY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=c0Z9LteR1pQXMFLWLMFCasT3SpWSLCn+Ym5Pj5YpVFMgR7GqxiaQONJ07beIXTY0b c7uMSKXCPPT3v+kyzdyFR/3iZG94N82jO9AcyrC+ZN8gTbr45HyYLf2mQ8NBhBgUgd c1J26WeE/1m9QT4kbrRdOc+NxDVGCoc713ytoEpKtazItwn0jny8n2IU0mvqN3LfAj lvFsFhEESmqNaa7v/nEclQsmCacrN3sfKDecmp3K46hIxnz/7Nw3hHSMJwiojaq/Wn 0/t40qX/y4qVYTj7iV0JGir69QUd1WZ8vZtjVLBAr0YlxfLVueh5nI8faFq/TsWw54 tG4L0u9PkT2Dw== Received: by phobos.denx.de (Postfix, from userid 109) id 2E04386851; Thu, 10 Aug 2023 17:26:05 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [80.241.59.204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6985B86725 for ; Thu, 10 Aug 2023 17:26:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4RM9k12xfHz9sRf; Thu, 10 Aug 2023 17:26:01 +0200 (CEST) Message-ID: <4bfe2b0f-3bc6-fb20-a7db-bb7a7deda88f@denx.de> Date: Thu, 10 Aug 2023 17:26:00 +0200 MIME-Version: 1.0 Subject: Re: [PATCH] cmd: cyclic: Remove duplicate command name in help text Content-Language: en-US To: Alexander Dahl Cc: u-boot@lists.denx.de References: <20230804155323.198234-1-ada@thorsis.com> From: Stefan Roese In-Reply-To: <20230804155323.198234-1-ada@thorsis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 8/4/23 17:53, Alexander Dahl wrote: > Function 'cmd_usage()' already prints one command in usage before > printing out the help text given to the U_BOOT_CMD_WITH_SUBCMDS macro. > > Wrong previous output: > > Usage: > cyclic cyclic demo - register cyclic demo function > cyclic list - list cyclic functions > > Signed-off-by: Alexander Dahl Applied to u-boot-watchdog/master Thanks, Stefan > --- > cmd/cyclic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/cyclic.c b/cmd/cyclic.c > index 97324d8240..946f1d7818 100644 > --- a/cmd/cyclic.c > +++ b/cmd/cyclic.c > @@ -77,7 +77,7 @@ static int do_cyclic_list(struct cmd_tbl *cmdtp, int flag, int argc, > } > > static char cyclic_help_text[] = > - "cyclic demo - register cyclic demo function\n" > + "demo - register cyclic demo function\n" > "cyclic list - list cyclic functions\n"; > > U_BOOT_CMD_WITH_SUBCMDS(cyclic, "Cyclic", cyclic_help_text, > > base-commit: 989892f5805dc205033c4723bc8e024472564d16 Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de