Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72F53EB64DD for ; Mon, 7 Aug 2023 08:13:28 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.577807.904841 (Exim 4.92) (envelope-from ) id 1qSvMd-0006EC-Fm; Mon, 07 Aug 2023 08:13:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577807.904841; Mon, 07 Aug 2023 08:13:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvMd-0006E5-Co; Mon, 07 Aug 2023 08:13:19 +0000 Received: by outflank-mailman (input) for mailman id 577807; Mon, 07 Aug 2023 08:13:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvMb-0006Dt-Sd for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:13:17 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 429376b6-34fa-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 10:13:16 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 90B414EE0737; Mon, 7 Aug 2023 10:13:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 429376b6-34fa-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Mon, 07 Aug 2023 10:13:15 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 In-Reply-To: References: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <4c5b5091ecae8b1314ba67825f4a959d@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 03/08/2023 11:17, Jan Beulich wrote: > On 02.08.2023 16:38, Nicola Vetrini wrote: >> --- a/xen/common/sched/core.c >> +++ b/xen/common/sched/core.c >> @@ -2233,6 +2233,7 @@ static bool sched_tasklet_check_cpu(unsigned int >> cpu) >> /* fallthrough */ >> case TASKLET_enqueued|TASKLET_scheduled: >> return true; >> + ASSERT_UNREACHABLE(); >> break; > > What use is "break" after "return"? IOW rather than adding code here, > imo a line wants removing. > > Jan The "return false" after the switch would still be unreachable. The reasoning behind preserving the break is mainly MISRA Rule 16.3: "An unconditional break statement shall terminate every switch-clause", which has not yet been considered for adoption, but might be in future discussions, leading to putting back the break here. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)