Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E7FDC3064D for ; Thu, 27 Jun 2024 10:10:51 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.749933.1158182 (Exim 4.92) (envelope-from ) id 1sMm5O-0004yN-Ix; Thu, 27 Jun 2024 10:10:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 749933.1158182; Thu, 27 Jun 2024 10:10:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sMm5O-0004yG-GA; Thu, 27 Jun 2024 10:10:38 +0000 Received: by outflank-mailman (input) for mailman id 749933; Thu, 27 Jun 2024 10:10:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sMm5N-0004yA-Io for xen-devel@lists.xenproject.org; Thu, 27 Jun 2024 10:10:37 +0000 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [2a00:1450:4864:20::22a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e218ead-346d-11ef-b4bb-af5377834399; Thu, 27 Jun 2024 12:10:34 +0200 (CEST) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2eabd22d3f4so93313551fa.1 for ; Thu, 27 Jun 2024 03:10:34 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-706b4a34ac8sm949363b3a.153.2024.06.27.03.10.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jun 2024 03:10:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e218ead-346d-11ef-b4bb-af5377834399 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719483034; x=1720087834; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=tMmvT783v1oTSfDdKa+kUqkIMUD5NzRUYvt6Z4n+ZCk=; b=SsUckkYghS2vCV8+ZZbVeTad5fycoCx9U7b+ls+Bt7iaqaVFkWluRp38sYfmvolycG BJyQqdyzgBAYP0+ytG8fX0UI6LhWHJieZUh3r+CmWgTOXLCTB3KuAIHXa4LdiQTlNj/S PnAqjinJZZWq2MiY/PNL/Fj7fRB4aWNHEIbJQ7V4ZL4jKQIC/aT/xHYKo/dyH1DoQ/n9 fneFVcMW4Dw7vkSSa8CMHMEp41uhg+LURuaDB2Hf8gzl4GgqA0kmAcGCsQ2qMz7Ujd6p fCvtsQE3ls+nZLBhFPjoQ+hWt0Ll0OC93I2Mqkdz1C1Fdy2rWZaV3yw9XlyaBfB+qs96 UjJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719483034; x=1720087834; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tMmvT783v1oTSfDdKa+kUqkIMUD5NzRUYvt6Z4n+ZCk=; b=t8IlwdGEwH1fwf7TRA1ht6cKMODF6CE/kNLXUIKAaE6c9bPk5PbZ5nL0ylRVb20Z0A LKPaBbbiecrObKa7tF82uMkXJm3up8+3XiUVFFYXaT6NxMBelszbo8xovJ2qcQOD+iQ+ DBGe9ungzqCfi1iGz00XLr68zUWbTdDbqqX06fVFaQpfbNFmJYgb3aDCoONxGE2XogSB dWBqWhMxcV3wHmEGks5bOxWSse1g+qO6fzubDoHd6mIMIkUNakuyFbf35nv8BEDoIy4b lH9Zz3uhYfF+dBdMjIA8s/HFqucZ4zUoiyIzCB7KzjSSZVXNXsawMPJkSqgb2qI5ZWr4 KOmw== X-Forwarded-Encrypted: i=1; AJvYcCUUlqd6YmT8kkMJJmS9oORxzWE/AUVP5RldY1bzPKqyctGI33YDFawtcSc9tAFW35EKfKFbVyta8sghN5R15rcTOUONo4nTPcqiEyvZLFY= X-Gm-Message-State: AOJu0YxxNV++D2w/KXlZMy/59ZkOyPomVo+z/MpIMgEcC8Zj3Sh7oCes EcoxxZ5ZH8WWRAD+CDceS1hmba01C2EL5INPRpTmkYvQxSCUUOW9kIKkVIdcrw== X-Google-Smtp-Source: AGHT+IGvQWZIPzYtI1WHh4GTDUt72Xq6p9ikYRp+O0F3iw5zHL49cfNh5YMRvexu/vBcw3zMAAlf7g== X-Received: by 2002:a2e:9d86:0:b0:2ec:5a0d:b2dd with SMTP id 38308e7fff4ca-2ec5b2f0373mr78048391fa.39.1719483033844; Thu, 27 Jun 2024 03:10:33 -0700 (PDT) Message-ID: <4c71db0d-60a4-4347-b706-a2e06fc9cd63@suse.com> Date: Thu, 27 Jun 2024 12:10:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 02/10] xen/riscv: introduce bitops.h To: oleksii.kurochko@gmail.com Cc: Alistair Francis , Bob Eshleman , Connor Davis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <0e4441eee82b0545e59099e2f62e3a01fa198d08.1719319093.git.oleksii.kurochko@gmail.com> <4c15dd072f08b1161d170608a096dc0851ced588.camel@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27.06.2024 11:58, oleksii.kurochko@gmail.com wrote: > On Thu, 2024-06-27 at 09:59 +0200, Jan Beulich wrote: >> On 26.06.2024 19:27, oleksii.kurochko@gmail.com wrote: >>> On Wed, 2024-06-26 at 10:31 +0200, Jan Beulich wrote: >>>> On 25.06.2024 15:51, Oleksii Kurochko wrote: >>>>> --- /dev/null >>>>> +++ b/xen/arch/riscv/include/asm/bitops.h >>>>> @@ -0,0 +1,137 @@ >>>>> +/* SPDX-License-Identifier: GPL-2.0 */ >>>>> +/* Copyright (C) 2012 Regents of the University of California >>>>> */ >>>>> + >>>>> +#ifndef _ASM_RISCV_BITOPS_H >>>>> +#define _ASM_RISCV_BITOPS_H >>>>> + >>>>> +#include >>>>> + >>>>> +#if BITOP_BITS_PER_WORD == 64 >>>>> +#define __AMO(op)   "amo" #op ".d" >>>>> +#elif BITOP_BITS_PER_WORD == 32 >>>>> +#define __AMO(op)   "amo" #op ".w" >>>>> +#else >>>>> +#error "Unexpected BITOP_BITS_PER_WORD" >>>>> +#endif >>>>> + >>>>> +/* Based on linux/arch/include/asm/bitops.h */ >>>>> + >>>>> +/* >>>>> + * Non-atomic bit manipulation. >>>>> + * >>>>> + * Implemented using atomics to be interrupt safe. Could >>>>> alternatively >>>>> + * implement with local interrupt masking. >>>>> + */ >>>>> +#define __set_bit(n, p)      set_bit(n, p) >>>>> +#define __clear_bit(n, p)    clear_bit(n, p) >>>>> + >>>>> +#define test_and_op_bit_ord(op, mod, nr, addr, ord)     \ >>>>> +({                                                      \ >>>>> +    bitop_uint_t res, mask;                             \ >>>>> +    mask = BITOP_MASK(nr);                              \ >>>>> +    asm volatile (                                      \ >>>>> +        __AMO(op) #ord " %0, %2, %1"                    \ >>>>> +        : "=r" (res), "+A" (addr[BITOP_WORD(nr)])       \ >>>>> +        : "r" (mod(mask))                               \ >>>>> +        : "memory");                                    \ >>>>> +    ((res & mask) != 0);                                \ >>>>> +}) >>>>> + >>>>> +#define op_bit_ord(op, mod, nr, addr, ord)      \ >>>>> +    asm volatile (                              \ >>>>> +        __AMO(op) #ord " zero, %1, %0"          \ >>>>> +        : "+A" (addr[BITOP_WORD(nr)])           \ >>>>> +        : "r" (mod(BITOP_MASK(nr)))             \ >>>>> +        : "memory"); >>>>> + >>>>> +#define test_and_op_bit(op, mod, nr, addr)    \ >>>>> +    test_and_op_bit_ord(op, mod, nr, addr, .aqrl) >>>>> +#define op_bit(op, mod, nr, addr) \ >>>>> +    op_bit_ord(op, mod, nr, addr, ) >>>>> + >>>>> +/* Bitmask modifiers */ >>>>> +#define NOP(x)    (x) >>>>> +#define NOT(x)    (~(x)) >>>> >>>> Since elsewhere you said we would use Zbb in bitops, I wanted to >>>> come >>>> back >>>> on that: Up to here all we use is AMO. >>>> >>>> And further down there's no asm() anymore. What were you >>>> referring >>>> to? >>> RISC-V doesn't have a CLZ instruction in the base >>> ISA.  As a consequence, __builtin_ffs() emits a library call to >>> ffs() >>> on GCC, >> >> Oh, so we'd need to implement that libgcc function, along the lines >> of >> Arm32 implementing quite a few of them to support shifts on 64-bit >> quantities as well as division and modulo. > Why we can't just live with Zbb extension? Zbb extension is presented > on every platform I have in access with hypervisor extension support. I'd be fine that way, but then you don't need to break up ANDN into NOT and AND. It is my understanding that Andrew has concerns here, even if - iirc - it was him to originally suggest to build upon that extension being available. If these concerns are solely about being able to build with Zbb-unaware tool chains, then what to do about the build issues there has already been said. Jan