References: <20190815155319.28249-1-gert@...1296...> From: Antonio Quartulli Message-ID: <4c9003a0-4e97-9b49-84f4-7e50c158efa8@...2181...> Date: Thu, 15 Aug 2019 22:21:37 +0200 MIME-Version: 1.0 In-Reply-To: <20190815155319.28249-1-gert@...1296...> Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH] Increase listen() backlog queue to 32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Gert Doering , openvpn-devel@lists.sourceforge.net Hi, On 15/08/2019 17:53, Gert Doering wrote: > For reasons historically unknown, OpenVPN sets the listen() backlog > queue to "1", which signals the kernel "while there is one TCP connect > waiting for OpenVPN to handle it, refuse all others" - which, on > restarting a busy TCP server, will create connection issues. > > The exact "best" value of the backlog queue is subject of discussion, > but for a server that is not extremely busy with many connections > coming in in parallel, there is no real difference between "10" or "500", > as long as it's "more than 1". > > Found and debugged by "mjo" in Trac. > > Trac: #1208 > > Signed-off-by: Gert Doering Having 1 is definitely unreasonable, and we need something larger. On top of that, mjo explained what kind of other side effects we can have when setting the queue to such a small value. 32 is reasonable and may even be worth a define so that it can be easily tweaked by whoever wants to. But this is another story.. Acked-by: Antonio Quartulli > --- > src/openvpn/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c > index c472cf1b..983ed38a 100644 > --- a/src/openvpn/socket.c > +++ b/src/openvpn/socket.c > @@ -1175,7 +1175,7 @@ socket_do_listen(socket_descriptor_t sd, > ASSERT(local); > msg(M_INFO, "Listening for incoming TCP connection on %s", > print_sockaddr(local->ai_addr, &gc)); > - if (listen(sd, 1)) > + if (listen(sd, 32)) > { > msg(M_ERR, "TCP: listen() failed"); > } > -- Antonio Quartulli