Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A63FC433FE for ; Mon, 11 Apr 2022 10:18:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345236AbiDKKUh (ORCPT ); Mon, 11 Apr 2022 06:20:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243967AbiDKKUg (ORCPT ); Mon, 11 Apr 2022 06:20:36 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D84F140EA; Mon, 11 Apr 2022 03:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649672303; x=1681208303; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=LY4Gan0r5kw9t3GlqJt4eD6qrLYfZP2GM/pr+9L1rLg=; b=hxGANOG2VrsSl6/48zF7UxmSyjZkdakGkUwYLziFSMj6WmUl3BGB1CWV 4HQUpSF9eSo2SoutGCcE2uUGYE4NaGAaxhL8pZ+NVAEygP9q4VP2vAvlI zFLMG1/bLxkeRbzU2htF3GCeDZxsEyZQVWm3b4tXGnWf6Dx7nJzTQ2LXc Mq1x3PehxUqp1Olk/iHdd4EyOUGOmhQn8/T1NskKSyUapzATm2AT9Tk0v 1bouWwOFkiI/5F7s4G/+/bpw4eU7GeT7Kbvg2ZpJfClJE8rCxcM4Jd/yv lvG2DiOlFI2FzAlRzgCTz6+dQ8xLkqXKbnjaiBw2YHcecM2rEyIFb5adu Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="259677790" X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="259677790" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 03:18:23 -0700 X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="572061872" Received: from azahoner-mobl1.ger.corp.intel.com ([10.249.44.232]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 03:18:16 -0700 Date: Mon, 11 Apr 2022 13:18:10 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Ricardo Martinez cc: Netdev , linux-wireless@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, m.chetan.kumar@intel.com, chandrashekar.devegowda@intel.com, linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com, amir.hanania@intel.com, Andy Shevchenko , dinesh.sharma@intel.com, eliot.lee@intel.com, moises.veleta@intel.com, pierre-louis.bossart@intel.com, muralidharan.sethuraman@intel.com, Soumya.Prakash.Mishra@intel.com, sreehari.kancharla@intel.com, madhusmita.sahu@intel.com Subject: Re: [PATCH net-next v6 03/13] net: wwan: t7xx: Add core components In-Reply-To: <20220407223629.21487-4-ricardo.martinez@linux.intel.com> Message-ID: <4cb460be-24cd-8b12-90a3-b7bbc214329d@linux.intel.com> References: <20220407223629.21487-1-ricardo.martinez@linux.intel.com> <20220407223629.21487-4-ricardo.martinez@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1635724389-1649672302=:1916" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1635724389-1649672302=:1916 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Thu, 7 Apr 2022, Ricardo Martinez wrote: > From: Haijun Liu > > Registers the t7xx device driver with the kernel. Setup all the core > components: PCIe layer, Modem Host Cross Core Interface (MHCCIF), > modem control operations, modem state machine, and build > infrastructure. > > * PCIe layer code implements driver probe and removal. > * MHCCIF provides interrupt channels to communicate events > such as handshake, PM and port enumeration. > * Modem control implements the entry point for modem init, > reset and exit. > * The modem status monitor is a state machine used by modem control > to complete initialization and stop. It is used also to propagate > exception events reported by other components. > > Signed-off-by: Haijun Liu > Signed-off-by: Chandrashekar Devegowda > Co-developed-by: Ricardo Martinez > Signed-off-by: Ricardo Martinez > > >From a WWAN framework perspective: > Reviewed-by: Loic Poulain Looks good. Reviewed-by: Ilpo Järvinen -- i. --8323329-1635724389-1649672302=:1916--