Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6FB0C433E0 for ; Fri, 15 Jan 2021 09:09:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52AA2233EE for ; Fri, 15 Jan 2021 09:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52AA2233EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94D6E89E7B; Fri, 15 Jan 2021 09:09:56 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 142228919E for ; Fri, 15 Jan 2021 09:09:55 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A16F0AA6F; Fri, 15 Jan 2021 09:09:53 +0000 (UTC) Subject: Re: [PATCH] drm/hisilicon/hibmc: Remove hibmc_ttm.c To: "tiantao (H)" , tiantao6@hisilicon.com References: <20210113113107.12005-1-tzimmermann@suse.de> <7c5611ac-772e-6529-6072-e192d05c916d@suse.de> <9f3b2b83-5d8f-106b-1e5f-a799f0805c3e@huawei.com> From: Thomas Zimmermann Message-ID: <4d07a90f-1389-2ed4-bb22-b9d792bb4c33@suse.de> Date: Fri, 15 Jan 2021 10:09:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <9f3b2b83-5d8f-106b-1e5f-a799f0805c3e@huawei.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xinliang Liu , Chen Feng , dri-devel@lists.freedesktop.org, Gong junjie , Xinwei Kong , Daniel Vetter , Sam Ravnborg Content-Type: multipart/mixed; boundary="===============0124557851==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0124557851== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="37E9fe0NuiYw6cxYHSlcx6OKa4vzKpN9h" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --37E9fe0NuiYw6cxYHSlcx6OKa4vzKpN9h Content-Type: multipart/mixed; boundary="sBc5NX4B4OnPrFNKUrqRQDyUqZuzpDqp1"; protected-headers="v1" From: Thomas Zimmermann To: "tiantao (H)" , tiantao6@hisilicon.com Cc: dri-devel@lists.freedesktop.org, Sam Ravnborg , Xinliang Liu , John Stultz , Xinwei Kong , Chen Feng , Daniel Vetter , Gong junjie Message-ID: <4d07a90f-1389-2ed4-bb22-b9d792bb4c33@suse.de> Subject: Re: [PATCH] drm/hisilicon/hibmc: Remove hibmc_ttm.c References: <20210113113107.12005-1-tzimmermann@suse.de> <7c5611ac-772e-6529-6072-e192d05c916d@suse.de> <9f3b2b83-5d8f-106b-1e5f-a799f0805c3e@huawei.com> In-Reply-To: <9f3b2b83-5d8f-106b-1e5f-a799f0805c3e@huawei.com> --sBc5NX4B4OnPrFNKUrqRQDyUqZuzpDqp1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 15.01.21 um 09:50 schrieb tiantao (H): >=20 > =E5=9C=A8 2021/1/15 16:42, Thomas Zimmermann =E5=86=99=E9=81=93: >> ping for review >> >> Am 13.01.21 um 12:31 schrieb Thomas Zimmermann: >>> The file is not in use. It got re-added by a rebased patch. Removing >>> it. >>> > Reviewed-by Tian Tao Thanks a lot. Pushed to -misc-next. Best regards Thomas >>> Signed-off-by: Thomas Zimmermann >>> Fixes: 4d4dad21cc7b ("drm/hibmc: Remove references to struct=20 >>> drm_device.pdev") >>> Reported-by: Tian Tao >>> Cc: Sam Ravnborg >>> Cc: Xinliang Liu >>> Cc: Tian Tao=C2=A0 >>> Cc: John Stultz >>> Cc: Xinwei Kong >>> Cc: Chen Feng >>> Cc: Daniel Vetter >>> Cc: Gong junjie >>> --- >>> =C2=A0 drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 61 -------------= -------- >>> =C2=A0 1 file changed, 61 deletions(-) >>> =C2=A0 delete mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c= >>> >>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c=20 >>> b/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c >>> deleted file mode 100644 >>> index 77f075075db2..000000000000 >>> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c >>> +++ /dev/null >>> @@ -1,61 +0,0 @@ >>> -// SPDX-License-Identifier: GPL-2.0-or-later >>> -/* Hisilicon Hibmc SoC drm driver >>> - * >>> - * Based on the bochs drm driver. >>> - * >>> - * Copyright (c) 2016 Huawei Limited. >>> - * >>> - * Author: >>> - *=C2=A0=C2=A0=C2=A0 Rongrong Zou >>> - *=C2=A0=C2=A0=C2=A0 Rongrong Zou >>> - *=C2=A0=C2=A0=C2=A0 Jianhua Li >>> - */ >>> - >>> -#include >>> - >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include >>> - >>> -#include "hibmc_drm_drv.h" >>> - >>> -int hibmc_mm_init(struct hibmc_drm_private *hibmc) >>> -{ >>> -=C2=A0=C2=A0=C2=A0 struct drm_vram_mm *vmm; >>> -=C2=A0=C2=A0=C2=A0 int ret; >>> -=C2=A0=C2=A0=C2=A0 struct drm_device *dev =3D hibmc->dev; >>> -=C2=A0=C2=A0=C2=A0 struct pci_dev *pdev =3D to_pci_dev(dev->dev); >>> - >>> -=C2=A0=C2=A0=C2=A0 vmm =3D drm_vram_helper_alloc_mm(dev, pci_resourc= e_start(pdev, 0), >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hibmc->fb= _size); >>> -=C2=A0=C2=A0=C2=A0 if (IS_ERR(vmm)) { >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D PTR_ERR(vmm); >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 drm_err(dev, "Error initi= alizing VRAM MM; %d\n", ret); >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return ret; >>> -=C2=A0=C2=A0=C2=A0 } >>> - >>> -=C2=A0=C2=A0=C2=A0 return 0; >>> -} >>> - >>> -void hibmc_mm_fini(struct hibmc_drm_private *hibmc) >>> -{ >>> -=C2=A0=C2=A0=C2=A0 if (!hibmc->dev->vram_mm) >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return; >>> - >>> -=C2=A0=C2=A0=C2=A0 drm_vram_helper_release_mm(hibmc->dev); >>> -} >>> - >>> -int hibmc_dumb_create(struct drm_file *file, struct drm_device *dev,= >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 struct drm_mode_create_dumb *args) >>> -{ >>> -=C2=A0=C2=A0=C2=A0 return drm_gem_vram_fill_create_dumb(file, dev, 0= , 128, args); >>> -} >>> - >>> -const struct drm_mode_config_funcs hibmc_mode_funcs =3D { >>> -=C2=A0=C2=A0=C2=A0 .mode_valid =3D drm_vram_helper_mode_valid, >>> -=C2=A0=C2=A0=C2=A0 .atomic_check =3D drm_atomic_helper_check, >>> -=C2=A0=C2=A0=C2=A0 .atomic_commit =3D drm_atomic_helper_commit, >>> -=C2=A0=C2=A0=C2=A0 .fb_create =3D drm_gem_fb_create, >>> -}; >>> >> >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --sBc5NX4B4OnPrFNKUrqRQDyUqZuzpDqp1-- --37E9fe0NuiYw6cxYHSlcx6OKa4vzKpN9h Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmABW98FAwAAAAAACgkQlh/E3EQov+D4 pA//WzWflDs+6yh1V/1DNGnU/O66O0ZdfMT3GlyvNUNe6fSwCzft9zc/+MST8FdHQdEr/BjVbPei F1Wqk+UwKSuuEOtaaUUUqsr37tFm6FXMhqGFaDa9ZWy1FoW7Jgv5MCWn6lNkVPr6P7w6jsZnKlX3 boMkh1mUHxKCtwFL6TAIsuoaKqWwcV3nw8mXRhO35IuEolGNTklzx2Uw2caPWcLrO5Z4cj3VWkPg FcaGNn0jK/nIpsFTghahFx8O+MyEkrGc7A1V5Ic0JdCcG0XLsKUD3faYN6vCcH4afdaCBH+I8Lrp ALS+b7xpMWN+75II3BaM1AEuv0siC9UEIYkSsnSBjk1CDqbtA1X0rhF5hTfQVCS5gHjZnaQ+CPyV eJMmmQLaIP0RUU2c1UfWI3QGyjHBNuXfCrW+xETbtAzsEmC69TAbcVa+7+8pCP9DTCqz5lyuFTCE SRd8hcjXs/D23sMPRxJ2q1smOy+jryXsKocF7CFWwlnhTqbXiXWf38J76/dYg4fq5Md5ktNmGgP6 Wn++1ghGIaJ6pxNBE9GnyI7BFwCt8FcRg45sfSIIQ4hj8ECLeqgVvnnt30s51a6Ttg14oVcXUiRj DGDl5Rf3zF7ihgEGPZGxB4t+PimhNLE0ls7FGX67TTYi7GtIPut9vsq6NBGLslpLyTykyc8m6HYh SCM= =hmH0 -----END PGP SIGNATURE----- --37E9fe0NuiYw6cxYHSlcx6OKa4vzKpN9h-- --===============0124557851== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0124557851==--