Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 38E4760197 for ; Wed, 17 Jul 2019 06:51:55 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id x6H6ptXO025382 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 16 Jul 2019 23:51:55 -0700 (PDT) Received: from [128.224.162.179] (128.224.162.179) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.468.0; Tue, 16 Jul 2019 23:51:54 -0700 To: Khem Raj References: <20190715102016.114264-1-kai.kang@windriver.com> <0f664af2-cea3-aaa2-2a7c-74c43d58ced4@windriver.com> <8164ebb7-8a4f-a7ce-74de-e4adb60a6022@windriver.com> From: Kang Kai Message-ID: <4d14f4a4-c3a2-ed2d-e8dc-fd6de1963124@windriver.com> Date: Wed, 17 Jul 2019 14:51:23 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH] webkitgtk: set incomptible with tune mips X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jul 2019 06:51:56 -0000 Content-Type: multipart/alternative; boundary="------------8C62849134C616616B5426E2" Content-Language: en-US --------------8C62849134C616616B5426E2 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 2019/7/17 下午2:20, Khem Raj wrote: > Right so we should only disable the tunes which don’t have clz and not > all mips as this patch is doing The patch only set COMPATILE_HOST to null  only when default tune is 'mips' which causes webkitgtk fails. And for other conditions, it doesn't block to build that the COMPATILE_HOST is 'mips.*-linux'. Such as the default bsps qemumips(default tune mips32r2) and qemumips64(mips64r2), it doesn't affect them. Kai > > On Tue, Jul 16, 2019 at 10:42 PM Kang Kai > wrote: > > On 2019/7/16 下午11:33, Khem Raj wrote: >> >> >> On Tue, Jul 16, 2019 at 2:33 AM Kang Kai > > wrote: >> >> On 2019/7/16 下午3:19, Khem Raj wrote: >> > On Mon, Jul 15, 2019 at 3:21 AM > > wrote: >> >> From: Kai Kang > > >> >> >> >> It fails to compile webkit when default tune is 'mips': >> >> >> >> | >> .../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2 >> >> | >> /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23: >> >> | error: static assertion failed: CLZ opcode is not >> available for this ISA >> >> >> >> So don't build webkit when default tune is mips. >> >> >> >> Signed-off-by: Kai Kang > > >> >> --- >> >>   meta/recipes-sato/webkit/webkitgtk_2.24.2.bb >> | 2 ++ >> >>   1 file changed, 2 insertions(+) >> >> >> >> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb >> >> b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb >> >> >> index 056334fff5..891266b220 100644 >> >> --- a/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb >> >> >> +++ b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb >> >> >> @@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 >> cairo libxslt libxt libidn libgcrypt \ >> >>             gettext-native glib-2.0 glib-2.0-native libtasn1 \ >> >>             " >> >> >> >> +COMPATIBLE_HOST_mipsarch = >> "${@bb.utils.contains('DEFAULTTUNE', 'mips', 'null', >> 'mips.*-linux', d)}" >> >> >> + >> > this disables is for all kind of mips. I think thats a >> broad set, it >> > would be best to narrow it to what you saw it failing for >> > e.g. it should work for mips32 and mips64 so maybe mips1 is >> what you >> > want to disable for >> >> I tested with qemumips and qemumips64. When set >> >> DEFAULTTUNE= "mips" >> >> >> How about using mips32 and mips64 for default tune and retest > > > It build webkitgtk successfully on qemumips and qemumips64 with > default tune mips32 and mips64. > > >> >> >> It fails with the error. >> >> Regards, >> Kai >> >> > >> > >> >>   PACKAGECONFIG ??= >> "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', >> 'wayland' ,d)} \ >> >> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'webgl >> opengl', '' ,d)} \ >> >>                      enchant \ >> >> -- >> >> 2.20.0 >> >> >> >> -- >> >> _______________________________________________ >> >> Openembedded-core mailing list >> >> Openembedded-core@lists.openembedded.org >> >> >> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> >> >> -- >> Kai Kang >> > > -- > Kai Kang > -- Kai Kang --------------8C62849134C616616B5426E2 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
On 2019/7/17 下午2:20, Khem Raj wrote:
Right so we should only disable the tunes which don’t have clz and not all mips as this patch is doing

The patch only set COMPATILE_HOST to null  only when default tune is 'mips' which causes webkitgtk fails.
And for other conditions, it doesn't block to build that the COMPATILE_HOST is 'mips.*-linux'.  Such as the
default bsps qemumips(default tune mips32r2) and qemumips64(mips64r2), it doesn't affect them.

Kai



On Tue, Jul 16, 2019 at 10:42 PM Kang Kai <Kai.Kang@windriver.com> wrote:
On 2019/7/16 下午11:33, Khem Raj wrote:


On Tue, Jul 16, 2019 at 2:33 AM Kang Kai <Kai.Kang@windriver.com> wrote:
On 2019/7/16 下午3:19, Khem Raj wrote:
> On Mon, Jul 15, 2019 at 3:21 AM <kai.kang@windriver.com> wrote:
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> It fails to compile webkit when default tune is 'mips':
>>
>> | .../tmp-glibc/work/mips-wrs-linux/webkitgtk/2.24.2-r0/webkitgtk-2.24.2
>> | /Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:418:23:
>> | error: static assertion failed: CLZ opcode is not available for this ISA
>>
>> So don't build webkit when default tune is mips.
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>>   meta/recipes-sato/webkit/webkitgtk_2.24.2.bb | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
>> index 056334fff5..891266b220 100644
>> --- a/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
>> +++ b/meta/recipes-sato/webkit/webkitgtk_2.24.2.bb
>> @@ -43,6 +43,8 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
>>             gettext-native glib-2.0 glib-2.0-native libtasn1 \
>>             "
>>
>> +COMPATIBLE_HOST_mipsarch = "${@bb.utils.contains('DEFAULTTUNE', 'mips', 'null', 'mips.*-linux', d)}"
>> +
> this disables is for all kind of mips. I think thats a broad set, it
> would be best to narrow it to what you saw it failing for
> e.g. it should work for mips32 and mips64 so maybe mips1 is what you
> want to disable for

I tested with qemumips and qemumips64. When set

DEFAULTTUNE= "mips"

How about using mips32 and mips64 for default tune and retest


It build webkitgtk successfully on qemumips and qemumips64 with default tune mips32 and mips64.




It fails with the error.

Regards,
Kai

>
>
>>   PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 'wayland' ,d)} \
>>                      ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'webgl opengl', '' ,d)} \
>>                      enchant \
>> --
>> 2.20.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


--
Kai Kang


-- 
Kai Kang


-- 
Kai Kang
--------------8C62849134C616616B5426E2--