From: "Grodzovsky, Andrey" Subject: Re: [PATCH] drm: Don't free jobs in wait_event_interruptible() Date: Thu, 26 Sep 2019 14:58:42 +0000 Message-ID: <4d4aa96f-ff2a-681a-6892-b75e2b5bf86a@amd.com> References: <20190925151404.23222-1-steven.price@arm.com> <321e99c1-4ce8-e6e1-83c8-2df1c78acce3@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-eopbgr780072.outbound.protection.outlook.com [40.107.78.72]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E3AC6ECCB for ; Thu, 26 Sep 2019 14:58:44 +0000 (UTC) In-Reply-To: <321e99c1-4ce8-e6e1-83c8-2df1c78acce3@amd.com> Content-Language: en-US Content-ID: <24AABCAB6501394AB808BD54C69D7CF0@namprd12.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Koenig, Christian" , Steven Price , Daniel Vetter , David Airlie Cc: "Deucher, Alexander" , Nayan Deshmukh , Sharat Masetty , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org DQpPbiA5LzI2LzE5IDM6MDcgQU0sIEtvZW5pZywgQ2hyaXN0aWFuIHdyb3RlOg0KPiBBbSAyNS4w OS4xOSB1bSAxNzoxNCBzY2hyaWViIFN0ZXZlbiBQcmljZToNCj4+IGRybV9zY2hlZF9jbGVhbnVw X2pvYnMoKSBhdHRlbXB0cyB0byBmcmVlIGZpbmlzaGVkIGpvYnMsIGhvd2V2ZXIgYmVjYXVzZQ0K Pj4gaXQgaXMgY2FsbGVkIGFzIHRoZSBjb25kaXRpb24gb2Ygd2FpdF9ldmVudF9pbnRlcnJ1cHRp YmxlKCkgaXQgbXVzdCBub3QNCj4+IHNsZWVwLiBVbmZvcnR1bmF0ZWx5IHNvbWUgZnJlZSBjYWxs YmFja3MgKG5vdGFibHkgZm9yIFBhbmZyb3N0KSBkbyBzbGVlcC4NCj4+DQo+PiBJbnN0ZWFkIGxl dCdzIHJlbmFtZSBkcm1fc2NoZWRfY2xlYW51cF9qb2JzKCkgdG8NCj4+IGRybV9zY2hlZF9nZXRf Y2xlYW51cF9qb2IoKSBhbmQgc2ltcGx5IHJldHVybiBhIGpvYiBmb3IgcHJvY2Vzc2luZyBpZg0K Pj4gdGhlcmUgaXMgb25lLiBUaGUgY2FsbGVyIGNhbiB0aGVuIGNhbGwgdGhlIGZyZWVfam9iKCkg Y2FsbGJhY2sgb3V0c2lkZQ0KPj4gdGhlIHdhaXRfZXZlbnRfaW50ZXJydXB0aWJsZSgpIHdoZXJl IHNsZWVwaW5nIGlzIHBvc3NpYmxlIGJlZm9yZQ0KPj4gcmUtY2hlY2tpbmcgYW5kIHJldHVybmlu ZyB0byBzbGVlcCBpZiBuZWNlc3NhcnkuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogU3RldmVuIFBy aWNlIDxzdGV2ZW4ucHJpY2VAYXJtLmNvbT4NCj4+IC0tLQ0KPj4gICAgZHJpdmVycy9ncHUvZHJt L3NjaGVkdWxlci9zY2hlZF9tYWluLmMgfCA0NCArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQ0K Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQ0K Pj4NCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVkX21haW4u YyBiL2RyaXZlcnMvZ3B1L2RybS9zY2hlZHVsZXIvc2NoZWRfbWFpbi5jDQo+PiBpbmRleCA5YTBl ZTc0ZDgyZGMuLjBlZDRhYWE0ZTZkMSAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9z Y2hlZHVsZXIvc2NoZWRfbWFpbi5jDQo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVy L3NjaGVkX21haW4uYw0KPj4gQEAgLTYyMiw0MyArNjIyLDQxIEBAIHN0YXRpYyB2b2lkIGRybV9z Y2hlZF9wcm9jZXNzX2pvYihzdHJ1Y3QgZG1hX2ZlbmNlICpmLCBzdHJ1Y3QgZG1hX2ZlbmNlX2Ni ICpjYikNCj4+ICAgIH0NCj4+ICAgIA0KPj4gICAgLyoqDQo+PiAtICogZHJtX3NjaGVkX2NsZWFu dXBfam9icyAtIGRlc3Ryb3kgZmluaXNoZWQgam9icw0KPj4gKyAqIGRybV9zY2hlZF9nZXRfY2xl YW51cF9qb2IgLSBmZXRjaCB0aGUgbmV4dCBmaW5pc2hlZCBqb2IgdG8gYmUgZGVzdHJveWVkDQo+ PiAgICAgKg0KPj4gICAgICogQHNjaGVkOiBzY2hlZHVsZXIgaW5zdGFuY2UNCj4+ICAgICAqDQo+ PiAtICogUmVtb3ZlIGFsbCBmaW5pc2hlZCBqb2JzIGZyb20gdGhlIG1pcnJvciBsaXN0IGFuZCBk ZXN0cm95IHRoZW0uDQo+PiArICogUmV0dXJucyB0aGUgbmV4dCBmaW5pc2hlZCBqb2IgZnJvbSB0 aGUgbWlycm9yIGxpc3QgKGlmIHRoZXJlIGlzIG9uZSkNCj4+ICsgKiByZWFkeSBmb3IgaXQgdG8g YmUgZGVzdHJveWVkLg0KPj4gICAgICovDQo+PiAtc3RhdGljIHZvaWQgZHJtX3NjaGVkX2NsZWFu dXBfam9icyhzdHJ1Y3QgZHJtX2dwdV9zY2hlZHVsZXIgKnNjaGVkKQ0KPj4gK3N0YXRpYyBzdHJ1 Y3QgZHJtX3NjaGVkX2pvYiAqDQo+PiArZHJtX3NjaGVkX2dldF9jbGVhbnVwX2pvYihzdHJ1Y3Qg ZHJtX2dwdV9zY2hlZHVsZXIgKnNjaGVkKQ0KPj4gICAgew0KPj4gKwlzdHJ1Y3QgZHJtX3NjaGVk X2pvYiAqam9iID0gTlVMTDsNCj4+ICAgIAl1bnNpZ25lZCBsb25nIGZsYWdzOw0KPj4gICAgDQo+ PiAgICAJLyogRG9uJ3QgZGVzdHJveSBqb2JzIHdoaWxlIHRoZSB0aW1lb3V0IHdvcmtlciBpcyBy dW5uaW5nICovDQo+PiAgICAJaWYgKHNjaGVkLT50aW1lb3V0ICE9IE1BWF9TQ0hFRFVMRV9USU1F T1VUICYmDQo+PiAgICAJICAgICFjYW5jZWxfZGVsYXllZF93b3JrKCZzY2hlZC0+d29ya190ZHIp KQ0KPj4gLQkJcmV0dXJuOw0KPj4gLQ0KPj4gLQ0KPj4gLQl3aGlsZSAoIWxpc3RfZW1wdHkoJnNj aGVkLT5yaW5nX21pcnJvcl9saXN0KSkgew0KPj4gLQkJc3RydWN0IGRybV9zY2hlZF9qb2IgKmpv YjsNCj4+ICsJCXJldHVybiBOVUxMOw0KPj4gICAgDQo+PiAtCQlqb2IgPSBsaXN0X2ZpcnN0X2Vu dHJ5KCZzY2hlZC0+cmluZ19taXJyb3JfbGlzdCwNCj4+ICsJam9iID0gbGlzdF9maXJzdF9lbnRy eV9vcl9udWxsKCZzY2hlZC0+cmluZ19taXJyb3JfbGlzdCwNCj4+ICAgIAkJCQkgICAgICAgc3Ry dWN0IGRybV9zY2hlZF9qb2IsIG5vZGUpOw0KPiBUaGlzIGlzIHByb2JhYmx5IGJldHRlciBkb25l IGFmdGVyIHRha2luZyB0aGUgbG9jaywgYXBhcnQgZnJvbSB0aGF0DQo+IGxvb2tzIGdvb2QgdG8g bWUuDQo+DQo+IENocmlzdGlhbi4NCg0KDQpXaHkgaXMgaXQgbmVjZXNzYXJ5IGlmIGluc2VydGlv biBhbmQgcmVtb3ZhbCBmcm9tIHRoZSByaW5nX21pcnJvcl9saXN0IA0KYXJlIG9ubHkgZG9uZSBm cm9tIHRoZSBzYW1lIHNjaGVkdWxlciB0aHJlYWQgPw0KDQpBbmRyZXkNCg0KDQo+DQo+PiAtCQlp ZiAoIWRtYV9mZW5jZV9pc19zaWduYWxlZCgmam9iLT5zX2ZlbmNlLT5maW5pc2hlZCkpDQo+PiAt CQkJYnJlYWs7DQo+PiAgICANCj4+IC0JCXNwaW5fbG9ja19pcnFzYXZlKCZzY2hlZC0+am9iX2xp c3RfbG9jaywgZmxhZ3MpOw0KPj4gKwlzcGluX2xvY2tfaXJxc2F2ZSgmc2NoZWQtPmpvYl9saXN0 X2xvY2ssIGZsYWdzKTsNCj4+ICsNCj4+ICsJaWYgKGpvYiAmJiBkbWFfZmVuY2VfaXNfc2lnbmFs ZWQoJmpvYi0+c19mZW5jZS0+ZmluaXNoZWQpKSB7DQo+PiAgICAJCS8qIHJlbW92ZSBqb2IgZnJv bSByaW5nX21pcnJvcl9saXN0ICovDQo+PiAgICAJCWxpc3RfZGVsX2luaXQoJmpvYi0+bm9kZSk7 DQo+PiAtCQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZzY2hlZC0+am9iX2xpc3RfbG9jaywgZmxh Z3MpOw0KPj4gLQ0KPj4gLQkJc2NoZWQtPm9wcy0+ZnJlZV9qb2Ioam9iKTsNCj4+ICsJfSBlbHNl IHsNCj4+ICsJCWpvYiA9IE5VTEw7DQo+PiArCQkvKiBxdWV1ZSB0aW1lb3V0IGZvciBuZXh0IGpv YiAqLw0KPj4gKwkJZHJtX3NjaGVkX3N0YXJ0X3RpbWVvdXQoc2NoZWQpOw0KPj4gICAgCX0NCj4+ ICAgIA0KPj4gLQkvKiBxdWV1ZSB0aW1lb3V0IGZvciBuZXh0IGpvYiAqLw0KPj4gLQlzcGluX2xv Y2tfaXJxc2F2ZSgmc2NoZWQtPmpvYl9saXN0X2xvY2ssIGZsYWdzKTsNCj4+IC0JZHJtX3NjaGVk X3N0YXJ0X3RpbWVvdXQoc2NoZWQpOw0KPj4gICAgCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJnNj aGVkLT5qb2JfbGlzdF9sb2NrLCBmbGFncyk7DQo+PiAgICANCj4+ICsJcmV0dXJuIGpvYjsNCj4+ ICAgIH0NCj4+ICAgIA0KPj4gICAgLyoqDQo+PiBAQCAtNjk4LDEyICs2OTYsMTggQEAgc3RhdGlj IGludCBkcm1fc2NoZWRfbWFpbih2b2lkICpwYXJhbSkNCj4+ICAgIAkJc3RydWN0IGRybV9zY2hl ZF9mZW5jZSAqc19mZW5jZTsNCj4+ICAgIAkJc3RydWN0IGRybV9zY2hlZF9qb2IgKnNjaGVkX2pv YjsNCj4+ICAgIAkJc3RydWN0IGRtYV9mZW5jZSAqZmVuY2U7DQo+PiArCQlzdHJ1Y3QgZHJtX3Nj aGVkX2pvYiAqY2xlYW51cF9qb2IgPSBOVUxMOw0KPj4gICAgDQo+PiAgICAJCXdhaXRfZXZlbnRf aW50ZXJydXB0aWJsZShzY2hlZC0+d2FrZV91cF93b3JrZXIsDQo+PiAtCQkJCQkgKGRybV9zY2hl ZF9jbGVhbnVwX2pvYnMoc2NoZWQpLA0KPj4gKwkJCQkJIChjbGVhbnVwX2pvYiA9IGRybV9zY2hl ZF9nZXRfY2xlYW51cF9qb2Ioc2NoZWQpKSB8fA0KPj4gICAgCQkJCQkgKCFkcm1fc2NoZWRfYmxv Y2tlZChzY2hlZCkgJiYNCj4+ICAgIAkJCQkJICAoZW50aXR5ID0gZHJtX3NjaGVkX3NlbGVjdF9l bnRpdHkoc2NoZWQpKSkgfHwNCj4+IC0JCQkJCSBrdGhyZWFkX3Nob3VsZF9zdG9wKCkpKTsNCj4+ ICsJCQkJCSBrdGhyZWFkX3Nob3VsZF9zdG9wKCkpOw0KPj4gKw0KPj4gKwkJd2hpbGUgKGNsZWFu dXBfam9iKSB7DQo+PiArCQkJc2NoZWQtPm9wcy0+ZnJlZV9qb2IoY2xlYW51cF9qb2IpOw0KPj4g KwkJCWNsZWFudXBfam9iID0gZHJtX3NjaGVkX2dldF9jbGVhbnVwX2pvYihzY2hlZCk7DQo+PiAr CQl9DQo+PiAgICANCj4+ICAgIAkJaWYgKCFlbnRpdHkpDQo+PiAgICAJCQljb250aW51ZTsNCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==