Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jHRuc-0001zX-Op for mharc-qemu-trivial@gnu.org; Thu, 26 Mar 2020 08:47:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47425) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHRua-0001ve-6N for qemu-trivial@nongnu.org; Thu, 26 Mar 2020 08:47:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHRuZ-0007rp-5j for qemu-trivial@nongnu.org; Thu, 26 Mar 2020 08:47:04 -0400 Received: from mga17.intel.com ([192.55.52.151]:14044) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jHRuW-0007kM-SU; Thu, 26 Mar 2020 08:47:01 -0400 IronPort-SDR: 3AJ5+34dz68nhnqrVD4bGtWOHQt7lKXbw0Jp1cquznmlwJRWd2lJWvKDOec40uOf2ArdrH9mYX SXKueToT25dg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2020 05:46:53 -0700 IronPort-SDR: yRhMi71P7Y+NC5PufaxjVPB1Phjhhz0iuF2fO2dgWp0giOiUdWSSPWcPDmKPYTJ4+POVQcSVln pkAY8iZITVNQ== X-IronPort-AV: E=Sophos;i="5.72,308,1580803200"; d="scan'208";a="420687528" Received: from likexu-mobl1.ccr.corp.intel.com (HELO [10.249.175.106]) ([10.249.175.106]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2020 05:46:51 -0700 Subject: Re: [PATCH] i386/cpu: Expand MAX_FIXED_COUNTERS from 3 to 4 to for Icelake To: Paolo Bonzini , Richard Henderson , Eduardo Habkost Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org References: <20200317055413.66404-1-like.xu@linux.intel.com> From: Like Xu Organization: Intel OTC Message-ID: <4d7696af-b6d3-80b8-dd66-229f3d23ac5c@linux.intel.com> Date: Thu, 26 Mar 2020 20:46:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200317055413.66404-1-like.xu@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 192.55.52.151 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2020 12:47:05 -0000 Anyone to help review this change? Thanks, Like Xu On 2020/3/17 13:54, Like Xu wrote: > In the Intel SDM, "Table 18-2. Association of Fixed-Function > Performance Counters with Architectural Performance Events", > we may have a new fixed counter 'TOPDOWN.SLOTS' (since Icelake), > which counts the number of available slots for an unhalted > logical processor. Check commit 6017608936 in the kernel tree. > > Signed-off-by: Like Xu > --- > target/i386/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/cpu.h b/target/i386/cpu.h > index 576f309bbf..ec2b67d425 100644 > --- a/target/i386/cpu.h > +++ b/target/i386/cpu.h > @@ -1185,7 +1185,7 @@ typedef struct { > #define CPU_NB_REGS CPU_NB_REGS32 > #endif > > -#define MAX_FIXED_COUNTERS 3 > +#define MAX_FIXED_COUNTERS 4 > #define MAX_GP_COUNTERS (MSR_IA32_PERF_STATUS - MSR_P6_EVNTSEL0) > > #define TARGET_INSN_START_EXTRA_WORDS 1 >