Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71DFFC433E2 for ; Mon, 20 Jul 2020 08:53:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 473112080D for ; Mon, 20 Jul 2020 08:53:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="OCcsuc3l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 473112080D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D0656E1E2; Mon, 20 Jul 2020 08:53:13 +0000 (UTC) Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by gabe.freedesktop.org (Postfix) with ESMTPS id 119156E1E2 for ; Mon, 20 Jul 2020 08:53:12 +0000 (UTC) Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id AD23D5C0103; Mon, 20 Jul 2020 10:53:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1595235189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2psVOuBfQWzNlIeqUe0VNRfz3qCiweMFCB6YaVzx7DQ=; b=OCcsuc3lZe9WmOlUEF6jEi7nyes6LSwQy5g5TopNZORtWr0Ep51yf1sE3mU6HqZiwbvyuA 9JypdNValYZNBHBHP8I2XVqQdnKwMr89UmWEvcqoJzoVj0Exy4JP0r03seyx/B5LHnR1dE pTh2v+BbFszjKF4Zv6DUdzrPHr8EW+g= MIME-Version: 1.0 Date: Mon, 20 Jul 2020 10:53:09 +0200 From: Stefan Agner To: Bernard Zhao Subject: Re: [PATCH] drm/mxsfb: miss err handle in probe In-Reply-To: <20200611122311.20847-1-bernard@vivo.com> References: <20200611122311.20847-1-bernard@vivo.com> User-Agent: Roundcube Webmail/1.4.1 Message-ID: <4d83b3dfcd3efb0c639dacadd5b69619@agner.ch> X-Sender: stefan@agner.ch X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , opensource.kernel@vivo.com, David Airlie , Sascha Hauer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-06-11 14:23, Bernard Zhao wrote: > There are three err return values in drm_fbdev_generic_setup. > In mxsfb_probe we called this function, but didn`t handle the > return value, this change is to add err handle, maybe make code > a bit more readable. This got recently changed, so I guess checking the return value isn't required anymore: https://patchwork.freedesktop.org/patch/msgid/20200408082641.590-11-tzimmermann@suse.de -- Stefan > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > index 497cf443a9af..a45f3b85f725 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > @@ -415,7 +415,9 @@ static int mxsfb_probe(struct platform_device *pdev) > if (ret) > goto err_unload; > > - drm_fbdev_generic_setup(drm, 32); > + ret = drm_fbdev_generic_setup(drm, 32); > + if (ret) > + goto err_unload; > > return 0; _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel