From: Markus Elfring Subject: Re: drm/tinydrm: Fix memory leak in hx8357d_probe Date: Mon, 28 Oct 2019 19:00:48 +0100 Message-ID: <4deb2230-eabe-b817-8516-3dfad68d2065@web.de> References: <20191027173234.6449-1-navid.emamdoost@gmail.com> <85cb5ed9-66ba-3461-dd56-017b89ba70ce@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <85cb5ed9-66ba-3461-dd56-017b89ba70ce@web.de> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Navid Emamdoost , dri-devel@lists.freedesktop.org Cc: Navid Emamdoost , Kangjie Lu , Stephen McCamant , Daniel Vetter , David Airlie , Eric Anholt , LKML , kernel-janitors@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org > =E2=80=A6 >> +free_dbidev: >> + kfree(dbidev); > =E2=80=A6 > > I became curious if there is a need for such a memory release at another= place. I have taken another look also at a related implementation detail. Now I have realised that the desired clean-up should usually be achieved b= y the callback function =E2=80=9Cmipi_dbi_release=E2=80=9D for this software= module. https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/gpu/drm/drm_mipi_= dbi.c#L581 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dr= ivers/gpu/drm/drm_mipi_dbi.c?id=3D0365fb6baeb1ebefbbdad9e3f48bab9b3ccb8df3= #n581 Regards, Markus