Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24EC6C2BA19 for ; Tue, 21 Apr 2020 07:35:46 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E95F62073A for ; Tue, 21 Apr 2020 07:35:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E95F62073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQnRB-0007jj-Q6; Tue, 21 Apr 2020 07:35:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQnRA-0007je-7W for xen-devel@lists.xenproject.org; Tue, 21 Apr 2020 07:35:20 +0000 X-Inumbo-ID: a6429bf0-83a2-11ea-83d8-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a6429bf0-83a2-11ea-83d8-bc764e2007e4; Tue, 21 Apr 2020 07:35:19 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 47F39AF77; Tue, 21 Apr 2020 07:35:17 +0000 (UTC) Subject: Re: [PATCH 2/3] x86/boot: Don't enable EFER.SCE for !CONFIG_PV builds To: Andrew Cooper References: <20200420145911.5708-1-andrew.cooper3@citrix.com> <20200420145911.5708-3-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <4ded0aab-dcab-bc46-92f3-d76ac8606889@suse.com> Date: Tue, 21 Apr 2020 09:35:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200420145911.5708-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Kevin Tian , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 20.04.2020 16:59, Andrew Cooper wrote: > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -238,7 +238,8 @@ static void __init noreturn efi_arch_post_exit_boot(void) > /* Set system registers and transfer control. */ > asm volatile("pushq $0\n\tpopfq"); > rdmsrl(MSR_EFER, efer); > - efer |= EFER_SCE; > + if ( IS_ENABLED(CONFIG_PV) ) > + efer |= EFER_SCE; > if ( cpu_has_nx ) > efer |= EFER_NX; > wrmsrl(MSR_EFER, efer); Switch to simply ORing in trampoline_efer here? With or without the adjustment Reviewed-by: Jan Beulich Jan