Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D98BC7EE23 for ; Tue, 30 May 2023 12:23:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2EA2C8467A; Tue, 30 May 2023 14:23:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="YsBTYrVK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C4D208467A; Tue, 30 May 2023 14:23:41 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060c.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::60c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D5D4C83741 for ; Tue, 30 May 2023 14:23:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mZjElIo+jnxwymapx9yS/3zriKdUntX/qPOKc27yrv+Bgbsvu3pNHJ3RtzDGw7hOSXOliQSaE6E3JbXV5f9zxN/MOefuVlWX1b8FNb+9S1WMTwTHYgABvMi0lsQRZOINhWj4WJeJbB8d7CJTnHe7+FmHC8fzi/PpavUcJm2U5+XQsyjoKjUcPLKLrMOz5nCwzBgl4JASbPgSA4Kn/d5lXYhkwZCo53mSQLvzm7elHxnAHvu1PREonAQcqAllfhvyBcd2XsLYGb0eqwjN3YTQI4sghQrwxshfoyPYX5njN4pMJ6tXaO2tRt6AAYYfX7fU/5A8Ern61YwermG2fMcfHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kSX9APvkB7mHDGosHBHw3YeuUU5xiRlILNlPQcFQgLA=; b=YUIRsR21J4MZi5A7vH9CRWiw3vM7eA9otaP/7qLoDdKI8H9xGR62thPft6u7LE/th6IBabBLsJDuwa9kKpg1mWBPH99qNNCqRvRRbqIKNm3ZahQKnMnP+jfh2s+VRC0ArDi9ZqJCL8LuVOgH7neCg9Y7VCDGh8TRgncodWLgSWpnBxAJ8UeZHIayDumMymFagoBcx1VRrZp4MT2LSBvWL95aeyyYe9aUXXzu19KONOI+tT5u3hvDMzVK8zUL9vz9IxnkJSLHKXAcAwEgP5eDgjBgkfXGsq5qYu0MBFpamctRb+04uV+my38gktpjgRK86kQk//6E5fAffwNc5mtHfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kSX9APvkB7mHDGosHBHw3YeuUU5xiRlILNlPQcFQgLA=; b=YsBTYrVKd7oCz4QF0t0H0cp2CQlAi3DH12bE/V85TyOqmswsRLRKG/0PbCUClorhirayj2NC5GzF+rwuGBewot7s4GxFa5dy4qBbFCNoUR2RMc0Pg4LBEeTn0SdtW0wN6fRQTEduiV0qgePoGr+ToK0GyLB0xdnO2+2uqIsVFMM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) by IA1PR12MB6385.namprd12.prod.outlook.com (2603:10b6:208:38b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.21; Tue, 30 May 2023 12:23:33 +0000 Received: from BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::fc48:5c4b:7360:913b]) by BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::fc48:5c4b:7360:913b%4]) with mapi id 15.20.6433.022; Tue, 30 May 2023 12:23:33 +0000 Message-ID: <4dfd40b1-65cf-73a8-6621-8677a880ff42@amd.com> Date: Tue, 30 May 2023 14:23:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3] cmd: sf/nand: Print and return failure when 0 length is passed Content-Language: en-US To: Ashok Reddy Soma , u-boot@lists.denx.de Cc: jagan@amarulasolutions.com, xypron.glpk@gmx.de, sjg@chromium.org, d-gole@ti.com, jan.kiszka@siemens.com, patrice.chotard@foss.st.com, marex@denx.de, git@amd.com References: <20230516115236.22458-1-ashok.reddy.soma@amd.com> From: Michal Simek In-Reply-To: <20230516115236.22458-1-ashok.reddy.soma@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1P190CA0022.EURP190.PROD.OUTLOOK.COM (2603:10a6:802:2b::35) To BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB4758:EE_|IA1PR12MB6385:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a227ea5-699e-4797-a5a2-08db6108af6a X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TanY7QvV+BXrjVY2pWJBaNwy2/hNqMgU6gf8++QvpRUfgxeE5BQiYE1BFwY+lmj3O3dndqBVFYykIGblCpvTqSrePHgsFgiSWEMFlvy8zvpAYf/YqoupvxnFa2YKrvvE4O3XzpPCZP3cByVQskvHzxP/6rL8/ugvsCO1ZFrqfxHQ7EhChExxipsZ962FzcS4IrA2l2lpoEHfhGTLmvEhOuBkOYORHVhC8UVw5VLShcaR/dq/AgrrDLEJ2jLhrrWzKGoDBZEvly/1AV1BERns2JyKrUa7Xs+hsdjLFblXCEQ7/IVbJ3en8nhDTWyoZFgjXsNMTYuYMH+GqYJXC8T8XZLsgGCLsSmoGudz3MYVGHVH1uPinCFW/h8DpsmtuZPMsBZ80jeomjNsRU9PT7BHIrYbe6IKAtJeyzQgMk/K1MNLV5NRLTTm+ZSoE5nyPt5UmQ4KXWWxlVu+kZjyBwaLaD2Ot9+eYChUCltj7/uoZDTC5SCSBpCKWF987Dkuu/NprDi3LLFmwBAhl4XXx07x460zBPv3Umpe81iHmLVGOYvYf2jDmjxyZnhXy9NxY8R/jIXn3mbTwuPURrAEzTDasZn6YSN8qZMryNHjghn5y4ZDDLCOuIZztcreCHxAAa2T0BtfFynC7cBqN4Y2RxnG5w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB4758.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(136003)(39860400002)(396003)(346002)(376002)(451199021)(31686004)(66899021)(31696002)(53546011)(8936002)(83380400001)(6506007)(6512007)(26005)(8676002)(186003)(4326008)(41300700001)(36756003)(86362001)(2906002)(4744005)(44832011)(66946007)(66476007)(316002)(66556008)(5660300002)(2616005)(478600001)(38100700002)(6486002)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjlnMXl0ck9BWElFcWdmZHZIY01YVWlva3Rnd2d6NWVBdUViNUJ4eS9NV3lr?= =?utf-8?B?cXYzSDVQYlppSFA2TnlFY1JRaWVKL0E0RU9UN1Q4QTJGa3pHZGpUYVBzZXNJ?= =?utf-8?B?cGoxRWZLSTJMWENKS04yNDRDVmVOZFFuQTk3NlZBVjZocTZFQ1FIQ1cyS0RR?= =?utf-8?B?bDhJaGhlaUtQcVYzVFFlZlhvblhLNUtKSkZIY0hnQW5zWFdXQUorUndQTnFv?= =?utf-8?B?WldjT3g3REtvRm01TFlxTUluRXZSNkNnU0l6L1EvbVV3WGlHc2VUZkJpZTVz?= =?utf-8?B?VUxBYVVkSWxEWjlCK0ozeUZzY3d5WjdDaVF0REpweXg4eVlkOEJ2WVVoeFgy?= =?utf-8?B?OEJrajFNQTVPRGRsS2o3VG5weitPQVA1ZCtYMzJyLzNTa1dMTno2TVZGWXJ1?= =?utf-8?B?R2c0cGREczhUT0U5N052ZDFmUlZsamxWL3hTSlRUcE56QWo1VEQ5NTRBclQx?= =?utf-8?B?dU5JdldGbXc3WjlYeXBBRUxKcFBYNVlUU1VqRXhVdkdTVTNEY1dTcmNMRVZO?= =?utf-8?B?OGpRbUdKRTJ0bE5xVVJOYkZ0NWNKWUlna0RxakRKcS9lTHBrVFlsZjBNS1JO?= =?utf-8?B?aUtiSFNrck5qMGkvOEEya2xVT1VqQS9MdzNPUG91NUtRZFlsK05oOUtPbXp1?= =?utf-8?B?WmloMEM3T2hMUU8zMjBjQ29Ga25NaGF0eHlnejlNNnJYVTcyU1h6Y1RJVk51?= =?utf-8?B?WTEzRVNheE12bHZmNWZGZ0srek5PZTFSZmJCdnM1VG5SU05PWjZZd3RNVnFh?= =?utf-8?B?cFRLYVJYZEtISW03MmtEa0JmSXVDYytrRDZWRldQVzhiY1p3d2xqMWxXaE1o?= =?utf-8?B?VDh5bmRZVVlSZm5Cckx6QXR0RGtOZ2JPb09PVXJ1dnZqSmFibU0zRkllQUhl?= =?utf-8?B?N3A4MWVhR3BOV282cWw1czhOWUcrcWJtRitGMWQwaUszWnhSazVwYjFqU1dp?= =?utf-8?B?K0UyQktWTHhYOUs3UEd5dzhFS0tJdFYwT2J0NWZkRGk0NUNtaVREUW10c3JD?= =?utf-8?B?WldJcVhFOUNHUWlxQlpUTkdiQjZ2STh4dzhNbU5kVk15dFJFeE1kT2J4M3Nh?= =?utf-8?B?YW4yeWRJSUVYS0tsNlZETVV0S3hRMlZHSjZxVUpCeEt0Vmhib2xDRnl4NEtx?= =?utf-8?B?RXNpRFBTLzF6WU9wV05FVGlhWVcvRnBFZUJFMkM2VnBWQVNJVmtBejcvMzNi?= =?utf-8?B?Ti9nRFMyN1htaHlIelR3a0ZyOXFubTA3LzZZZlR5L2dMdVBvRHQ2NmlXV05h?= =?utf-8?B?Si9vY3Z2emdYR0RINXpYbFp3bTJ5TFZyN21Gd0VyV0UwaUxjYjFZaXFIVmhp?= =?utf-8?B?VndmZzM4TCtNaWh2THJRRk0zQzMzNU40YXN5STI0SWlpTFJBK1p4RFcvZHQ4?= =?utf-8?B?OTZmSlVoN3F4RS9qTFdnMnBWZUNOOG9MbzRsVW1KdFdOdjdJdE4yT1A0dnl0?= =?utf-8?B?endQaDBVSm00ckJOUE5TOUVQaU5vWjdqdUlSRzJmWlpRWTVEUUV0LzJDOTgx?= =?utf-8?B?VE8wWnVvNXZhemU2ZU1EMlFrQ3Fvb2JtYmJleW5WR3M4Ylkwd1ljSFhSL3FP?= =?utf-8?B?R3ZmRnUzWGswdldHYVhwY3FwMGxOR3BHWWI0V1ZEdUpVRHNNMnhlZTRUTVdl?= =?utf-8?B?YTgxcUhmMHR1Y3pMRTVKalRPeGNzWS9OVkNpdUJVZUVCRXlUNHpRWno0Y2RW?= =?utf-8?B?QW5XUHkzdENNbUxDb1BQbm5YR0RGdlZsNXhybUxtVENKbEV0azQwZDM2QWJF?= =?utf-8?B?aVpHMzg3bk5URHBScWVLRTJBYW43czAyRnhUWjFBUVpDRFBleHZoOTA0dklJ?= =?utf-8?B?cmFuZzREZWZIZnExYTRBZnlpWk1xWDJhUHBXU1dxSllDYWovaDgyNXhzV0pH?= =?utf-8?B?Mi9TU0lOSUpwcEtMTThTU2VSdlZIQ2FWTC9oWUtNSGdnN2VISmpGcEpLbDND?= =?utf-8?B?TWlrd3YySGxIb2dPK2FLSXNlNnRlL2VySTMzYnJ2VDRtbXVhVjJqdWxJN1g0?= =?utf-8?B?OENhTTM0U0grd3haZzhyb3VPSVhkbUJFVXp2ZVE1cEJlZ0ozT090YnMzdEZC?= =?utf-8?B?RkFHNWRFclBTTWxzMTBENmR5Nm1BRFhodHk3RHhRbElpTnFjMDFHS1g1Zkk1?= =?utf-8?Q?I8ZgUzpt8vD0G3zoATIBOc9i2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a227ea5-699e-4797-a5a2-08db6108af6a X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 12:23:33.6402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b0GdlB4S98WzLg+pq4PU1CXJnTrxw5hoXRUGF6Ju74vcKOIF2erb68wgIV60pSgA X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6385 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 5/16/23 13:52, Ashok Reddy Soma wrote: > For sf commands, when '0' length is passed for erase, update, write or > read, there might be undesired results. Ideally '0' length means nothing to > do. > > So print 'ERROR: Invalid size 0' and return cmd failure when length '0' is > passed to sf commands. Same thing applies for nand commands also. > > Example: > > ZynqMP> sf erase 0 0 > ERROR: Invalid size 0 > ZynqMP> sf write 10000 0 0 > ERROR: Invalid size 0 > ZynqMP> sf read 10000 0 0 > ERROR: Invalid size 0 > ZynqMP> sf update 1000 10000 0 > ERROR: Invalid size 0 > ZynqMP> > > Signed-off-by: Ashok Reddy Soma > --- > Applied it to my queue. If someone else wants to take please let me know and I will drop it from my queue. Thanks, Michal