Return-path: Received: from m43-7.mailgun.net ([69.72.43.7]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgQIp-0001kr-JQ for ath10k@lists.infradead.org; Wed, 03 Jun 2020 10:07:23 +0000 MIME-Version: 1.0 Date: Wed, 03 Jun 2020 15:37:10 +0530 From: govinds@codeaurora.org Subject: Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot In-Reply-To: <20200603002715.GA5349@Mani-XPS-13-9360> References: <20200602052533.15048-1-john.stultz@linaro.org> <20200603002715.GA5349@Mani-XPS-13-9360> Message-ID: <4e0642b9882c41f4c10963b265bf6d9f@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Manivannan Sadhasivam Cc: Amit Pundir , Rakesh Pillai , Brian Norris , lkml , ath10k , Bjorn Andersson , John Stultz , Sibi Sankar , Niklas Cassel , Kalle Valo Hi Mani, On 2020-06-03 05:57, Manivannan Sadhasivam wrote: > On Tue, Jun 02, 2020 at 01:04:26PM -0700, Brian Norris wrote: >> On Tue, Jun 2, 2020 at 12:40 PM John Stultz >> wrote: >> > On Tue, Jun 2, 2020 at 12:16 PM Brian Norris wrote: >> > > On Mon, Jun 1, 2020 at 10:25 PM John Stultz wrote: >> > > > >> > > > Ever since 5.7-rc1, if we call >> > > > ath10k_qmi_remove_msa_permission(), the db845c hard crashes on >> > > > reboot, resulting in the device getting stuck in the usb crash >> > > > debug mode and not coming back up wihthout a hard power off. >> > > > >> > > > This hack avoids the issue by returning early in >> > > > ath10k_qmi_event_server_exit(). >> > > > >> > > > A better solution is very much desired! >> > > >> > > Any chance you can bisect what caused this? There are a lot of >> > > non-ath10k pieces involved in this stuff. >> > >> > Amit had spent some work on chasing it down to the in kernel qrtr-ns >> > work, and reported it here: >> > https://lists.infradead.org/pipermail/ath10k/2020-April/014970.html >> > >> > But that discussion seemingly stalled out, so I came up with this hack >> > to workaround it for us. >> >> If I'm reading it right, then that means we should revert this stuff >> from v5.7-rc1: >> >> 0c2204a4ad71 net: qrtr: Migrate nameservice to kernel from userspace >> >> At least, until people can resolve the tail end of that thread. New >> features (ath11k, etc.) are not a reason to break existing features >> (ath10k/wcn3990). > > I don't agree with this. If you read through the replies to the bug > report, > it is clear that NS migration uncovered a corner case or even a bug. So > we > should try to fix that indeed. > > Govind: Did you get chance to work on fixing this issue? > I have done basic testing by moving msa map/unmap from qmi service callbacks to init/de-init path. I will send patch for review. Reason for del_server needs to investigated from rproc side. > Thanks, > Mani > >> >> Brian Thanks, Govind _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k