From: Ian Campbell Subject: [PATCH] libxc: fix bounce buffers in xc_pm_get_cx_stat and xc_pm_get_pxstat Date: Mon, 01 Nov 2010 13:17:50 +0000 Message-ID: <4e0cc9f6b97a2b048b2d.1288617470@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Yang Z , Ian Jackson , Zhang@smtp01.ad.xensource.com List-Id: xen-devel@lists.xenproject.org # HG changeset patch # User Ian Campbell # Date 1288617427 0 # Node ID 4e0cc9f6b97a2b048b2dc2d400a2b9155153a5f1 # Parent a548cd399210f6a4a9379c7e87fdf0c208d6c90b libxc: fix bounce buffers in xc_pm_get_cx_stat and xc_pm_get_pxstat We should bounce the buffers themselves, not the pointers to them! Error introduced by 22292:a1b39d2b9001 and reported by Yang Z Zhang. Signed-off-by: Ian Campbell diff -r a548cd399210 -r 4e0cc9f6b97a tools/libxc/xc_pm.c --- a/tools/libxc/xc_pm.c Mon Nov 01 11:56:59 2010 +0000 +++ b/tools/libxc/xc_pm.c Mon Nov 01 13:17:07 2010 +0000 @@ -46,8 +46,8 @@ int xc_pm_get_pxstat(xc_interface *xch, { DECLARE_SYSCTL; /* Sizes unknown until xc_pm_get_max_px */ - DECLARE_NAMED_HYPERCALL_BOUNCE(trans, &pxpt->trans_pt, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); - DECLARE_NAMED_HYPERCALL_BOUNCE(pt, &pxpt->pt, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); + DECLARE_NAMED_HYPERCALL_BOUNCE(trans, pxpt->trans_pt, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); + DECLARE_NAMED_HYPERCALL_BOUNCE(pt, pxpt->pt, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); int max_px, ret; @@ -124,8 +124,8 @@ int xc_pm_get_cxstat(xc_interface *xch, int xc_pm_get_cxstat(xc_interface *xch, int cpuid, struct xc_cx_stat *cxpt) { DECLARE_SYSCTL; - DECLARE_NAMED_HYPERCALL_BOUNCE(triggers, &cxpt->triggers, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); - DECLARE_NAMED_HYPERCALL_BOUNCE(residencies, &cxpt->residencies, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); + DECLARE_NAMED_HYPERCALL_BOUNCE(triggers, cxpt->triggers, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); + DECLARE_NAMED_HYPERCALL_BOUNCE(residencies, cxpt->residencies, 0, XC_HYPERCALL_BUFFER_BOUNCE_BOTH); int max_cx, ret; if( !cxpt || !(cxpt->triggers) || !(cxpt->residencies) )