From: "Kumar, Mahesh" Subject: Re: [PATCH v4 10/10] drm/rcar-du/crc: Implement get_crc_sources callback Date: Thu, 19 Jul 2018 16:54:25 +0530 Message-ID: <4e262a2d-6376-cdc6-6f39-231aa1529be2@intel.com> References: <20180713135942.25061-1-mahesh1.kumar@intel.com> <20180713135942.25061-11-mahesh1.kumar@intel.com> <1600855.omIG2KBUNv@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BD026ED99 for ; Thu, 19 Jul 2018 11:24:39 +0000 (UTC) In-Reply-To: <1600855.omIG2KBUNv@avalon> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Laurent Pinchart Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGkgTGF1cmVudCEKClRoYW5rcyBmb3IgdGhlIHJldmlldy4gOikKCndpbGwgdXBkYXRlIHBhdGNo IGFuZCByZXN1Ym1pdAoKLU1haGVzaAoKT24gNy8xOS8yMDE4IDQ6NDIgUE0sIExhdXJlbnQgUGlu Y2hhcnQgd3JvdGU6Cj4gSGkgTWFoZXNoLAo+Cj4gVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCj4K PiBPbiBGcmlkYXksIDEzIEp1bHkgMjAxOCAxNjo1OTo0MiBFRVNUIE1haGVzaCBLdW1hciB3cm90 ZToKPj4gVGhpcyBwYXRjaCBpbXBsZW1lbnRzIGdldF9jcmNfc291cmNlcyBjYWxsYmFjaywgd2hp Y2ggcmV0dXJucyBsaXN0IG9mCj4+IGFsbCB0aGUgY3JjIHNvdXJjZXMgc3VwcG9ydGVkIGJ5IGRy aXZlciBpbiBjdXJyZW50IHBsYXRmb3JtLgo+Pgo+PiBDaGFuZ2VzIFNpbmNlIFYxOgo+PiAgIC0g bW92ZSBzb3VyY2VzIGxpc3QgcGVyLWNydGMKPj4gICAtIGluaXQgc291cmNlcy1saXN0IG9ubHkg Zm9yIGdlbjMKPj4KPj4gU2lnbmVkLW9mZi1ieTogTWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1bWFy QGludGVsLmNvbT4KPj4gQ2M6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRl YXNvbmJvYXJkLmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9k dV9jcnRjLmMgfCA5NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4+ICAgZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmggfCAgMyArKwo+PiAgIDIgZmlsZXMgY2hh bmdlZCwgOTggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMKPj4gYi9kcml2ZXJzL2dwdS9k cm0vcmNhci1kdS9yY2FyX2R1X2NydGMuYyBpbmRleCA2YTI5MDU1YTRhYjAuLmJiZTQxN2U5M2Zl Mwo+PiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRj LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMKPj4gQEAg LTY5MSw2ICs2OTEsNzkgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19oZWxwZXJfZnVu Y3MKPj4gY3J0Y19oZWxwZXJfZnVuY3MgPSB7IC5hdG9taWNfZGlzYWJsZSA9IHJjYXJfZHVfY3J0 Y19hdG9taWNfZGlzYWJsZSwKPj4gICB9Owo+Pgo+PiArc3RhdGljIHZvaWQgcmNhcl9kdV9jcnRj X2NyY19zb3VyY2VzX2xpc3RfaW5pdChzdHJ1Y3QgcmNhcl9kdV9jcnRjICpyY3J0YykKPj4gK3sK Pj4gKwlzdHJ1Y3QgcmNhcl9kdV9kZXZpY2UgKnJjZHUgPSByY3J0Yy0+Z3JvdXAtPmRldjsKPj4g KwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gcmNydGMtPmNydGMuZGV2Owo+PiArCXN0cnVjdCBk cm1fY3J0YyAqY3J0YyA9ICZyY3J0Yy0+Y3J0YzsKPj4gKwlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFu ZTsKPj4gKwl1bnNpZ25lZCBpbnQgY291bnQ7Cj4+ICsJY29uc3QgY2hhciAqKnNvdXJjZXM7Cj4+ ICsJdTMyIHBsYW5lX21hc2s7Cj4+ICsJaW50IGkgPSAwOwo+IGkgbmV2ZXIgdGFrZXMgbmVnYXRp dmUgdmFsdWVzLCBpdCBjYW4gYmUgYW4gdW5zaWduZWQgaW50Lgo+Cj4+ICsJLyogQ1JDIGF2YWls YWJsZSBvbmx5IG9uIEdlbjMgSFcgKi8KPiBQbGVhc2UgY2FwaXRhbGl6ZSBzZW50ZW5jZXMgYW5k IGVuZCB0aGVtIHdpdGggYSBwZXJpb2QgaW4gY29tbWVudHMgdG8gbWF0Y2gKPiB0aGUgZHJpdmVy J3Mgc3R5bGUuIFRoaXMgYXBwbGllcyB0byBvdGhlciBsb2NhdGlvbnMgaW4gdGhpcyBwYXRjaC4K Pgo+PiArCWlmIChyY2R1LT5pbmZvLT5nZW4gPCAzKQo+PiArCQlnb3RvIGZhaWw7Cj4gWW91IGNh biBqdXN0IHJldHVybiBoZXJlLCBzb3VyY2VzX2NvdW50IGFuZCBzb3VyY2VzIGFyZSBpbml0aWFs aXplZCB0byAwIHdoZW4KPiB0aGUgcmNhcl9kdV9jcnRjIHN0cnVjdHVyZSBpcyBhbGxvY2F0ZWQu Cj4KPj4gKwlkcm1fZm9yX2VhY2hfcGxhbmUocGxhbmUsIGRldikgewo+PiArCQlpZiAoZHJtX2Ny dGNfbWFzayhjcnRjKSAmIHBsYW5lLT5wb3NzaWJsZV9jcnRjcykgewo+PiArCQkJY291bnQrKzsK Pj4gKwkJCXBsYW5lX21hc2sgfD0gZHJtX3BsYW5lX21hc2socGxhbmUpOwo+PiArCQl9Cj4+ICsJ fQo+IFlvdSBjYW4gaW5zdGVhZCBpdGVyYXRlIG92ZXIgdGhlIHBsYW5lcyBvZiB0aGUgYXNzb2Np YXRlZCBWU1AgKGhhcmR3YXJlCj4gY29tcG9zZXIpLgo+Cj4gCS8qIFJlc2VydmUgMSBmb3IgImF1 dG8iIHNvdXJjZS4gKi8KPiAJY291bnQgPSByY3J0Yy0+dnNwLT5udW1fcGxhbmVzICsgMTsKPgo+ IGFuZCBnZXQgcmlkIG9mIHBsYW5lX21hc2suCj4KPj4gKwkvKiByZXNlcnZlIDEgZm9yICJhdXRv IiBzb3VyY2UgKi8KPj4gKwljb3VudCArPSAxOwo+PiArCXNvdXJjZXMgPSBrbWFsbG9jX2FycmF5 KGNvdW50LCBzaXplb2YoY2hhciAqKSwgR0ZQX0tFUk5FTCk7Cj4gcy9zaXplb2YoY2hhciAqKS9z aXplb2YoKnNvdXJjZXMpLwo+Cj4+ICsJaWYgKCFzb3VyY2VzKQo+PiArCQlnb3RvIGZhaWw7Cj4+ ICsKPj4gKwlzb3VyY2VzW2ldID0ga3N0cmR1cCgiYXV0byIsIEdGUF9LRVJORUwpOwo+PiArCWlm ICghc291cmNlc1tpXSkKPj4gKwkJZ290byBmYWlsX25vX21lbTsKPj4gKwo+PiArCWkrKzsKPj4g Kwlkcm1fZm9yX2VhY2hfcGxhbmVfbWFzayhwbGFuZSwgZGV2LCBwbGFuZV9tYXNrKSB7Cj4+ICsJ CWNoYXIgbmFtZVsxNl07Cj4+ICsKPj4gKwkJc3ByaW50ZihuYW1lLCAicGxhbmUlZCIsIHBsYW5l LT5iYXNlLmlkKTsKPiBUaGUgSUQgaXMgYW4gdW5zaWduZWQgaW50ZWdlciwgeW91IHNob3VsZCB1 c2UgJXUuCj4KPj4gKwkJc291cmNlc1tpXSA9IGtzdHJkdXAobmFtZSwgR0ZQX0tFUk5FTCk7Cj4+ ICsJCWlmICghc291cmNlc1tpXSkKPj4gKwkJCWdvdG8gZmFpbF9ub19tZW07Cj4gQXMgdGhlcmUg d2lsbCBiZSBhIHNpbmdsZSBlcnJvciBsYWJlbCwgeW91IGNhbiBqdXN0IG5hbWUgaXQgImVycm9y Ii4KPgo+PiArCQlpKys7Cj4+ICsJfQo+IFlvdSBjYW4gaXRlcmF0ZSBvdmVyIHRoZSBWU1AgcGxh bmVzIGhlcmUgdG9vLgo+Cj4gCWZvciAoaSA9IDA7IGkgPCByY3J0Yy0+dnNwLT5udW1fcGxhbmVz OyArK2kpIHsKPiAJCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lID0gJnJjcnRjLT52c3AtPnBsYW5l c1tpXS5wbGFuZTsKPiAJCWNoYXIgbmFtZVsxNl07Cj4KPiAJCXNwcmludGYobmFtZSwgInBsYW5l JXUiLCBwbGFuZS0+YmFzZS5pZCk7Cj4gCQlzb3VyY2VzW2krMV0gPSBrc3RyZHVwKG5hbWUsIEdG UF9LRVJORUwpOwo+IAkJaWYgKCFzb3VyY2VzW2krMV0pCj4gCQkJZ290byBlcnJvcjsKPiAJfQo+ Cj4+ICsJcmNydGMtPnNvdXJjZXMgPSBzb3VyY2VzOwo+PiArCXJjcnRjLT5zb3VyY2VzX2NvdW50 ID0gY291bnQ7Cj4+ICsJcmV0dXJuOwo+PiArCj4+ICtmYWlsX25vX21lbToKPj4gKwl3aGlsZSAo aSA+IDApIHsKPj4gKwkJaS0tOwo+PiArCQlrZnJlZShzb3VyY2VzW2ldKTsKPj4gKwl9Cj4gWW91 J2xsIGhhdmUgdG8gYWRhcHQgaXQgYmFzZWQgb24gdGhlIGNvZGUgYWJvdmUuCj4KPj4gKwlrZnJl ZShzb3VyY2VzKTsKPj4gK2ZhaWw6Cj4+ICsJcmNydGMtPnNvdXJjZXMgPSBOVUxMOwo+PiArCXJj cnRjLT5zb3VyY2VzX2NvdW50ID0gMDsKPj4gK30KPj4gKwo+PiArc3RhdGljIHZvaWQgcmNhcl9k dV9jcnRjX2NyY19zb3VyY2VzX2xpc3RfdW5pbml0KHN0cnVjdCByY2FyX2R1X2NydGMKPj4gKnJj cnRjKQo+PiArewo+PiArCXVuc2lnbmVkIGludCBpOwo+PiArCj4+ICsJaWYgKCFyY3J0Yy0+c291 cmNlcykKPj4gKwkJcmV0dXJuOwo+PiArCj4+ICsJZm9yIChpID0gMDsgaSA8IHJjcnRjLT5zb3Vy Y2VzX2NvdW50OyBpKyspCj4+ICsJCWtmcmVlKHJjcnRjLT5zb3VyY2VzW2ldKTsKPj4gKwlrZnJl ZShyY3J0Yy0+c291cmNlcyk7Cj4+ICsKPj4gKwlyY3J0Yy0+c291cmNlcyA9IE5VTEw7Cj4+ICsJ cmNydGMtPnNvdXJjZXNfY291bnQgPSAwOwo+PiArfQo+PiArCj4+ICAgc3RhdGljIHN0cnVjdCBk cm1fY3J0Y19zdGF0ZSAqCj4+ICAgcmNhcl9kdV9jcnRjX2F0b21pY19kdXBsaWNhdGVfc3RhdGUo c3RydWN0IGRybV9jcnRjICpjcnRjKQo+PiAgIHsKPj4gQEAgLTcxNyw2ICs3OTAsMTUgQEAgc3Rh dGljIHZvaWQgcmNhcl9kdV9jcnRjX2F0b21pY19kZXN0cm95X3N0YXRlKHN0cnVjdAo+PiBkcm1f Y3J0YyAqY3J0Yywga2ZyZWUodG9fcmNhcl9jcnRjX3N0YXRlKHN0YXRlKSk7Cj4+ICAgfQo+Pgo+ PiArc3RhdGljIHZvaWQgcmNhcl9kdV9jcnRjX2NsZWFudXAoc3RydWN0IGRybV9jcnRjICpjcnRj KQo+PiArewo+PiArCXN0cnVjdCByY2FyX2R1X2NydGMgKnJjcnRjID0gdG9fcmNhcl9jcnRjKGNy dGMpOwo+PiArCj4+ICsJcmNhcl9kdV9jcnRjX2NyY19zb3VyY2VzX2xpc3RfdW5pbml0KHJjcnRj KTsKPj4gKwo+PiArCXJldHVybiBkcm1fY3J0Y19jbGVhbnVwKGNydGMpOwo+PiArfQo+PiArCj4+ ICAgc3RhdGljIHZvaWQgcmNhcl9kdV9jcnRjX3Jlc2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykK Pj4gICB7Cj4+ICAgCXN0cnVjdCByY2FyX2R1X2NydGNfc3RhdGUgKnN0YXRlOwo+PiBAQCAtODEx LDYgKzg5MywxNSBAQCBzdGF0aWMgaW50IHJjYXJfZHVfY3J0Y192ZXJpZnlfY3JjX3NvdXJjZShz dHJ1Y3QKPj4gZHJtX2NydGMgKmNydGMsIHJldHVybiAwOwo+PiAgIH0KPj4KPj4gK2NvbnN0IGNo YXIgKmNvbnN0ICpyY2FyX2R1X2NydGNfZ2V0X2NyY19zb3VyY2VzKHN0cnVjdCBkcm1fY3J0YyAq Y3J0YywKPj4gKwkJCQkJCXNpemVfdCAqY291bnQpCj4+ICt7Cj4+ICsJc3RydWN0IHJjYXJfZHVf Y3J0YyAqcmNydGMgPSB0b19yY2FyX2NydGMoY3J0Yyk7Cj4+ICsKPj4gKwkqY291bnQgPSByY3J0 Yy0+c291cmNlc19jb3VudDsKPj4gKwlyZXR1cm4gKGNvbnN0IGNoYXIgKiBjb25zdCopcmNydGMt PnNvdXJjZXM7Cj4gU2hvdWxkbid0IHlvdSBkZWNsYXJlIHJjcnRjLT5zb3VyY2VzIGFzIGEgY29u c3QgY2hhciAqIGNvbnN0ICogZmllbGQgaW5zdGVhZAo+IG9mIGNhc3RpbmcgaXQgaGVyZSA/Cj4K Pj4gK30KPj4gKwo+PiAgIHN0YXRpYyBpbnQgcmNhcl9kdV9jcnRjX3NldF9jcmNfc291cmNlKHN0 cnVjdCBkcm1fY3J0YyAqY3J0YywKPj4gICAJCQkJICAgICAgIGNvbnN0IGNoYXIgKnNvdXJjZV9u YW1lKQo+PiAgIHsKPj4gQEAgLTg4MSw3ICs5NzIsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRy bV9jcnRjX2Z1bmNzIGNydGNfZnVuY3NfZ2VuMiA9IHsKPj4KPj4gICBzdGF0aWMgY29uc3Qgc3Ry dWN0IGRybV9jcnRjX2Z1bmNzIGNydGNfZnVuY3NfZ2VuMyA9IHsKPj4gICAJLnJlc2V0ID0gcmNh cl9kdV9jcnRjX3Jlc2V0LAo+PiAtCS5kZXN0cm95ID0gZHJtX2NydGNfY2xlYW51cCwKPj4gKwku ZGVzdHJveSA9IHJjYXJfZHVfY3J0Y19jbGVhbnVwLAo+PiAgIAkuc2V0X2NvbmZpZyA9IGRybV9h dG9taWNfaGVscGVyX3NldF9jb25maWcsCj4+ICAgCS5wYWdlX2ZsaXAgPSBkcm1fYXRvbWljX2hl bHBlcl9wYWdlX2ZsaXAsCj4+ICAgCS5hdG9taWNfZHVwbGljYXRlX3N0YXRlID0gcmNhcl9kdV9j cnRjX2F0b21pY19kdXBsaWNhdGVfc3RhdGUsCj4+IEBAIC04OTAsNiArOTgxLDcgQEAgc3RhdGlj IGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19mdW5jcyBjcnRjX2Z1bmNzX2dlbjMgPSB7Cj4+ICAgCS5k aXNhYmxlX3ZibGFuayA9IHJjYXJfZHVfY3J0Y19kaXNhYmxlX3ZibGFuaywKPj4gICAJLnNldF9j cmNfc291cmNlID0gcmNhcl9kdV9jcnRjX3NldF9jcmNfc291cmNlLAo+PiAgIAkudmVyaWZ5X2Ny Y19zb3VyY2UgPSByY2FyX2R1X2NydGNfdmVyaWZ5X2NyY19zb3VyY2UsCj4+ICsJLmdldF9jcmNf c291cmNlcyA9IHJjYXJfZHVfY3J0Y19nZXRfY3JjX3NvdXJjZXMsCj4+ICAgfTsKPj4KPj4gICAv Kgo+PiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4gLS0gQEAgLTEwMjgsNSArMTEyMCw3IEBAIGludCBy Y2FyX2R1X2NydGNfY3JlYXRlKHN0cnVjdCByY2FyX2R1X2dyb3VwICpyZ3JwLAo+PiB1bnNpZ25l ZCBpbnQgc3dpbmRleCwgcmV0dXJuIHJldDsKPj4gICAJfQo+Pgo+PiArCXJjYXJfZHVfY3J0Y19j cmNfc291cmNlc19saXN0X2luaXQocmNydGMpOwo+PiArCj4+ICAgCXJldHVybiAwOwo+PiAgIH0K Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5oCj4+ IGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmggaW5kZXggNzY4MGNiMjYz NmM4Li4wY2QwYzE2NTViZWIKPj4gMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yY2Fy LWR1L3JjYXJfZHVfY3J0Yy5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJf ZHVfY3J0Yy5oCj4+IEBAIC02Nyw2ICs2Nyw5IEBAIHN0cnVjdCByY2FyX2R1X2NydGMgewo+PiAg IAlzdHJ1Y3QgcmNhcl9kdV9ncm91cCAqZ3JvdXA7Cj4+ICAgCXN0cnVjdCByY2FyX2R1X3ZzcCAq dnNwOwo+PiAgIAl1bnNpZ25lZCBpbnQgdnNwX3BpcGU7Cj4+ICsKPj4gKwljb25zdCBjaGFyICoq c291cmNlczsKPj4gKwl1bnNpZ25lZCBpbnQgc291cmNlc19jb3VudDsKPj4gICB9Owo+Pgo+PiAg ICNkZWZpbmUgdG9fcmNhcl9jcnRjKGMpCWNvbnRhaW5lcl9vZihjLCBzdHJ1Y3QgcmNhcl9kdV9j cnRjLCBjcnRjKQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==