Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AEF2C54E49 for ; Thu, 7 May 2020 03:13:35 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3094320663; Thu, 7 May 2020 03:13:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="QVNOoy9D"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="Hmhk2uCk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3094320663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jWWyc-0000pl-On; Thu, 07 May 2020 03:13:34 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWWyb-0000pe-Hz for linux-f2fs-devel@lists.sourceforge.net; Thu, 07 May 2020 03:13:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JdHqTB+CQkOs/g2tLg+GJKcCcjHlzr0uIKAZxUhWcVY=; b=QVNOoy9DWl502itJMphEm5g8SJ x7PNRiKR29i7/Pt0+uTpooMLOyb51/dmDDPM61ZZySWv+jrv3+x03NZaFC0A83+JNTmN/AEd4QWF1 axSjbRRSUchzdluTX03gOFqFY/uJeuBjvshDaTM4tJxDHOwYvGJePBdT9VUeTlS5Dnw0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JdHqTB+CQkOs/g2tLg+GJKcCcjHlzr0uIKAZxUhWcVY=; b=Hmhk2uCkpi2sf70wf1wtbMObN4 iL0YmBw0B2ATsJbC67nRjcnboflz2mKFQf8KE1x6s/gkv4JwkqfWlWkukzDtBWYKH5UvVNuz26zvX ylQRGqRLOaPgtKfJIl2NIdUg1S0A4G9D1XIfOAovO0bxxQR/R15r/vJKoRlSL7KSq6w4=; Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jWWya-00DfYW-0E for linux-f2fs-devel@lists.sourceforge.net; Thu, 07 May 2020 03:13:33 +0000 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 0A376B64C5105C710702; Thu, 7 May 2020 11:13:23 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.211) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 7 May 2020 11:13:18 +0800 To: Eric Biggers References: <20200505204823.211214-1-ebiggers@kernel.org> <4143486a-41bf-e92f-cc99-c6a2d0a8270c@huawei.com> <20200506184301.GA842@sol.localdomain> From: Chao Yu Message-ID: <4e2b1c0f-292b-3a39-bcd2-06cc0680d3cd@huawei.com> Date: Thu, 7 May 2020 11:13:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200506184301.GA842@sol.localdomain> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1jWWya-00DfYW-0E Subject: Re: [f2fs-dev] [PATCH] f2fs: don't return vmalloc() memory from f2fs_kmalloc() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/5/7 2:43, Eric Biggers wrote: > On Wed, May 06, 2020 at 03:43:36PM +0800, Chao Yu wrote: >> On 2020/5/6 4:48, Eric Biggers wrote: >>> From: Eric Biggers >>> >>> kmalloc() returns kmalloc'ed memory, and kvmalloc() returns either >>> kmalloc'ed or vmalloc'ed memory. But the f2fs wrappers, f2fs_kmalloc() >>> and f2fs_kvmalloc(), both return both kinds of memory. >>> >>> It's redundant to have two functions that do the same thing, and also >>> breaking the standard naming convention is causing bugs since people >>> assume it's safe to kfree() memory allocated by f2fs_kmalloc(). See >>> e.g. the various allocations in fs/f2fs/compress.c. >>> >>> Fix this by making f2fs_kmalloc() just use kmalloc(). And to avoid >>> re-introducing the allocation failures that the vmalloc fallback was >>> intended to fix, convert the largest allocations to use f2fs_kvmalloc(). >> >> I've submitted one patch since you suggested when commented in compression >> support patch. >> >> I remember Jaegeuk prefer to use f2fs_kvmalloc() to instead f2fs_kmalloc(), >> and keep the order of kmalloc - failed - kvmalloc. >> > > I think you're talking about > https://lkml.kernel.org/r/20191105030451.GA55090@jaegeuk-macbookpro.roam.corp.google.com? > > I think that making the large allocations use kvmalloc(), as this patch does, is > good enough to address any memory allocation failures that may have been > encountered in the past. We don't need to switch all allocations to use > kvmalloc(), as there's no benefit for small allocations. Yeah, I agreed, and in ENOMEM case, small-sized kvmalloc increases allocating path length unnecessarily. Thanks, > > - Eric > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel