Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6840BC3064D for ; Thu, 27 Jun 2024 08:16:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A5BA710E18F; Thu, 27 Jun 2024 08:16:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="wG2gH66D"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="PwzsNEKF"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="wG2gH66D"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="PwzsNEKF"; dkim-atps=neutral Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9ED9A10E18F for ; Thu, 27 Jun 2024 08:16:29 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F35321FBAB; Thu, 27 Jun 2024 08:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1719476188; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SGQD/goNZ0lLFKRx4wt2x6TM9SR9B1sgn/SeHqY+7dk=; b=wG2gH66DTmHvjTL1j7KduIjmjTEoby6vXKTPizhC8xlfB1SXS7GdYH0dWoJWRAET00znGQ DNx9WlH6qJ21Iz7k7LbE0m5NRl8mlgd/ix3wXP+0OAj9w7R58yZmRiS5pFyzD2rVnzvuUS ariZCiBAY7QcvkIdK/s0KmCJ0yM+f9k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1719476188; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SGQD/goNZ0lLFKRx4wt2x6TM9SR9B1sgn/SeHqY+7dk=; b=PwzsNEKFP8omkvcgVFH6JHHDiBc3Jc/38TQnQmFUUy3g3im86ghXxXlTkj54O55k/8H+uS 0PahTPZ4GI9+ygDw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wG2gH66D; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PwzsNEKF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1719476188; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SGQD/goNZ0lLFKRx4wt2x6TM9SR9B1sgn/SeHqY+7dk=; b=wG2gH66DTmHvjTL1j7KduIjmjTEoby6vXKTPizhC8xlfB1SXS7GdYH0dWoJWRAET00znGQ DNx9WlH6qJ21Iz7k7LbE0m5NRl8mlgd/ix3wXP+0OAj9w7R58yZmRiS5pFyzD2rVnzvuUS ariZCiBAY7QcvkIdK/s0KmCJ0yM+f9k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1719476188; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SGQD/goNZ0lLFKRx4wt2x6TM9SR9B1sgn/SeHqY+7dk=; b=PwzsNEKFP8omkvcgVFH6JHHDiBc3Jc/38TQnQmFUUy3g3im86ghXxXlTkj54O55k/8H+uS 0PahTPZ4GI9+ygDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BF576137DF; Thu, 27 Jun 2024 08:16:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ebVlLdsffWbZBgAAD6G6ig (envelope-from ); Thu, 27 Jun 2024 08:16:27 +0000 Message-ID: <4e341fed-c1bf-4baf-bebf-07476852714c@suse.de> Date: Thu, 27 Jun 2024 10:16:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/ast: Inline drm_simple_encoder_init() To: Jocelyn Falempe , airlied@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org References: <20240625131815.14514-1-tzimmermann@suse.de> <3909ae22-c0c0-4f0a-b3e3-b124e86512f7@redhat.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <3909ae22-c0c0-4f0a-b3e3-b124e86512f7@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: F35321FBAB X-Spamd-Result: default: False [-6.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FREEMAIL_TO(0.00)[redhat.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[7]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Am 25.06.24 um 16:18 schrieb Jocelyn Falempe: > > On 25/06/2024 15:18, Thomas Zimmermann wrote: >> The function drm_simple_encoder_init() is a trivial helper and >> deprecated. Replace it with the regular call to drm_encoder_init(). >> Resolves the dependency on drm_simple_kms_helper.h. No functional >> changes. > > Thanks for your patch, it looks good to me. > > Reviewed-by: Jocelyn Falempe Thanks. I've merged the patch for now. Let's see where the discussion on managed interfaces goes. Best regards Thomas >> >> Signed-off-by: Thomas Zimmermann >> --- >>   drivers/gpu/drm/ast/ast_mode.c | 45 ++++++++++++++++++++++++++++++---- >>   1 file changed, 40 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/ast/ast_mode.c >> b/drivers/gpu/drm/ast/ast_mode.c >> index 6695af70768f..2fd9c78eab73 100644 >> --- a/drivers/gpu/drm/ast/ast_mode.c >> +++ b/drivers/gpu/drm/ast/ast_mode.c >> @@ -45,7 +45,6 @@ >>   #include >>   #include >>   #include >> -#include >>     #include "ast_ddc.h" >>   #include "ast_drv.h" >> @@ -1358,6 +1357,14 @@ static int ast_crtc_init(struct drm_device *dev) >>       return 0; >>   } >>   +/* >> + * VGA Encoder >> + */ >> + >> +static const struct drm_encoder_funcs ast_vga_encoder_funcs = { >> +    .destroy = drm_encoder_cleanup, >> +}; >> + >>   /* >>    * VGA Connector >>    */ >> @@ -1411,7 +1418,8 @@ static int ast_vga_output_init(struct >> ast_device *ast) >>       struct drm_connector *connector = &ast->output.vga.connector; >>       int ret; >>   -    ret = drm_simple_encoder_init(dev, encoder, >> DRM_MODE_ENCODER_DAC); >> +    ret = drm_encoder_init(dev, encoder, &ast_vga_encoder_funcs, >> +                   DRM_MODE_ENCODER_DAC, NULL); >>       if (ret) >>           return ret; >>       encoder->possible_crtcs = drm_crtc_mask(crtc); >> @@ -1427,6 +1435,14 @@ static int ast_vga_output_init(struct >> ast_device *ast) >>       return 0; >>   } >>   +/* >> + * SIL164 Encoder >> + */ >> + >> +static const struct drm_encoder_funcs ast_sil164_encoder_funcs = { >> +    .destroy = drm_encoder_cleanup, >> +}; >> + >>   /* >>    * SIL164 Connector >>    */ >> @@ -1480,7 +1496,8 @@ static int ast_sil164_output_init(struct >> ast_device *ast) >>       struct drm_connector *connector = &ast->output.sil164.connector; >>       int ret; >>   -    ret = drm_simple_encoder_init(dev, encoder, >> DRM_MODE_ENCODER_TMDS); >> +    ret = drm_encoder_init(dev, encoder, &ast_sil164_encoder_funcs, >> +                   DRM_MODE_ENCODER_TMDS, NULL); >>       if (ret) >>           return ret; >>       encoder->possible_crtcs = drm_crtc_mask(crtc); >> @@ -1496,6 +1513,14 @@ static int ast_sil164_output_init(struct >> ast_device *ast) >>       return 0; >>   } >>   +/* >> + * DP501 Encoder >> + */ >> + >> +static const struct drm_encoder_funcs ast_dp501_encoder_funcs = { >> +    .destroy = drm_encoder_cleanup, >> +}; >> + >>   /* >>    * DP501 Connector >>    */ >> @@ -1578,7 +1603,8 @@ static int ast_dp501_output_init(struct >> ast_device *ast) >>       struct drm_connector *connector = &ast->output.dp501.connector; >>       int ret; >>   -    ret = drm_simple_encoder_init(dev, encoder, >> DRM_MODE_ENCODER_TMDS); >> +    ret = drm_encoder_init(dev, encoder, &ast_dp501_encoder_funcs, >> +                   DRM_MODE_ENCODER_TMDS, NULL); >>       if (ret) >>           return ret; >>       encoder->possible_crtcs = drm_crtc_mask(crtc); >> @@ -1594,6 +1620,14 @@ static int ast_dp501_output_init(struct >> ast_device *ast) >>       return 0; >>   } >>   +/* >> + * ASPEED Display-Port Encoder >> + */ >> + >> +static const struct drm_encoder_funcs ast_astdp_encoder_funcs = { >> +    .destroy = drm_encoder_cleanup, >> +}; >> + >>   /* >>    * ASPEED Display-Port Connector >>    */ >> @@ -1688,7 +1722,8 @@ static int ast_astdp_output_init(struct >> ast_device *ast) >>       struct drm_connector *connector = &ast->output.astdp.connector; >>       int ret; >>   -    ret = drm_simple_encoder_init(dev, encoder, >> DRM_MODE_ENCODER_TMDS); >> +    ret = drm_encoder_init(dev, encoder, &ast_astdp_encoder_funcs, >> +                   DRM_MODE_ENCODER_TMDS, NULL); >>       if (ret) >>           return ret; >>       encoder->possible_crtcs = drm_crtc_mask(crtc); > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)