Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58F1AC433EF for ; Mon, 16 May 2022 23:41:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6148884261; Tue, 17 May 2022 01:41:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="hkl+/By9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 833FB84251; Tue, 17 May 2022 01:41:39 +0200 (CEST) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AC2DA8425F for ; Tue, 17 May 2022 01:41:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20220516234126epoutp02a943d4599cf715c6782d276882b5a6d3~vulqYIqrI0138101381epoutp02d for ; Mon, 16 May 2022 23:41:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20220516234126epoutp02a943d4599cf715c6782d276882b5a6d3~vulqYIqrI0138101381epoutp02d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1652744486; bh=5xkJqusb/QefmZeOmrfbtRnPRKidMB1uq6wD7GrtzEY=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=hkl+/By91S+F4NQFLwMUyiMz6GQ7qpKp6uIgqOEEaiDj+dYYfigDMmzUg7TPT4aDh WsRjvWu3X/+Z3yob6/Pt/xgx0Chmn6Xa619gMdi9L9tqPIZQsJMEpVxaLk8MV5K57O 56aRM+X29JvIKSRHV3tL9SlcbRSzmVM2181LnKvg= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20220516234126epcas1p352dc7acd2fe4ed53b7c34ca0098b5cf9~vulqLzIZE2795827958epcas1p3R; Mon, 16 May 2022 23:41:26 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.38.232]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4L2G3m4SVkz4x9QT; Mon, 16 May 2022 23:41:24 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id 1C.B2.09935.421E2826; Tue, 17 May 2022 08:41:24 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20220516234124epcas1p30c3f668aeafea3c61238f7160b342861~vuloSvUOm2794227942epcas1p3T; Mon, 16 May 2022 23:41:24 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20220516234124epsmtrp21697b57b5a3acfaf659dd6e0052e0d74~vuloSACmW2594025940epsmtrp2C; Mon, 16 May 2022 23:41:24 +0000 (GMT) X-AuditID: b6c32a39-f4dff700000026cf-78-6282e12426bc Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 42.6A.11276.421E2826; Tue, 17 May 2022 08:41:24 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220516234123epsmtip245d0cda54f10be507429f4d8557ed399~vuln3AxpV2388223882epsmtip2N; Mon, 16 May 2022 23:41:23 +0000 (GMT) Message-ID: <4e5a0df0-3a49-cd35-93bb-52cfa717b185@samsung.com> Date: Tue, 17 May 2022 08:41:23 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] mmc: fsl_esdhc_spl: Fix checking for number of read sectors Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Peng Fan , Priyanka Jain , Sinan Akman Cc: u-boot@lists.denx.de From: Jaehoon Chung In-Reply-To: <20220511182828.26890-1-pali@kernel.org> Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupik+LIzCtJLcpLzFFi42LZdlhTX1flYVOSwdKHShYL9pxms/ix6gur RdeUFUwWV6YvZ7d4u7eT3YHVY9OqTjaPs3d2MHpsfLeDyePF6RbGAJaobJuM1MSU1CKF1Lzk /JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoMVKCmWJOaVAoYDE4mIlfTub ovzSklSFjPziElul1IKUnALTAr3ixNzi0rx0vbzUEitDAwMjU6DChOyMX/eXMhfc5ajYfHAx awPjRPYuRk4OCQETiZmTnzGD2EICOxgltm5i62LkArI/MUps+fYTKvGNUeL2nnyYhodrl7BD FO0FKjq+khXCec8o0fDxLhtIFa+AncS8VVeYQGwWAVWJV2/+sUDEBSVOznwCZosKREhMm3UG rF5YIEji9JY/YHFmAXGJW0/mM4EMFRGYxSixb/deZoiEhMSSQ/dZQWw2AR2J7d+OAxVxcHAK mEo83a8NUSIv0bx1NjNIr4TAX3aJTRcms0Cc7SJx7vppNghbWOLV8S1Q/0tJfH63lw2ioZlR YumSg6wQTg+jxL+G61AdxhL7l04G28YsoCmxfpc+RFhRYufvuYwQm/kk3n3tYQUpkRDgleho E4IoUZG49PolE8yuu0/+s0LYHhJ7t55mm8CoOAspXGYh+X8Wkn9mISxewMiyilEstaA4Nz21 2LDAFB7byfm5mxjBiVLLcgfj9Lcf9A4xMnEwHmKU4GBWEuE1qGhIEuJNSaysSi3Kjy8qzUkt PsRoCoydicxSosn5wFSdVxJvaGJpYGJmZGxiYWhmqCTOu2ra6UQhgfTEktTs1NSC1CKYPiYO TqkGpplXtsm0PPgqYMdTVN5vyjrv0abKaTHe11dfOZkrske2Z67eibdaygq33NmkxJTCt6sd +s4acWGJz4Yv/rvcd5S8uN7Z92jxqW9HZk+KsUw1/n/P2WbS7HsOr/s/PeBqb8tbfGF9yYKV 83+l2v3perFkF9czt1Uqn5T/pZ28vOX0GwPZ8JsXth7JK7yz9IiWt9aGv0Id+8yehTw0TIjh tQ9denF11/LQNTF2p3t0U5x2t3c/NZ3a27+tuK0n2qa+fomPKlOsYeNpTdajJ9Y4rDUMmuaU r7fkbObjCM5CjeOGydMX94bu+Xteh3divBpvtOTuRbmruhd231no8v/zwY9c/s9V73qJVJ6O 8Tt8v1SJpTgj0VCLuag4EQBZaNpRHQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsWy7bCSvK7Kw6Ykg21/uCwW7DnNZvFj1RdW i64pK5gsrkxfzm7xdm8nuwOrx6ZVnWweZ+/sYPTY+G4Hk8eL0y2MASxRXDYpqTmZZalF+nYJ XBm/7i9lLrjLUbH54GLWBsaJ7F2MnBwSAiYSD9cuAbK5OIQEdjNKrPq/HCohJfH56VS2LkYO IFtY4vDhYoiat4wS/QdusILU8ArYScxbdYUJxGYRUJV49eYfC0RcUOLkzCdgtqhAhMSD3WfB 6oUFgiROb/kDFmcWEJe49WQ+E8hQEYFZjBKTbh9kh0hISCw5dJ8VYlsHo8S0ef8YQRJsAjoS 278dZwK5iFPAVOLpfm0Qk1lAXWL9PCGIVnmJ5q2zmScwCs1CcsYsJOtmIXTMQtKxgJFlFaNk akFxbnpusWGBYV5quV5xYm5xaV66XnJ+7iZGcFxoae5g3L7qg94hRiYOxkOMEhzMSiK8BhUN SUK8KYmVValF+fFFpTmpxYcYpTlYlMR5L3SdjBcSSE8sSc1OTS1ILYLJMnFwSjUwTe3Qk/++ b5nyhzXV99W3PLrG82u72MXQ2o25fu+0px18+f6VpT7DZYWUvpsvZc+1rS0+d9/SI2DGMwvR S5u0XFIOqp+9sKD7ftfjV0sfrnv77bJMkZ/ffn5pgYzq2ohrl+pTQizjN+143uAX7fzx/9Gp i3e3Vv2sCg56toP7zjHrGTOubTRmEj34Sdeve9bsoDLmti+lbGHMUTb6Jgnr/1bVbjj+tyot oodxgoru0X3sRT8O3d3HuWnbMuXHU4pLPj6/srG14tDfkEDTfSqGhysD4pomfp7g+uXnyh/V k45UK+tdkFKw3mOaUFBdKv7jQmf6r3fRV8sKu14s2R1gxPHgqddzpvWLE5Pt7RQ2hSmxFGck GmoxFxUnAgAOMvjh+gIAAA== X-CMS-MailID: 20220516234124epcas1p30c3f668aeafea3c61238f7160b342861 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220511182904epcas1p46476ec8dff08a0b9f5acc9ac46989c7c References: <20220511182828.26890-1-pali@kernel.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 5/12/22 03:28, Pali Rohár wrote: > Commit 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy > support") changed number of sectors which are read but did not adjusted > error check. > > Fix it and check for if correct number of sectors were read. > > Fixes: 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support") > Signed-off-by: Pali Rohár Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/fsl_esdhc_spl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c > index ea8f4cd66964..760f13d24018 100644 > --- a/drivers/mmc/fsl_esdhc_spl.c > +++ b/drivers/mmc/fsl_esdhc_spl.c > @@ -106,7 +106,7 @@ again: > blk_off = (sector * 512) % mmc->read_bl_len; > blk_cnt = DIV_ROUND_UP(512, mmc->read_bl_len); > err = mmc->block_dev.block_read(&mmc->block_dev, blk_start, blk_cnt, tmp_buf); > - if (err != 1) { > + if (err != blk_cnt) { > puts("spl: mmc read failed!!\n"); > hang(); > }