From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] Revert "drm/amdgpu: Refactor flip into prepare submit and submit. (v2)" Date: Thu, 27 Apr 2017 12:04:03 +0200 Message-ID: <4e89bf8d-1620-e0e8-a331-9e2d53341635@vodafone.de> References: <20170427081838.2424-1-michel@daenzer.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170427081838.2424-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Michel_D=c3=a4nzer?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMjcuMDQuMjAxNyB1bSAxMDoxOCBzY2hyaWViIE1pY2hlbCBEw6RuemVyOgo+IEZyb206IE1p Y2hlbCBEw6RuemVyIDxtaWNoZWwuZGFlbnplckBhbWQuY29tPgo+Cj4gVGhpcyByZXZlcnRzIGNv bW1pdCBjYjM0MWEzMTlmN2U2NmY4NzlkNjlhZjkyOWMzZGFkZmMxYThmMzFlLgo+Cj4gVGhlIHB1 cnBvc2Ugb2YgdGhlIHJlZmFjdG9yIHdhcyBmb3IgYW1kZ3B1X2NydGNfcHJlcGFyZS9zdWJtaXRf ZmxpcCB0bwo+IGJlIHVzZWQgYnkgdGhlIERDIGNvZGUsIGJ1dCB0aGF0J3Mgbm8gbG9uZ2VyIHRo ZSBjYXNlLgo+Cj4gU2lnbmVkLW9mZi1ieTogTWljaGVsIETDpG56ZXIgPG1pY2hlbC5kYWVuemVy QGFtZC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGlz cGxheS5jIHwgMTQ3ICsrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9tb2RlLmggICAgfCAgMTcgLS0tLQo+ICAgMiBmaWxlcyBj aGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAxMzUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rpc3BsYXkuYyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kaXNwbGF5LmMKPiBpbmRleCA3Y2YyMjZkZmI2MDIu LjA0MTU4NzU2NTZjMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2Rpc3BsYXkuYwo+IEBAIC0xMzgsNTYgKzEzOCwxMCBAQCBzdGF0aWMgdm9pZCBhbWRncHVfdW5w aW5fd29ya19mdW5jKHN0cnVjdCB3b3JrX3N0cnVjdCAqX193b3JrKQo+ICAgCWtmcmVlKHdvcmsp Owo+ICAgfQo+ICAgCj4gLQo+IC1zdGF0aWMgdm9pZCBhbWRncHVfZmxpcF93b3JrX2NsZWFudXAo c3RydWN0IGFtZGdwdV9mbGlwX3dvcmsgKndvcmspCj4gLXsKPiAtCWludCBpOwo+IC0KPiAtCWFt ZGdwdV9ib191bnJlZigmd29yay0+b2xkX2Fibyk7Cj4gLQlmZW5jZV9wdXQod29yay0+ZXhjbCk7 Cj4gLQlmb3IgKGkgPSAwOyBpIDwgd29yay0+c2hhcmVkX2NvdW50OyArK2kpCj4gLQkJZmVuY2Vf cHV0KHdvcmstPnNoYXJlZFtpXSk7Cj4gLQlrZnJlZSh3b3JrLT5zaGFyZWQpOwo+IC0Ja2ZyZWUo d29yayk7Cj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lkIGFtZGdwdV9mbGlwX2NsZWFudXBfdW5yZXNl cnZlKAo+IC0JCXN0cnVjdCBhbWRncHVfZmxpcF93b3JrICp3b3JrLAo+IC0JCXN0cnVjdCBhbWRn cHVfYm8gKm5ld19hYm8pCj4gLXsKPiAtCWFtZGdwdV9ib191bnJlc2VydmUobmV3X2Fibyk7Cj4g LQlhbWRncHVfZmxpcF93b3JrX2NsZWFudXAod29yayk7Cj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lk IGFtZGdwdV9mbGlwX2NsZWFudXBfdW5waW4oCj4gLQkJc3RydWN0IGFtZGdwdV9mbGlwX3dvcmsg KndvcmssCj4gLQkJc3RydWN0IGFtZGdwdV9ibyAqbmV3X2FibykKPiAtewo+IC0JaWYgKHVubGlr ZWx5KGFtZGdwdV9ib191bnBpbihuZXdfYWJvKSAhPSAwKSkKPiAtCQlEUk1fRVJST1IoImZhaWxl ZCB0byB1bnBpbiBuZXcgYWJvIGluIGVycm9yIHBhdGhcbiIpOwo+IC0JYW1kZ3B1X2ZsaXBfY2xl YW51cF91bnJlc2VydmUod29yaywgbmV3X2Fibyk7Cj4gLX0KPiAtCj4gLXZvaWQgYW1kZ3B1X2Ny dGNfY2xlYW51cF9mbGlwX2N0eCgKPiAtCQlzdHJ1Y3QgYW1kZ3B1X2ZsaXBfd29yayAqd29yaywK PiAtCQlzdHJ1Y3QgYW1kZ3B1X2JvICpuZXdfYWJvKQo+IC17Cj4gLQlpZiAodW5saWtlbHkoYW1k Z3B1X2JvX3Jlc2VydmUobmV3X2FibywgZmFsc2UpICE9IDApKSB7Cj4gLQkJRFJNX0VSUk9SKCJm YWlsZWQgdG8gcmVzZXJ2ZSBuZXcgYWJvIGluIGVycm9yIHBhdGhcbiIpOwo+IC0JCWFtZGdwdV9m bGlwX3dvcmtfY2xlYW51cCh3b3JrKTsKPiAtCQlyZXR1cm47Cj4gLQl9Cj4gLQlhbWRncHVfZmxp cF9jbGVhbnVwX3VucGluKHdvcmssIG5ld19hYm8pOwo+IC19Cj4gLQo+IC1pbnQgYW1kZ3B1X2Ny dGNfcHJlcGFyZV9mbGlwKAo+IC0JCQkJc3RydWN0IGRybV9jcnRjICpjcnRjLAo+IC0JCQkJc3Ry dWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsCj4gLQkJCQlzdHJ1Y3QgZHJtX3BlbmRpbmdfdmJsYW5r X2V2ZW50ICpldmVudCwKPiAtCQkJCXVpbnQzMl90IHBhZ2VfZmxpcF9mbGFncywKPiAtCQkJCXVp bnQzMl90IHRhcmdldCwKPiAtCQkJCXN0cnVjdCBhbWRncHVfZmxpcF93b3JrICoqd29ya19wLAo+ IC0JCQkJc3RydWN0IGFtZGdwdV9ibyAqKm5ld19hYm9fcCkKPiAraW50IGFtZGdwdV9jcnRjX3Bh Z2VfZmxpcF90YXJnZXQoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICsJCQkJIHN0cnVjdCBkcm1f ZnJhbWVidWZmZXIgKmZiLAo+ICsJCQkJIHN0cnVjdCBkcm1fcGVuZGluZ192YmxhbmtfZXZlbnQg KmV2ZW50LAo+ICsJCQkJIHVpbnQzMl90IHBhZ2VfZmxpcF9mbGFncywgdWludDMyX3QgdGFyZ2V0 KQo+ICAgewo+ICAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5kZXY7Cj4gICAJc3Ry dWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSBkZXYtPmRldl9wcml2YXRlOwo+IEBAIC0yMDAsNyAr MTU0LDcgQEAgaW50IGFtZGdwdV9jcnRjX3ByZXBhcmVfZmxpcCgKPiAgIAl1bnNpZ25lZCBsb25n IGZsYWdzOwo+ICAgCXU2NCB0aWxpbmdfZmxhZ3M7Cj4gICAJdTY0IGJhc2U7Cj4gLQlpbnQgcjsK PiArCWludCBpLCByOwo+ICAgCj4gICAJd29yayA9IGt6YWxsb2Moc2l6ZW9mICp3b3JrLCBHRlBf S0VSTkVMKTsKPiAgIAlpZiAod29yayA9PSBOVUxMKQo+IEBAIC0yNjEsODQgKzIxNSw0MSBAQCBp bnQgYW1kZ3B1X2NydGNfcHJlcGFyZV9mbGlwKAo+ICAgCQlzcGluX3VubG9ja19pcnFyZXN0b3Jl KCZjcnRjLT5kZXYtPmV2ZW50X2xvY2ssIGZsYWdzKTsKPiAgIAkJciA9IC1FQlVTWTsKPiAgIAkJ Z290byBwZmxpcF9jbGVhbnVwOwo+IC0KPiAgIAl9Cj4gLQlzcGluX3VubG9ja19pcnFyZXN0b3Jl KCZjcnRjLT5kZXYtPmV2ZW50X2xvY2ssIGZsYWdzKTsKPiAtCj4gLQkqd29ya19wID0gd29yazsK PiAtCSpuZXdfYWJvX3AgPSBuZXdfYWJvOwo+ICAgCj4gLQlyZXR1cm4gMDsKPiAtCj4gLXBmbGlw X2NsZWFudXA6Cj4gLQlhbWRncHVfY3J0Y19jbGVhbnVwX2ZsaXBfY3R4KHdvcmssIG5ld19hYm8p Owo+IC0JcmV0dXJuIHI7Cj4gLQo+IC11bnBpbjoKPiAtCWFtZGdwdV9mbGlwX2NsZWFudXBfdW5w aW4od29yaywgbmV3X2Fibyk7Cj4gLQlyZXR1cm4gcjsKPiAtCj4gLXVucmVzZXJ2ZToKPiAtCWFt ZGdwdV9mbGlwX2NsZWFudXBfdW5yZXNlcnZlKHdvcmssIG5ld19hYm8pOwo+IC0JcmV0dXJuIHI7 Cj4gLQo+IC1jbGVhbnVwOgo+IC0JYW1kZ3B1X2ZsaXBfd29ya19jbGVhbnVwKHdvcmspOwo+IC0J cmV0dXJuIHI7Cj4gLQo+IC19Cj4gLQo+IC12b2lkIGFtZGdwdV9jcnRjX3N1Ym1pdF9mbGlwKAo+ IC0JCXN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAtCQlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpm YiwKPiAtCQlzdHJ1Y3QgYW1kZ3B1X2ZsaXBfd29yayAqd29yaywKPiAtCQlzdHJ1Y3QgYW1kZ3B1 X2JvICpuZXdfYWJvKQo+IC17Cj4gLQl1bnNpZ25lZCBsb25nIGZsYWdzOwo+IC0Jc3RydWN0IGFt ZGdwdV9jcnRjICphbWRncHVfY3J0YyA9IHRvX2FtZGdwdV9jcnRjKGNydGMpOwo+IC0KPiAtCXNw aW5fbG9ja19pcnFzYXZlKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2ssIGZsYWdzKTsKPiAgIAlhbWRn cHVfY3J0Yy0+cGZsaXBfc3RhdHVzID0gQU1ER1BVX0ZMSVBfUEVORElORzsKPiAgIAlhbWRncHVf Y3J0Yy0+cGZsaXBfd29ya3MgPSB3b3JrOwo+ICAgCj4gKwo+ICsJRFJNX0RFQlVHX0RSSVZFUigi Y3J0YzolZFslcF0sIHBmbGlwX3N0YXQ6QU1ER1BVX0ZMSVBfUEVORElORywgd29yazogJXAsXG4i LAo+ICsJCQkgYW1kZ3B1X2NydGMtPmNydGNfaWQsIGFtZGdwdV9jcnRjLCB3b3JrKTsKPiAgIAkv KiB1cGRhdGUgY3J0YyBmYiAqLwo+ICAgCWNydGMtPnByaW1hcnktPmZiID0gZmI7Cj4gICAJc3Bp bl91bmxvY2tfaXJxcmVzdG9yZSgmY3J0Yy0+ZGV2LT5ldmVudF9sb2NrLCBmbGFncyk7Cj4gLQo+ IC0JRFJNX0RFQlVHX0RSSVZFUigKPiAtCQkJImNydGM6JWRbJXBdLCBwZmxpcF9zdGF0OkFNREdQ VV9GTElQX1BFTkRJTkcsIHdvcms6ICVwLFxuIiwKPiAtCQkJYW1kZ3B1X2NydGMtPmNydGNfaWQs IGFtZGdwdV9jcnRjLCB3b3JrKTsKPiAtCj4gICAJYW1kZ3B1X2ZsaXBfd29ya19mdW5jKCZ3b3Jr LT5mbGlwX3dvcmsud29yayk7Cj4gLX0KPiArCXJldHVybiAwOwo+ICAgCj4gLWludCBhbWRncHVf Y3J0Y19wYWdlX2ZsaXBfdGFyZ2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAtCQkJICBzdHJ1 Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwKPiAtCQkJICBzdHJ1Y3QgZHJtX3BlbmRpbmdfdmJsYW5r X2V2ZW50ICpldmVudCwKPiAtCQkJICB1aW50MzJfdCBwYWdlX2ZsaXBfZmxhZ3MsCj4gLQkJCSAg dWludDMyX3QgdGFyZ2V0KQo+IC17Cj4gLQlzdHJ1Y3QgYW1kZ3B1X2JvICpuZXdfYWJvOwo+IC0J c3RydWN0IGFtZGdwdV9mbGlwX3dvcmsgKndvcms7Cj4gLQlpbnQgciA9IGFtZGdwdV9jcnRjX3By ZXBhcmVfZmxpcCgKPiAtCQkJY3J0YywKPiAtCQkJZmIsCj4gLQkJCWV2ZW50LAo+IC0JCQlwYWdl X2ZsaXBfZmxhZ3MsCj4gLQkJCXRhcmdldCwKPiAtCQkJJndvcmssCj4gLQkJCSZuZXdfYWJvKTsK PiAtCj4gLQlpZiAocikKPiAtCQlyZXR1cm4gcjsKPiAtCj4gLQlhbWRncHVfY3J0Y19zdWJtaXRf ZmxpcCgKPiAtCQkJY3J0YywKPiAtCQkJZmIsCj4gLQkJCXdvcmssCj4gLQkJCW5ld19hYm8pOwo+ ICtwZmxpcF9jbGVhbnVwOgo+ICsJaWYgKHVubGlrZWx5KGFtZGdwdV9ib19yZXNlcnZlKG5ld19h Ym8sIGZhbHNlKSAhPSAwKSkgewoKV2VsbCBoZXJlIHdlIGV4cGxpY2l0bHkgc2hvdWxkbid0IHVz ZSBhbiBpbnRlcnJ1cHRpYmxlIHdhaXQsIG90aGVyd2lzZSAKd2Ugd291bGQga2VlcCB0aGUgQk8g cGlubmVkLgoKQ2hyaXN0aWFuLgoKPiArCQlEUk1fRVJST1IoImZhaWxlZCB0byByZXNlcnZlIG5l dyBhYm8gaW4gZXJyb3IgcGF0aFxuIik7Cj4gKwkJZ290byBjbGVhbnVwOwo+ICsJfQo+ICt1bnBp bjoKPiArCWlmICh1bmxpa2VseShhbWRncHVfYm9fdW5waW4obmV3X2FibykgIT0gMCkpIHsKPiAr CQlEUk1fRVJST1IoImZhaWxlZCB0byB1bnBpbiBuZXcgYWJvIGluIGVycm9yIHBhdGhcbiIpOwo+ ICsJfQo+ICt1bnJlc2VydmU6Cj4gKwlhbWRncHVfYm9fdW5yZXNlcnZlKG5ld19hYm8pOwo+ICAg Cj4gLQlyZXR1cm4gMDsKPiArY2xlYW51cDoKPiArCWFtZGdwdV9ib191bnJlZigmd29yay0+b2xk X2Fibyk7Cj4gKwlmZW5jZV9wdXQod29yay0+ZXhjbCk7Cj4gKwlmb3IgKGkgPSAwOyBpIDwgd29y ay0+c2hhcmVkX2NvdW50OyArK2kpCj4gKwkJZmVuY2VfcHV0KHdvcmstPnNoYXJlZFtpXSk7Cj4g KwlrZnJlZSh3b3JrLT5zaGFyZWQpOwo+ICsJa2ZyZWUod29yayk7Cj4gKwo+ICsJcmV0dXJuIHI7 Cj4gICB9Cj4gICAKPiAgIGludCBhbWRncHVfY3J0Y19zZXRfY29uZmlnKHN0cnVjdCBkcm1fbW9k ZV9zZXQgKnNldCkKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X21vZGUuaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9tb2RlLmgKPiBp bmRleCBiZTNlOGQ2Njk1NWUuLjkzNjJhMDRlYWE1OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfbW9kZS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X21vZGUuaAo+IEBAIC03MDIsMjMgKzcwMiw2IEBAIGludCBhbWRncHVf Y3J0Y19wYWdlX2ZsaXBfdGFyZ2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgIAkJCQkgc3Ry dWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsCj4gICAJCQkJIHN0cnVjdCBkcm1fcGVuZGluZ192Ymxh bmtfZXZlbnQgKmV2ZW50LAo+ICAgCQkJCSB1aW50MzJfdCBwYWdlX2ZsaXBfZmxhZ3MsIHVpbnQz Ml90IHRhcmdldCk7Cj4gLXZvaWQgYW1kZ3B1X2NydGNfY2xlYW51cF9mbGlwX2N0eCgKPiAtCQlz dHJ1Y3QgYW1kZ3B1X2ZsaXBfd29yayAqd29yaywKPiAtCQlzdHJ1Y3QgYW1kZ3B1X2JvICpuZXdf YWJvKTsKPiAtaW50IGFtZGdwdV9jcnRjX3ByZXBhcmVfZmxpcChzdHJ1Y3QgZHJtX2NydGMgKmNy dGMsCj4gLQkJCSAgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsCj4gLQkJCSAgc3RydWN0IGRy bV9wZW5kaW5nX3ZibGFua19ldmVudCAqZXZlbnQsCj4gLQkJCSAgdWludDMyX3QgcGFnZV9mbGlw X2ZsYWdzLAo+IC0JCQkgIHVpbnQzMl90IHRhcmdldCwKPiAtCQkJICBzdHJ1Y3QgYW1kZ3B1X2Zs aXBfd29yayAqKndvcmssCj4gLQkJCSAgc3RydWN0IGFtZGdwdV9ibyAqKm5ld19hYm8pOwo+IC0K PiAtdm9pZCBhbWRncHVfY3J0Y19zdWJtaXRfZmxpcCgKPiAtCQlzdHJ1Y3QgZHJtX2NydGMgKmNy dGMsCj4gLQkJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsCj4gLQkJc3RydWN0IGFtZGdwdV9m bGlwX3dvcmsgKndvcmssCj4gLQkJc3RydWN0IGFtZGdwdV9ibyAqbmV3X2Fibyk7Cj4gLQo+ICAg ZXh0ZXJuIGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9jb25maWdfZnVuY3MgYW1kZ3B1X21vZGVfZnVu Y3M7Cj4gICAKPiAgICNlbmRpZgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1k LWdmeAo=