Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C629C433F5 for ; Tue, 15 Mar 2022 10:59:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 220F883BAF; Tue, 15 Mar 2022 11:59:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="DyAJ/88h"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 83FD583BCA; Tue, 15 Mar 2022 11:59:41 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9672A839AC for ; Tue, 15 Mar 2022 11:59:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1647341976; bh=4cihM0spv/Fr9KSAkAel32v9AHNKteD5wYy5hE3CorM=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=DyAJ/88hKmsLL5a92aw7PstJ1vNoOHG/Sg6yUDrrQoqmFpe4Jsyk1csXolja2zZRi 1vCvlJpC5lo+/PATBASSsWesQNy6a1uxB6iSHBOUsaL0PFU34PF0IDc/TGpy4qs75P ub8YJyva7rDyK4lIHxVFE+LBUVod8adV9MhD3Wtw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.67] ([88.152.144.107]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MOzOw-1nkVJk00gm-00PKws; Tue, 15 Mar 2022 11:59:36 +0100 Message-ID: <4e9fc3e6-3ac8-63db-e709-f9017d130ea0@gmx.de> Date: Tue, 15 Mar 2022 11:59:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] doc: board: raspberrypi: Add documentation Content-Language: en-US To: matthias.bgg@kernel.org Cc: Fabio Estevam , Bin Meng , Neil Armstrong , U-Boot Mailing List , Matthias Brugger , Simon Glass References: <20220314110354.3392-1-matthias.bgg@kernel.org> From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:DlyoHGdt/wwzQVPEjSa1U6uIqTUoMw4hes0PE7++JvDwEGqfjIm YvflyXb1wY4+hCQSl1EyhV92VAzoBxNicV8exYCYRBGUKXVXAn7WzW7nmGpPtHUb4r9TjtD mcQYLh2KRsYfD6SCQrs41QEtc84qL8U2Q3M+tL7wJyIkbBRBh5yD66WG6ai6xukufv6Y9US 1w+czLKRJ36KnZhIw31Xw== X-UI-Out-Filterresults: notjunk:1;V03:K0:1CZDaZyzyco=:pJSB3il/lJI3dO3H1OyV77 E28cN8c22xh5dtbknTxU24gIuqUa0hKJxpf5c0hPHRd0U02JOIk2Amw9DRrvioQzPKHc/1lsQ smJxp5PyQBcjJOujEVZ/nq6ZOxoAQgHoH1nTdGlohRuIfh3x/ozx/gTQoL+dDcx85pATtmjT6 uN7L1YkSazxs75Wfnv1soG6w8VamnBgVc89e+irIKJKJ2GK+uz2Ah4ORoKMmEMhSnj/KIgKaV JXiZYdOjEt0bJ7dl0xJCdcd0Rm2MCvEiwMgPguowTkVZEI90eHj5TckXxFxVNlmnhPH8eesCc 5JoTaHJkzhzOkW8zG2QJ415VCmfGsRVIqj4q80PBF8SA8KZz5/6In1NxvTbV+K7C5+KgIakII YFgANM97daRon6ZrYY2Ql4nOYnAIRyRLQhSv0OYTaV6oHb8jZIghsUOv6YvU/dbNtCxAySwJd kVTtsIJ33WVZbmQxY60gv+Q0ogxoOB+gHuErLw+oubLbQcXvDmqW2/DRpbBB9l+fairk/L5zd hW04LPYWk756dGFrWN3BPmtzz47Wt2UuCht7TfOlsDC8lyltKtdCorIQmR8DGXzXKDktmXYei aXTf8Zeb/ZO+Jq4pCVEJHN728oUy7Y9hxwNh0S+QI5ydZtR3qKGWpd8x1FXz9TkvL4h6jekk8 nziLtSx5RrnIbn/FRstOw0CFS0QSM9ZJFv/szPaRMd9aUAfHr9XjbHu9jkSCHTVJRDTYs17HW r6ogY0Vxl0oStD7xaxM35ZkFKHAZoudDToZ10GOHxJNce0SN8FwKnWjzZ5kbArC1XQazkXXrm T370MdB+btZTlxppTALJbQuUPIM0GCtObmXm0s+PPrD58gSPUeEQe472DvxpKoTDED91zJMGc +zNA29a72HBhKmBC5YRghw44+SE3T3p0EGc6P8iBH/CcMAe5YdLCxglRuX4lv5nlZipC41vF5 fYaowvu5zMi4MMmHlwpHQ/ZVhuR9eEYXPmQRQAdNMyCw/l9LTIYZFiEyLq2UutOzAksMKWzfR kAPKBWSLUgKJ7JMt1ycd2l5H5EaWq/nB3930tfi4Y8OURMWgXw3Rh+Hyrp1ci7qJX6gmOGJtv 5KYQBCeNyPJjr0= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/14/22 19:24, Simon Glass wrote: > Hi Matthias, > > On Mon, 14 Mar 2022 at 05:04, wrote: >> >> From: Matthias Brugger >> >> Add documentation about the different configuration files for the >> RaspberryPi board family. >> >> Signed-off-by: Matthias Brugger >> --- >> doc/board/raspberrypi/index.rst | 10 +++++ >> doc/board/raspberrypi/raspberrypi.rst | 53 ++++++++++++++++++++++++++= + Thanks for writing this up. An entry in doc/board/index.rst is missing. >> 2 files changed, 63 insertions(+) >> create mode 100644 doc/board/raspberrypi/index.rst >> create mode 100644 doc/board/raspberrypi/raspberrypi.rst > > Reviewed-by: Simon Glass > > nit below > >> >> diff --git a/doc/board/raspberrypi/index.rst b/doc/board/raspberrypi/in= dex.rst >> new file mode 100644 >> index 0000000000..7a283d81af >> --- /dev/null >> +++ b/doc/board/raspberrypi/index.rst >> @@ -0,0 +1,10 @@ >> +.. SPDX-License-Identifier: GPL-2.0+ >> +.. Copyright (C) 2022 Matthias Brugger >> + >> +Raspberry Pi >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D All other boards have: vendor/index.rst vendor/board1.rst vendor/board2.rst I suggest to let this file refer to Broadcom Inc SoC based devices in general. Best regards Heinrich >> + >> +.. toctree:: >> + :maxdepth: 2 >> + >> + raspberrypi >> diff --git a/doc/board/raspberrypi/raspberrypi.rst b/doc/board/raspberr= ypi/raspberrypi.rst >> new file mode 100644 >> index 0000000000..219a780e15 >> --- /dev/null >> +++ b/doc/board/raspberrypi/raspberrypi.rst >> @@ -0,0 +1,53 @@ >> +.. SPDX-License-Identifier: GPL-2.0+ >> +.. Copyright (C) 2022 Matthias Brugger >> + >> +RASPBERRY PI > > Better to use lower case? > >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> + >> +About this >> +---------- >> + >> +This document describes the information about Raspberry PI boards >> +and it's usage steps. >> + >> +Raspberry Pi boards >> +------------------- >> + >> +List of mainline supported Rasbperry Pi boards through the following c= onfigs: >> + >> +32-bits: >> +^^^^^^^^ >> + >> +* rpi_defconfig >> + - Raspberry Pi >> +* rpi_0_w_defconfig >> + - Raspberry Pi 1 >> + - Raspberry Pi zero >> +* rpi_2_defconfig >> + - Raspberry Pi 2 >> +* rpi_3_32b_defconfig >> + - Raspberry Pi 3b >> +* rpi_4_32b_defconfig >> + - Raspberry Pi 4b >> + >> +64-bits: >> +^^^^^^^^ >> + >> +* rpi_3_defconfig >> + - Raspberry Pi 3b >> +* rpi_3_b_plus_defconfig >> + - Raspberry Pi 3b+ >> +* rpi_4_defconfig >> + - Raspberry Pi 4b >> +* rpi_arm64_defconfig >> + - Raspberry Pi 3b >> + - Raspberry Pi 3b+ >> + - Raspberry Pi 4b >> + - Raspberry Pi 400 >> + - Raspberry Pi CM 3 >> + - Raspberry Pi CM 3+ >> + - Raspberry Pi CM 4 >> + - Raspberry Pi zero 2 w >> + >> +Config rpi_arm64_defconfig uses the DTB proviede by the firmware inste= ad of using the embedded one. It allows to actually boot the same U-Boot b= inary of different boards. > > provided > > how about 'It allows booting the same' ? > >> + >> -- >> 2.34.1 >> > > Regards, > Simon