From: "mattock (Code Review)" Date: Sat, 24 May 2025 04:12:39 +0000 In-Reply-To: References: Reply-To: sasepp@...2783..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <4ec6dab4795a20a9eb63810e3db77a0b400d2a97-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="rty8iC3KVKs="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: t_server_null: print error when server startup fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , plaisthos , openvpn-devel --rty8iC3KVKs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos. mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/o= penvpn/+/1024?usp=3Demail ) Change subject: t_server_null: print error when server startup fails ...................................................................... Patch Set 1: (1 comment) File tests/t_server_null_server.sh: http://gerrit.openvpn.net/c/openvpn/+/1024/comment/70edd46b_0e03789c : PS1, Line 27: # we run OpenVPN without --daemon and --log to catch the = underlying error. > This is correct, if cli parsing fails before logging is changed, you'll o= nly see stdout/stderr [=E2=80=A6] I tested adding --log. And in case of OpenVPN startup failure we would get = the error in the log. I used a duplicate management port in second server (= 11194 -> 11195) as a test specimen: "2025-05-24 07:04:19 MANAGEMENT: Socket bind failed on local address [AF_IN= ET]127.0.0.1:11194: Address already in use (errno=3D98)" So we can either do "--log" and then tail the log, or we can just not do --= log. The latter seems to be slightly more reliable as far as "getting all t= he output you might need"? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1024?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I39dc6b08952a06dae7901e468f9487c8541d83c3 Gerrit-Change-Number: 1024 Gerrit-PatchSet: 1 Gerrit-Owner: mattock Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Sat, 24 May 2025 04:12:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Comment-In-Reply-To: flichtenheld Comment-In-Reply-To: mattock Gerrit-MessageType: comment --rty8iC3KVKs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos. <= /p>

View = Change

1 comment:

    =
  • File tests/t_server_null_server.sh:=

    • Patch Set #1, Lin= e 27: # we run Open= VPN without --daemon and --log to catch the underlying error.

      =

      This is correct, if cli parsing fails before logging is changed, y= ou'll only see stdout/stderr [=E2=80=A6]

      I tested adding --log. And in = case of OpenVPN startup failure we would get the error in the log. I used a= duplicate management port in second server (11194 -> 11195) as a test s= pecimen:

      &quo= t;2025-05-24 07:04:19 MANAGEMENT: Socket bind failed on local address [AF_I= NET]127.0.0.1:11194: Address already in use (errno=3D98)"

      So we can either do &quo= t;--log" and then tail the log, or we can just not do --log. The latte= r seems to be slightly more reliable as far as "getting all the output= you might need"?

To view, visit change 1024. To= unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I39dc6b08952a06dae7901e468f9= 487c8541d83c3
Gerrit-Change-Number: 1024
Gerrit-PatchSet: 1
Gerrit-Owner: mattock <sasepp@...2783...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Sat, 24 May 2025 04:12:39= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Comment-In-Reply-To: mattock <sasepp@...2283...= 3...>
Gerrit-MessageType: comment
--rty8iC3KVKs=--