From: "cron2 (Code Review)"
Date: Wed, 2 Apr 2025 13:20:39 +0000
In-Reply-To:
References:
Reply-To: gert@...1296..., arne-openvpn@...1227...,
gianmarco@...2726..., openvpn-devel@lists.sourceforge.net,
frank@...2641...
Message-ID: <4ee29fd67fdb50bc583826ea697d8e666d4a99e1-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="JpkYWqPI2w0="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Fix FreeBSD-DCO and
Multisocket interaction
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: its_Giaan
Cc: plaisthos , flichtenheld , openvpn-devel
--JpkYWqPI2w0=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/925?usp=3Demail )
Change subject: Fix FreeBSD-DCO and Multisocket interaction
......................................................................
Patch Set 1: Code-Review+2
(3 comments)
Patchset:
PS1:
seems windows does not need it (because we currently support only 1 socket =
for server && DCO, so the 1 socket-check works) - so let's proceed this.
File src/openvpn/dco.c:
http://gerrit.openvpn.net/c/openvpn/+/925/comment/b1c9e52b_61c0c566 :
PS1, Line 263: if (ce->local_list)
> will this also catch clients that have no `--local` at all, just `--remot=
e ... [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/925/comment/b50916b0_8d184b77 :
PS1, Line 277: if (!proto_is_udp(ce->proto) && mode =3D=3D MODE_SERVER)
> this looks as if we need the fix for windows too... [=E2=80=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/925?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9b6359076a61ae2bbb8e5cea00e33969cb5f92cf
Gerrit-Change-Number: 925
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: its_Giaan
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Wed, 02 Apr 2025 13:20:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--JpkYWqPI2w0=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, its_Giaan, plaistho=
s.
Patch set 1:Code-Review +2=
Vi=
ew Change
3 comments:
Patchset:
File src/openvpn/dco.c:
Patch Set #1, Line 263: if (ce->local_list)
will this also catch clients that have no `--local` at all, just `--re=
mote ... [=E2=80=A6]
Done
Patch Set #1, Line 277: if (!proto_is_udp(ce->pr=
oto) && mode =3D=3D MODE_SERVER)
this looks a=
s if we need the fix for windows too... [=E2=80=A6]
Done
=
To view, visit change 925. To unsubscribe, or for help writing mail filt=
ers, visit settings.
=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9b6359076a61ae2bbb8e5cea00e=
33969cb5f92cf
Gerrit-Change-Number: 925
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gianmarco@...2786...=
..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...=
726...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Wed, 02 Apr 2025 13:20:39=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Gerrit-MessageType: comment
--JpkYWqPI2w0=--