Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=eajames@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48sxMn6309zDqRf for ; Thu, 2 Apr 2020 06:39:00 +1100 (AEDT) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 031JXUCd126813; Wed, 1 Apr 2020 15:38:57 -0400 Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com with ESMTP id 304r500p01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Apr 2020 15:38:57 -0400 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 031JaCiI030165; Wed, 1 Apr 2020 19:38:56 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma05wdc.us.ibm.com with ESMTP id 301x773b8t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Apr 2020 19:38:56 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 031Jct2l48693534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 1 Apr 2020 19:38:55 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5EE4F6A057; Wed, 1 Apr 2020 19:38:55 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 304726A04D; Wed, 1 Apr 2020 19:38:55 +0000 (GMT) Received: from [9.163.16.235] (unknown [9.163.16.235]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 1 Apr 2020 19:38:55 +0000 (GMT) Subject: Re: [PATCH linux dev-5.4] ARM: dts: Aspeed: Tacoma: Add iio-hwmon nodes for IIO devices From: Eddie James To: Joel Stanley Cc: OpenBMC Maillist References: <20200330211430.13064-1-eajames@linux.ibm.com> <699bee76-27fa-c3ec-128e-e58b66505234@linux.ibm.com> Message-ID: <4f2afaa3-aee2-8034-7536-7e53418856d0@linux.ibm.com> Date: Wed, 1 Apr 2020 14:38:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <699bee76-27fa-c3ec-128e-e58b66505234@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-01_04:2020-03-31, 2020-04-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 suspectscore=0 mlxscore=0 malwarescore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004010160 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 19:39:02 -0000 On 4/1/20 1:57 PM, Eddie James wrote: > > On 3/30/20 4:36 PM, Joel Stanley wrote: >> On Mon, 30 Mar 2020 at 21:14, Eddie James wrote: >>> Connect the BMP280 and DPS310 to the hwmon subsystem with iio-hwmon >>> nodes. >> The BMP280 was on pre-production witherspoons. I imagine most of the >> ones we're using have dps310. Can we drop the bmp280 support? > > > Yes, sent a new patch for that, so this one can be abandoned. Nevermind... This one is better, because the device is physically there on all the Tacomas I've checked. It's also present in the regular old Witherspoon devicetree. > > > Thanks, > > Eddie > > >> >> Cheers, >> >> Joel >> >>> Signed-off-by: Eddie James >>> --- >>>   arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 10 ++++++++++ >>>   1 file changed, 10 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts >>> b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts >>> index ff49ec76fa7c..374512a83f33 100644 >>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts >>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts >>> @@ -89,6 +89,16 @@ >>>                          linux,code = <7>; >>>                  }; >>>          }; >>> + >>> +       iio-hwmon-dps310 { >>> +               compatible = "iio-hwmon"; >>> +               io-channels = <&dps 0>; >>> +       }; >>> + >>> +       iio-hwmon-bmp280 { >>> +               compatible = "iio-hwmon"; >>> +               io-channels = <&bmp 1>; >>> +       }; >>>   }; >>> >>>   &fmc { >>> -- >>> 2.24.0 >>>