Received: by 2002:a5d:6089:0:0:0:0:0 with SMTP id w9csp2817073wrt; Mon, 14 Jan 2019 01:00:55 -0800 (PST) X-Google-Smtp-Source: ALg8bN652Knr1Od6I1qIf0/VzA3ZcjssLGe9D88Ji60cjjMacq4E8GgP2ku2ee8L38e5kSGnhkHu X-Received: by 2002:a7b:c7c7:: with SMTP id z7mr11623215wmk.74.1547456455795; Mon, 14 Jan 2019 01:00:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547456455; cv=none; d=google.com; s=arc-20160816; b=UpCiOYuISd83gHkVm+Bk7keKAqVZcny0WOVVhS2Sd3gWK76OspinvtK/OblsRa42Ky nRaUI4InOt2XrPYNwUBNk42q4Am2aQdXyb2GR2/NHn+rCEfILB9MkObu/PpnTPoDVl/W r5XzhcWMML+GDXp6a/dIz8PVpy+dLmaXw3t1pOieyUrb9LlGaStEg8o/Y9219pAdcNIb HTRuh2jrSvp9Mteg5J55+S2PNXJllYDFf1o8mw8UaiDPm0mKfsU4IMHhdkZJRXiUh2UW TG+SlAoMr21jTb9b8E2heI8srhicTBXyuDEJtFfXIMMaqWuYfmzyPHkr0y0Spyxx4vL9 V8nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:autocrypt:openpgp:from :references:to; bh=veAnhg94rYDJpeJDXLRsrBctfzOYaD3BBljCx2Fr9r8=; b=d9+IrOC2F7HK2vA/qUQCQLKZRilvPtOt3z0dRm8MVf5+N3moQJfX8ImWbh3Odl5PDG bpa6SGHvqjlQ8rHd49PVS4qk/n1y2bypjjOGLSmOclVtpbh2+Jo/3RJwXEHiSAMZd3Ra TnK9IWAuDl8YETW67OPF4wDLUC+KYHfhFuQCkBEVTxq7jBIP2iaDSoAs5pdU2XUOIX+o du2F1hjbn5clGX2LNbsx51H1qF//t0nnaG1YRZ6Oi43y8m9CDzW+pORlfgCyCEi7hTEW qXHwUfc9jsv1mEhQ6Ydi12gsukaea1zawck5NfFXogc2DsnccIZ0ZrrtXLxrH/j51+9b gu8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m2si11690258wme.142.2019.01.14.01.00.55 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 14 Jan 2019 01:00:55 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([127.0.0.1]:44837 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giy74-0002Vp-Nm for alex.bennee@linaro.org; Mon, 14 Jan 2019 04:00:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giy6v-0002Vi-Hq for qemu-arm@nongnu.org; Mon, 14 Jan 2019 04:00:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giy6p-0008QR-OX for qemu-arm@nongnu.org; Mon, 14 Jan 2019 04:00:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46484) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1giy6p-0008P9-Fo; Mon, 14 Jan 2019 04:00:39 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D349D7AEB2; Mon, 14 Jan 2019 09:00:37 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-190.ams2.redhat.com [10.36.116.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5EB36014F; Mon, 14 Jan 2019 08:59:54 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paolo Bonzini , qemu-devel@nongnu.org References: <20190111140857.4211-1-philmd@redhat.com> <20190111140857.4211-13-philmd@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: <4f2bc8e2-de3b-aaac-bc4a-e3f3b013b44e@redhat.com> Date: Mon, 14 Jan 2019 09:59:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190111140857.4211-13-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 14 Jan 2019 09:00:38 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [PATCH 12/15] ui/console: Remove MouseTransformInfo from qemu/typedefs.h X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Xiao Guangrong , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-arm@nongnu.org, Gerd Hoffmann , Marcel Apfelbaum , Igor Mammedov , Laszlo Ersek Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: F4Row+ZnWKb2 On 2019-01-11 15:08, Philippe Mathieu-Daud=C3=A9 wrote: > MouseTransformInfo is only used in "ui/console.h", there is no > need to expose it via "qemu/typedefs.h". You also touch devices.h here ... that should be mentioned, too? Thomas > Move the declaration to "ui/console.h" (removing the forward > declaration). >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > include/hw/devices.h | 1 + > include/qemu/typedefs.h | 1 - > include/ui/console.h | 4 ++-- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/include/hw/devices.h b/include/hw/devices.h > index 0e27feb0c2..b5f1662225 100644 > --- a/include/hw/devices.h > +++ b/include/hw/devices.h > @@ -4,6 +4,7 @@ > /* Devices that have nowhere better to go. */ > =20 > #include "hw/hw.h" > +#include "ui/console.h" > =20 > /* smc91c111.c */ > void smc91c111_init(NICInfo *, uint32_t, qemu_irq); > diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h > index 9baebe9d33..e44f1473a5 100644 > --- a/include/qemu/typedefs.h > +++ b/include/qemu/typedefs.h > @@ -49,7 +49,6 @@ typedef struct MigrationIncomingState MigrationIncomi= ngState; > typedef struct MigrationState MigrationState; > typedef struct Monitor Monitor; > typedef struct MonitorDef MonitorDef; > -typedef struct MouseTransformInfo MouseTransformInfo; > typedef struct MSIMessage MSIMessage; > typedef struct NetClientState NetClientState; > typedef struct NetFilterState NetFilterState; > diff --git a/include/ui/console.h b/include/ui/console.h > index 853fcf4eb7..b74246f0f5 100644 > --- a/include/ui/console.h > +++ b/include/ui/console.h > @@ -65,13 +65,13 @@ void qemu_remove_led_event_handler(QEMUPutLEDEntry = *entry); > =20 > void kbd_put_ledstate(int ledstate); > =20 > -struct MouseTransformInfo { > +typedef struct MouseTransformInfo { > /* Touchscreen resolution */ > int x; > int y; > /* Calibration values as used/generated by tslib */ > int a[7]; > -}; > +} MouseTransformInfo; > =20 > void hmp_mouse_set(Monitor *mon, const QDict *qdict); > =20 >=20