From: Mukesh Ojha Subject: Re: [PATCH] sound: codecs: fix a potential NULL pointer dereference Date: Mon, 25 Mar 2019 12:15:20 +0530 Message-ID: <4fa0e2cb-7044-12e1-33b3-14015c94e48d@codeaurora.org> References: <20190324231237.2246-1-kjlu@umn.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190324231237.2246-1-kjlu@umn.edu> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Kangjie Lu Cc: pakki001@umn.edu, Bard Liao , Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On 3/25/2019 4:42 AM, Kangjie Lu wrote: > In case devm_kzalloc fails, the patch returns -ENOMEM to avoid > potential NULL pointer dereference. > > Signed-off-by: Kangjie Lu > --- > sound/soc/codecs/rt5663.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/codecs/rt5663.c b/sound/soc/codecs/rt5663.c > index da6647015708..909ab99a1995 100644 > --- a/sound/soc/codecs/rt5663.c > +++ b/sound/soc/codecs/rt5663.c > @@ -3480,6 +3480,8 @@ static int rt5663_parse_dp(struct rt5663_priv *rt5663, struct device *dev) > table_size = sizeof(struct impedance_mapping_table) * > rt5663->pdata.impedance_sensing_num; > rt5663->imp_table = devm_kzalloc(dev, table_size, GFP_KERNEL); > + if (!rt5663->imp_table) > + return -ENOMEM; add checks in rt5663_parse_dp  as well. Thanks. Mukesh > device_property_read_u32_array(dev, > "realtek,impedance_sensing_table", > (u32 *)rt5663->imp_table, table_size);