Return-Path: Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2085.outbound.protection.outlook.com [40.107.236.85]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1831310F5F1 for ; Wed, 27 Apr 2022 15:38:06 +0000 (UTC) Message-ID: <4fe46aba-99e5-218b-4bab-d19e4346dc84@amd.com> Date: Wed, 27 Apr 2022 11:38:01 -0400 Content-Language: en-US To: Alex Hung , igt-dev@lists.freedesktop.org, bas@basnieuwenhuizen.nl References: <20220419022929.1771545-1-alex.hung@amd.com> From: Rodrigo Siqueira Jordao In-Reply-To: <20220419022929.1771545-1-alex.hung@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t-][V3] tests/kms: Skip kms test cases for DCC and DCC_RETILE List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: markyacoub@google.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 2022-04-18 22:29, Alex Hung wrote: > Skip the KMS test cases for planes that has modifiers with > DCC and DCC_RETILE on AMDGPU. > > Current pixel-format and pixel-format-source-clamping subtests do not > support modifers with DCC or DCC_RETILE in kernel. > > 1. dcc_formats's cpp[1] is set to 0 and this triggers kernel errors > "Format requires non-linear modifier for plane 1" because block_size > (i.e. cpp[1]) == 0. See kernel commits 816853f9dc40 and 8db2dc852941. > > 2. the subtests cause kernel's amdgpu_display_verify_sizes to fail > because they do not provide an extra plane with compression metadata. > See kernel commit 234055fd9728 for details. > > Signed-off-by: Alex Hung > --- > > v2: update comments in commit messages > v3: add AMD MOD check > > tests/kms_plane.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/tests/kms_plane.c b/tests/kms_plane.c > index 137f23a8..b1be44c3 100644 > --- a/tests/kms_plane.c > +++ b/tests/kms_plane.c > @@ -1003,6 +1003,16 @@ static bool test_format_plane(data_t *data, enum pipe pipe, > static bool skip_plane(data_t *data, igt_plane_t *plane) > { > int index = plane->index; > + int i; > + > + for (i = 0; i < plane->format_mod_count; i++) { > + if (IS_AMD_FMT_MOD(plane->modifiers[i]) && > + (AMD_FMT_MOD_GET(DCC, plane->modifiers[i]) || > + AMD_FMT_MOD_GET(DCC_RETILE, plane->modifiers[i]))) { > + igt_debug("Skipping planes with DCC or DCC_RETILE\n"); > + return true; > + } > + } > > if (data->extended) > return false; It lgtm, Acked-by: Rodrigo Siqueira