Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lFAYJ-0006ts-IH for mharc-grub-devel@gnu.org; Thu, 25 Feb 2021 01:55:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFAYI-0006ti-6J for grub-devel@gnu.org; Thu, 25 Feb 2021 01:55:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:43517) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lFAYE-0005xx-Fp for grub-devel@gnu.org; Thu, 25 Feb 2021 01:55:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614236105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pLNLmAscJfAD5oV1WNGoCIIaJQ9DwJEAeJacaXdYEa8=; b=SXW9enUi51D4XS/P33kxY5HrTWLUT1KviUoaTO60RsRw4EuKoWOjb4QzYLTWQxwh3ZfdO9 KUkCOh7u6ax3pEgTRhqN+5V2m+nS+UR523k/Sg6OeMmFD9fk2KoQBHmrCEhheXeIz2gwEM u/XxnIPQdCkwQv4wsJ2hgCkExuOarAI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-rmBf6Ut0N-yl_-R50zmv-g-1; Thu, 25 Feb 2021 01:53:00 -0500 X-MC-Unique: rmBf6Ut0N-yl_-R50zmv-g-1 Received: by mail-wm1-f71.google.com with SMTP id u15so1417790wmj.2 for ; Wed, 24 Feb 2021 22:53:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to; bh=u+5JBcG+i1QzoCnmULQfPAlAX9jiR59hP1zhFqIAj1Q=; b=DJJMUtyjYU/dN4Ghjs4n+lGBhwIfSV1BRKTxMSIHQp7w28UKuw3qeHsSkmwTAYYVFa 94gZ8qVvsq4ySyfHRbK5rCqYU3SAhkh70gXYwB4//PU1D+at8Mv3dRl43YhR4VvQN2fV exUvkBsMp2p6He3VpLt+b18pwhFtKh5zwpztD14auYAwcTq72jwfYn/Gcl9DR7OTdxsI VtSYmXcnzlDdUq6UZcJ2Sdp3NY9F0m3YzcsOI6065AJ7LA1zI4RWCbjB6mfOxgcGRo1a 4LFUw8YxXy4IW7snshcpZxNoAddqWeD0L85k5U6cPLiQCma2ulHUA1fWB3VoSqDQuICZ mruQ== X-Gm-Message-State: AOAM532px63n0+ykd6YSl8AGcByXtb2lf51MjrVNrN+fuYw13xAse2va 9oVmtECLXx3XjUFhyGm60fmcxicLfehoe00p7/Jrqu/CZDPfS+JzICMqa+VcrkiccKC70lrCIDx KtB+sdSJ2Gbs= X-Received: by 2002:a1c:e046:: with SMTP id x67mr1640329wmg.165.1614235979563; Wed, 24 Feb 2021 22:52:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnguZDF9AJNIGl+CGMh6ePJRElkOK5nfWnG3vLkIxQOU5uWwv0UYxnOjh45C5jSbS0NWNtRA== X-Received: by 2002:a1c:e046:: with SMTP id x67mr1640317wmg.165.1614235979350; Wed, 24 Feb 2021 22:52:59 -0800 (PST) Received: from [192.168.1.40] (82-64-217-13.subs.proxad.net. [82.64.217.13]) by smtp.gmail.com with ESMTPSA id 36sm8189203wrj.97.2021.02.24.22.52.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Feb 2021 22:52:58 -0800 (PST) Subject: Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes From: =?UTF-8?Q?Renaud_M=c3=a9trich?= To: grub-devel@gnu.org Cc: Javier Martinez Canillas References: <20201106134816.1202249-1-javierm@redhat.com> <8546ac2a-2a89-9fc2-3f6e-2aa27b56267f@redhat.com> <7c38b67b-800e-5072-3b4a-994dd944b9eb@redhat.com> Message-ID: <5002cb63-3ace-4ac9-9883-e2b570d75a5a@redhat.com> Date: Thu, 25 Feb 2021 07:52:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <7c38b67b-800e-5072-3b4a-994dd944b9eb@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rmetrich@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fjng5G4iSjWn5fK87LJ7bbNuPJW3Oof3Z" Received-SPF: pass client-ip=63.128.21.124; envelope-from=rmetrich@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 20 X-Spam_score: 2.0 X-Spam_bar: ++ X-Spam_report: (2.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RAZOR2_CF_RANGE_51_100=1.886, RAZOR2_CHECK=0.922, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URI_DOTEDU=1.999 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Feb 2021 06:55:10 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fjng5G4iSjWn5fK87LJ7bbNuPJW3Oof3Z Content-Type: multipart/mixed; boundary="mCFI9CFuo1UAx4NARk8ubuIxw0fD96xUn"; protected-headers="v1" From: =?UTF-8?Q?Renaud_M=c3=a9trich?= To: grub-devel@gnu.org Cc: Javier Martinez Canillas Message-ID: <5002cb63-3ace-4ac9-9883-e2b570d75a5a@redhat.com> Subject: Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes References: <20201106134816.1202249-1-javierm@redhat.com> <8546ac2a-2a89-9fc2-3f6e-2aa27b56267f@redhat.com> <7c38b67b-800e-5072-3b4a-994dd944b9eb@redhat.com> In-Reply-To: <7c38b67b-800e-5072-3b4a-994dd944b9eb@redhat.com> --mCFI9CFuo1UAx4NARk8ubuIxw0fD96xUn Content-Type: multipart/mixed; boundary="------------D24F0FD51112EB73E4FBAAB5" Content-Language: fr-FR This is a multi-part message in MIME format. --------------D24F0FD51112EB73E4FBAAB5 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hello, Please find an updated version of the patch proposing a fallback=20 mechanism in case grub is not able to detect the set to be used. I has been tested on the following systems: - Lenovo P71 - Asus N53SN - Dell Precision - HP Elitebook - Lenovo T460s - QEMU/KVM - HP G5430 On all these above, the fallback mechanism is not used at all, set is=20 detected correctly. However the mechanism is necessary for HP DL380p Gen 8 systems. Renaud. On 1/8/21 3:00 PM, Renaud M=C3=A9trich wrote: > Hello, > > It appears that the proposal works fine on all systems I could test=20 > except one: a HP DL380p Gen 8. > > On that system, querying the set fails: the ACK bytes in write_mode(0)=20 > work perfectly, but then 0xFE ("NACK") is read, as if the keyboard=20 > didn't want to send back the set in use. > > Hence, query_mode() returns 0, causing set1 to be used, but=20 > unfortunately the system expects set2 to be used. > > I tried using the "resend" command, but nothing helps. > > I'm hence proposing a fallback solution for this kind of hardware=20 > where the admin can add a "at_keyboard_fallback_set" environment=20 > variable in grub.cfg that would end using a specific set if=20 > query_mode() fails. > > See proposed patch in attachment. > > Renaud. > > On 12/14/20 5:47 PM, Renaud M=C3=A9trich wrote: >> Hi Vladimir, >> >> Thanks for the hint, this was obvious now. >> >> Please find attached the new patch which definitely fixes the issue. >> >> It has been tested on various hardware (see git commit details). >> >> In a nutshell the solution is to stick to set 1 if controller is in=20 >> Translate mode, and use set X otherwise, X being the queried mode. >> >> Additionally, in controller_fini, nothing has to be restored, since=20 >> nothing was changed. This fixes an issue when switching between=20 >> at_keyboard, console, and at_keyboard again, in case queried set is=20 >> not the actual used set. >> >> Renaud. >> >> On 12/11/20 3:08 PM, Vladimir 'phcoder' Serbinenko wrote: >>> On Fri, Dec 4, 2020 at 5:53 AM Renaud M=C3=A9trich =20 >>> wrote: >>>> Hi, >>>> >>>> Testing the proposed patch on my old Asus N53SN in Legacy failed:=20 >>>> as soon as at_keyboard is selected, the keys are corrupted and it's=20 >>>> impossible to do anything. >>>> >>>> Digging into this, it appears that query_mode() returns 2 (so set2=20 >>>> needs to be used), but in fact internally the keycode are the ones=20 >>>> expected by set1. >>> This is because the patch doesn't take into account that controller is >>> in "translate" mode. >>> @Javier Martinez Canillas : Can you make your patch check whether >>> KEYBOARD_AT_TRANSLATE is set ? >>> >>> _______________________________________________ >>> Grub-devel mailing list >>> Grub-devel@gnu.org >>> https://lists.gnu.org/mailman/listinfo/grub-devel --------------D24F0FD51112EB73E4FBAAB5 Content-Type: text/x-patch; charset=UTF-8; name="0001-at_keyboard-New-at_keyboard_fallback_set-environment.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-at_keyboard-New-at_keyboard_fallback_set-environment.pa"; filename*1="tch" From 3d290e4b6129dc1e6458815635d978302002c859 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Renaud=3D20M=3DC3=3DA9trich?=3D Date: Fri, 18 Dec 2020 15:39:26 +0100 Subject: [PATCH] at_keyboard: New 'at_keyboard_fallback_set' environment variable to force the set manually upon query_mode() failing MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit This seems required with HP DL380p Gen 8 systems. Indeed, with this system, we can see the following sequence: 1. controller is queried to get current configuration (returns 0x30 which i= s quite standard) 2. controller is queried to get the current keyboard set in used, using cod= e 0xf0 (first part) 3. controller answers with 0xfa which means "ACK" (=3D=3D ok) 4. then we send "0" to tell "we want to know which set your are supporting" 5. controller answers with 0xfa ("ACK") 6. controller should then give us 1, 2, 3 or 0x43, 0x41, 0x3f, but here it = gives us 0xfe which means "NACK" Since there seems no way to determine the current set, and in fact the controller expects set2 to be used, we need to rely on an environment variable. Everything has been tested on this system: using 0xFE (resend command), making sure we wait for ACK in the 2 steps "write_mode", etc. Below is litterature I used to come up with "there is no other solution": - https://wiki.osdev.org/%228042%22_PS/2_Controller - http://www-ug.eecg.toronto.edu/msl/nios_devices/datasheets/PS2%20Keyboard= %20Protocol.htm - http://www.s100computers.com/My%20System%20Pages/MSDOS%20Board/PC%20Keybo= ard.pdf Signed-off-by: Renaud M=C3=A9trich --- grub-core/term/at_keyboard.c | 121 +++++++++++++++++++++++++++-------- 1 file changed, 96 insertions(+), 25 deletions(-) diff --git a/grub-core/term/at_keyboard.c b/grub-core/term/at_keyboard.c index 260143826..dac0f946f 100644 --- a/grub-core/term/at_keyboard.c +++ b/grub-core/term/at_keyboard.c @@ -31,6 +31,7 @@ GRUB_MOD_LICENSE ("GPLv3+"); static grub_uint8_t grub_keyboard_controller_orig; static grub_uint8_t grub_keyboard_orig_set; struct grub_ps2_state ps2_state; +static int fallback_set; =20 static int ping_sent; =20 @@ -76,6 +77,8 @@ at_command (grub_uint8_t data) =09break; return 0; } + if (i =3D=3D GRUB_AT_TRIES) + grub_dprintf ("atkeyb", "at_command() timed out! (stopped after %d tri= es)\n", i); return (i !=3D GRUB_AT_TRIES); } =20 @@ -105,6 +108,21 @@ grub_keyboard_controller_read (void) =20 #endif =20 +static int +resend_last_result (void) +{ + grub_uint8_t ret; + keyboard_controller_wait_until_ready (); + grub_dprintf ("atkeyb", "resend_last_result: sending 0xfe\n"); + grub_outb (0xfe, KEYBOARD_REG_DATA); + ret =3D wait_ack (); + grub_dprintf ("atkeyb", "resend_last_result: wait_ack() returned 0x%x\n"= , ret); + keyboard_controller_wait_until_ready (); + ret =3D grub_inb (KEYBOARD_REG_DATA); + grub_dprintf ("atkeyb", "resend_last_result: read 0x%x from controller\n= ", ret); + return ret; +} + static int write_mode (int mode) { @@ -113,11 +131,14 @@ write_mode (int mode) { grub_uint8_t ack; keyboard_controller_wait_until_ready (); + grub_dprintf ("atkeyb", "write_mode: sending 0xf0\n"); grub_outb (0xf0, KEYBOARD_REG_DATA); keyboard_controller_wait_until_ready (); + grub_dprintf ("atkeyb", "write_mode: sending mode %d\n", mode); grub_outb (mode, KEYBOARD_REG_DATA); keyboard_controller_wait_until_ready (); ack =3D wait_ack (); + grub_dprintf ("atkeyb", "write_mode: wait_ack() returned 0x%x\n", ac= k); if (ack =3D=3D GRUB_AT_NACK) =09continue; if (ack =3D=3D GRUB_AT_ACK) @@ -125,6 +146,9 @@ write_mode (int mode) return 0; } =20 + if (i =3D=3D GRUB_AT_TRIES) + grub_dprintf ("atkeyb", "write_mode() timed out! (stopped after %d tri= es)\n", i); + return (i !=3D GRUB_AT_TRIES); } =20 @@ -132,31 +156,66 @@ static int query_mode (void) { grub_uint8_t ret; + grub_uint64_t endtime; + unsigned i; int e; + char *envvar; =20 - e =3D write_mode (0); - if (!e) { - grub_dprintf("atkeyb", "query_mode: write_mode(0) failed\n"); - return 0; - } + for (i =3D 0; i < GRUB_AT_TRIES; i++) { + grub_dprintf ("atkeyb", "query_mode: sending command to controller\n")= ; + e =3D write_mode (0); + if (!e) { + grub_dprintf ("atkeyb", "query_mode: write_mode(0) failed\n"); + return 0; + } =20 - do { - keyboard_controller_wait_until_ready (); - ret =3D grub_inb (KEYBOARD_REG_DATA); - } while (ret =3D=3D GRUB_AT_ACK); - /* QEMU translates the set even in no-translate mode. */ - if (ret =3D=3D 0x43 || ret =3D=3D 1) { - grub_dprintf("atkeyb", "query_mode: returning 1 (ret=3D0x%x)\n", ret); - return 1; - } - if (ret =3D=3D 0x41 || ret =3D=3D 2) { - grub_dprintf("atkeyb", "query_mode: returning 2 (ret=3D0x%x)\n", ret); - return 2; + endtime =3D grub_get_time_ms () + 20; + do { + keyboard_controller_wait_until_ready (); + ret =3D grub_inb (KEYBOARD_REG_DATA); + grub_dprintf ("atkeyb", "query_mode/loop: read 0x%x from controller\= n", ret); + } while ((ret =3D=3D GRUB_AT_ACK || ret =3D=3D GRUB_AT_NACK) && grub_g= et_time_ms () < endtime); + if (ret =3D=3D 0xfe) { + grub_dprintf ("atkeyb", "query_mode: asking controller to resend las= t result\n"); + ret =3D resend_last_result(); + grub_dprintf ("atkeyb", "query_mode: read 0x%x from controller\n", r= et); + } + /* QEMU translates the set even in no-translate mode. */ + if (ret =3D=3D 0x43 || ret =3D=3D 1) { + grub_dprintf ("atkeyb", "query_mode: controller returned 0x%x, retur= ning 1\n", ret); + return 1; + } + if (ret =3D=3D 0x41 || ret =3D=3D 2) { + grub_dprintf ("atkeyb", "query_mode: controller returned 0x%x, retur= ning 2\n", ret); + return 2; + } + if (ret =3D=3D 0x3f || ret =3D=3D 3) { + grub_dprintf ("atkeyb", "query_mode: controller returned 0x%x, retur= ning 3\n", ret); + return 3; + } + grub_dprintf ("atkeyb", "query_mode: controller returned unexpected va= lue 0x%x, retrying\n", ret); } - if (ret =3D=3D 0x3f || ret =3D=3D 3) { - grub_dprintf("atkeyb", "query_mode: returning 3 (ret=3D0x%x)\n", ret); - return 3; + + /* + * Falling here means we tried querying and the controller returned some= thing + * we don't understand, try to use 'at_keyboard_fallback_set' if it exis= ts, + * otherwise return 0. + */ + envvar =3D grub_env_get ("at_keyboard_fallback_set"); + if (envvar) { + fallback_set =3D grub_strtoul (envvar, 0, 10); + if ((grub_errno) || (fallback_set < 1) || (fallback_set > 3)) { + grub_dprintf ("atkeyb", "WARNING: ignoring unexpected value '%s' for= '%s' variable\n", +=09=09 envvar, "at_keyboard_fallback_set"); + fallback_set =3D 0; + } else { + grub_dprintf ("atkeyb", "query_mode: '%s' specified in environment, = returning %d\n", +=09=09 "at_keyboard_fallback_set", fallback_set); + } + return fallback_set; } + grub_dprintf ("atkeyb", "WARNING: no '%s' specified in environment, retu= rning 0\n", +=09=09"at_keyboard_fallback_set"); return 0; } =20 @@ -165,14 +224,25 @@ set_scancodes (void) { /* You must have visited computer museum. Keyboard without scancode set knowledge. Assume XT. */ - if (!grub_keyboard_orig_set) - { - grub_dprintf ("atkeyb", "No sets support assumed\n"); - ps2_state.current_set =3D 1; + if (!grub_keyboard_orig_set) { + if (fallback_set) { + grub_dprintf ("atkeyb", "No sets support assumed but set forced to %= d\n", fallback_set); + ps2_state.current_set =3D fallback_set; return; } + grub_dprintf ("atkeyb", "No sets support assumed, forcing to set 1\n")= ; + ps2_state.current_set =3D 1; + return; + } =20 #if !USE_SCANCODE_SET + if (fallback_set) { + grub_dprintf ("atkeyb", "queried set is %d but set forced to %d\n", +=09=09 grub_keyboard_orig_set, fallback_set); + ps2_state.current_set =3D fallback_set; + return; + } + if ((grub_keyboard_controller_orig & KEYBOARD_AT_TRANSLATE) =3D=3D KEYBO= ARD_AT_TRANSLATE) { grub_dprintf ("atkeyb", "queried set is %d but keyboard in Translate m= ode, so actually in set 1\n", grub_keyboard_orig_set); ps2_state.current_set =3D 1; @@ -261,6 +331,7 @@ grub_at_keyboard_getkey (struct grub_term_input *term _= _attribute__ ((unused))) static void grub_keyboard_controller_init (void) { + grub_dprintf ("atkeyb", "initializing the controller\n"); ps2_state.at_keyboard_status =3D 0; /* Drain input buffer. */ while (1) @@ -282,6 +353,7 @@ grub_keyboard_controller_init (void) grub_keyboard_controller_orig =3D grub_keyboard_controller_read (); grub_dprintf ("atkeyb", "grub_keyboard_controller_orig =3D 0x%x\n", grub= _keyboard_controller_orig); grub_keyboard_orig_set =3D query_mode (); + grub_dprintf ("atkeyb", "grub_keyboard_orig_set =3D %d\n", grub_keyboard= _orig_set); #endif set_scancodes (); keyboard_controller_led (ps2_state.led_status); @@ -329,7 +401,6 @@ grub_at_restore_hw (void) return GRUB_ERR_NONE; } =20 - static struct grub_term_input grub_at_keyboard_term =3D { .name =3D "at_keyboard", --=20 2.29.2 --------------D24F0FD51112EB73E4FBAAB5-- --mCFI9CFuo1UAx4NARk8ubuIxw0fD96xUn-- --fjng5G4iSjWn5fK87LJ7bbNuPJW3Oof3Z Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEEDdWGHF0SM+2VX5h9XRKQlPtuQyYFAmA3SUkFAwAAAAAACgkQXRKQlPtuQybz Kg/+J6rmbeAw6kr0SzhXhBV6OoKIWvBcalXaM/wB0Cjfv4929Okjf0Ewrnb5ulNi36RIp6bG4DnM CNtkpow0S2+hDbi4i9YqYmlMoGgeTjd+cI90fBgfrlt8DU9TTkqC5kBTIk0M6x3Uqw+EuM8BBMpG 5TDESAsIS8sylnM2wCzD/fpcDow8raKza1Cx9xlVe8ilN+kt3o5rjwa1k3znGoYNJyEO2JCfo1RF bSx6kn/JOm5WIk/ktjqCu27mEbyDv+Iva9k1Q35BouwZG+c27k+gYZymJN637b262dXHjzSCJpge nNMcmEHAFsJdesYIbvFalEGmMZZGuhS07V2I1pee50vxQ1ZDnuL177vr2FD5hOtQubAveJkdRp1F Cg5Z/up5fPluMSHf6eE2dIv3Zqzq2zjAG8IqG0NoGLukZL8dgCYLOUDM1YRi3HhyKY5DmkvTzJOs T+mvvFqWsJif/va18fHXS5W06HpjcaMO1ddr9ws24AzkuEmm3BDbskUEpm28W1Nj5sIEU4TpBxIA aWBYTaWIoB01XhOTfVge35wZV5IvAoGOt7UKV3TvY7UZTObYuBaNO9cqVfAOtdHwdOJpdAt+DWC6 SbQe9+NC8UreJ+jE1lRFdPgvYRzHXpUSxmruPmXtUom9Bt2MFpGf+BG2LoR1su+2dHZY4htm/43w zLs= =A2ci -----END PGP SIGNATURE----- --fjng5G4iSjWn5fK87LJ7bbNuPJW3Oof3Z--