Message-ID: <500589E5.20104@...1114...> Date: Tue, 17 Jul 2012 17:51:01 +0200 From: David Sommerseth MIME-Version: 1.0 References: <1342533472-30873-1-git-send-email-heiko.hund@...1489...> <21316332.O9di4uRdZn@...1526...> <20120717154628.GV22125@...1296...> In-Reply-To: <20120717154628.GV22125@...1296...> Subject: Re: [Openvpn-devel] [PATCH] don't treat socket related errors special anymore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Gert Doering Cc: Alon Bar-Lev , openvpn-devel@lists.sourceforge.net -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 17/07/12 17:46, Gert Doering wrote: > Hi, > > On Tue, Jul 17, 2012 at 05:09:34PM +0200, Heiko Hund wrote: >> if (status == EINPROGRESS #ifdef WIN32 || status == >> WSAEWOULDBLOCK #endif ) > > Please let's not do that. > >> or slightly less disturbing >> >> #ifndef WSAEWOULDBLOCK #define WSAEWOULDBLOCK 10035L #endif > > Something like that (possibly autoconf-magick'ed) and then > > if (status == EINPROGRESS || status == WSAEWOULDBLOCK ) > > or even > > if (status == EINPROGRESS || status == EWOULDBLOCK ) > > (WSAEWOULDBLOCK mapped to EWOULDBLOCK, as I've seen that error code > on some unix platforms as well) would be my favourite, > code-readability wise. +1 kind regards, David Sommerseth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlAFieMACgkQDC186MBRfrqiXgCfZ0GhPBuXV58WX0nSOTIOGeOC aN8An3+0TsHfXdOANg/xbIHAVxeGfEea =m1mq -----END PGP SIGNATURE-----