From: Matt Coffin Subject: Re: [PATCH] drm/amd/powerplay: do proper cleanups on hw_fini Date: Fri, 8 Nov 2019 13:50:04 -0700 Message-ID: <50104e7b-e38f-6750-7aae-dfef399790f3@gmail.com> References: <20190903034336.16005-1-evan.quan@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190903034336.16005-1-evan.quan-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Quan, Evan" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" Cc: Alex Deucher , "Li, Candice" , "Gui, Jack" SGV5IGd1eXMsCgoKClRoaXMgcGF0Y2ggY2F1c2VkIHNvbWUga2luZCBvZiByZXZlcnNpb24gd2l0 aCBzbXVfcmVzZXQgb24gTmF2aTEwLiBJJ20Kbm8gZXhwZXJ0IHNpbmNlIGV2ZXJ5dGhpbmcgSSBr bm93IGNvbWVzIGZyb20ganVzdCByZWFkaW5nIHRocm91Z2ggdGhlCmNvZGUsIHNvIHRoaXMgY291 bGQgYmUgc29tZSBraW5kIG9mIGludGVuZGVkIGJlaGF2aW9yLCBidXQgYWZ0ZXIgdGhpcwpwYXRj aCwgaWYgeW91IHdyaXRlIGEgcHB0YWJsZSB0byB0aGUgc3lzZnMgcHBfdGFibGUgaW50ZXJmYWNl IG9uIG5hdmkxMCwKdGhlbiB0aGUgU01VIHdpbGwgZmFpbCB0byByZXNldCBzdWNjZXNzZnVsbHks IGFuZCB0aGUgcmVzdWx0IGlzCnNlZW1pbmdseSBhbiB1bnJlY292ZXJhYmxlIHNpdHVhdGlvbi4K CgoKSSBwdXQgaW4gYSByZXBvcnQgb24gYnVnemlsbGEgd2l0aCBkbWVzZyBsb2dzCjoKaHR0cHM6 Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEyMjM0CgoKRmluZGluZyB0 aGlzIGNoYW5nZSB3YXMgdGhlIHJlc3VsdCBvZiBhIGJpc2VjdCB0byBmaW5kIHdoZXJlIHRoZSBp c3N1ZQpzdGFydGVkLCBhbmQgcmV2ZXJ0aW5nIHRoZSBjaGFuZ2VzIHRvIHNtdV9od19maW5pIHJl c29sdmVkIHRoZSBpc3N1ZS4KQW55IGFkdmljZSBvbiBwb3NzaWJsZSBwcm9wZXIgZml4ZXM/CgpU aGFua3MgaW4gYWR2YW5jZSwKCk1hdHQKCk9uIDkvMi8xOSA5OjQ0IFBNLCBRdWFuLCBFdmFuIHdy b3RlOgo+IFRoZXNlIGFyZSBuZWVkZWQgZm9yIHNtdV9yZXNldCBzdXBwb3J0Lgo+IAo+IENoYW5n ZS1JZDogSWYyOWVkZTRiOTk3NThhZGIwOGZkNGUxNjY2NWY0NGZkODkzZWM5OWIKPiBTaWduZWQt b2ZmLWJ5OiBFdmFuIFF1YW4gPGV2YW4ucXVhbkBhbWQuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vYW1kL3Bvd2VycGxheS9hbWRncHVfc211LmMgICAgIHwgMTcgKysrKysrKysrKysrKysr KysKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvaW5jL2FtZGdwdV9zbXUuaCB8ICAz ICsrKwo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9zbXVfdjExXzAuYyAgICAgIHwg MTAgKysrKysrKysrKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKykKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvYW1kZ3B1X3NtdS5jIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvYW1kZ3B1X3NtdS5jCj4gaW5kZXggZDVlZTEz YTc4ZWI3Li4zY2Y4ZDk0NGY4OTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9w b3dlcnBsYXkvYW1kZ3B1X3NtdS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBs YXkvYW1kZ3B1X3NtdS5jCj4gQEAgLTEyODYsNiArMTI4NiwxMSBAQCBzdGF0aWMgaW50IHNtdV9o d19pbml0KHZvaWQgKmhhbmRsZSkKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gK3N0YXRpYyBp bnQgc211X3N0b3BfZHBtcyhzdHJ1Y3Qgc211X2NvbnRleHQgKnNtdSkKPiArewo+ICsJcmV0dXJu IHNtdV9zZW5kX3NtY19tc2coc211LCBTTVVfTVNHX0Rpc2FibGVBbGxTbXVGZWF0dXJlcyk7Cj4g K30KPiArCj4gIHN0YXRpYyBpbnQgc211X2h3X2Zpbmkodm9pZCAqaGFuZGxlKQo+ICB7Cj4gIAlz dHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9IChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqKWhhbmRs ZTsKPiBAQCAtMTI5OCw2ICsxMzAzLDE4IEBAIHN0YXRpYyBpbnQgc211X2h3X2Zpbmkodm9pZCAq aGFuZGxlKQo+ICAJCXNtdV9wb3dlcmdhdGVfdmNuKCZhZGV2LT5zbXUsIHRydWUpOwo+ICAJfQo+ ICAKPiArCXJldCA9IHNtdV9zdG9wX3RoZXJtYWxfY29udHJvbChzbXUpOwo+ICsJaWYgKHJldCkg ewo+ICsJCXByX3dhcm4oIkZhaWwgdG8gc3RvcCB0aGVybWFsIGNvbnRyb2whXG4iKTsKPiArCQly ZXR1cm4gcmV0Owo+ICsJfQo+ICsKPiArCXJldCA9IHNtdV9zdG9wX2RwbXMoc211KTsKPiArCWlm IChyZXQpIHsKPiArCQlwcl93YXJuKCJGYWlsIHRvIHN0b3AgRHBtcyFcbiIpOwo+ICsJCXJldHVy biByZXQ7Cj4gKwl9Cj4gKwo+ICAJa2ZyZWUodGFibGVfY29udGV4dC0+ZHJpdmVyX3BwdGFibGUp Owo+ICAJdGFibGVfY29udGV4dC0+ZHJpdmVyX3BwdGFibGUgPSBOVUxMOwo+ICAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvaW5jL2FtZGdwdV9zbXUuaCBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L2luYy9hbWRncHVfc211LmgKPiBpbmRleCBiMTky MjRjYjZkNmQuLjhlNGIwYWQyNDcxMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1k L3Bvd2VycGxheS9pbmMvYW1kZ3B1X3NtdS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9w b3dlcnBsYXkvaW5jL2FtZGdwdV9zbXUuaAo+IEBAIC00OTgsNiArNDk4LDcgQEAgc3RydWN0IHNt dV9mdW5jcwo+ICAJaW50ICgqZ2V0X2N1cnJlbnRfY2xrX2ZyZXEpKHN0cnVjdCBzbXVfY29udGV4 dCAqc211LCBlbnVtIHNtdV9jbGtfdHlwZSBjbGtfaWQsIHVpbnQzMl90ICp2YWx1ZSk7Cj4gIAlp bnQgKCppbml0X21heF9zdXN0YWluYWJsZV9jbG9ja3MpKHN0cnVjdCBzbXVfY29udGV4dCAqc211 KTsKPiAgCWludCAoKnN0YXJ0X3RoZXJtYWxfY29udHJvbCkoc3RydWN0IHNtdV9jb250ZXh0ICpz bXUpOwo+ICsJaW50ICgqc3RvcF90aGVybWFsX2NvbnRyb2wpKHN0cnVjdCBzbXVfY29udGV4dCAq c211KTsKPiAgCWludCAoKnJlYWRfc2Vuc29yKShzdHJ1Y3Qgc211X2NvbnRleHQgKnNtdSwgZW51 bSBhbWRfcHBfc2Vuc29ycyBzZW5zb3IsCj4gIAkJCSAgIHZvaWQgKmRhdGEsIHVpbnQzMl90ICpz aXplKTsKPiAgCWludCAoKnNldF9kZWVwX3NsZWVwX2RjZWZjbGspKHN0cnVjdCBzbXVfY29udGV4 dCAqc211LCB1aW50MzJfdCBjbGspOwo+IEBAIC02NDcsNiArNjQ4LDggQEAgc3RydWN0IHNtdV9m dW5jcwo+ICAJKChzbXUpLT5wcHRfZnVuY3MtPnNldF90aGVybWFsX2Zhbl90YWJsZSA/IChzbXUp LT5wcHRfZnVuY3MtPnNldF90aGVybWFsX2Zhbl90YWJsZSgoc211KSkgOiAwKQo+ICAjZGVmaW5l IHNtdV9zdGFydF90aGVybWFsX2NvbnRyb2woc211KSBcCj4gIAkoKHNtdSktPmZ1bmNzLT5zdGFy dF90aGVybWFsX2NvbnRyb2w/IChzbXUpLT5mdW5jcy0+c3RhcnRfdGhlcm1hbF9jb250cm9sKChz bXUpKSA6IDApCj4gKyNkZWZpbmUgc211X3N0b3BfdGhlcm1hbF9jb250cm9sKHNtdSkgXAo+ICsJ KChzbXUpLT5mdW5jcy0+c3RvcF90aGVybWFsX2NvbnRyb2w/IChzbXUpLT5mdW5jcy0+c3RvcF90 aGVybWFsX2NvbnRyb2woKHNtdSkpIDogMCkKPiAgI2RlZmluZSBzbXVfcmVhZF9zZW5zb3Ioc211 LCBzZW5zb3IsIGRhdGEsIHNpemUpIFwKPiAgCSgoc211KS0+cHB0X2Z1bmNzLT5yZWFkX3NlbnNv cj8gKHNtdSktPnBwdF9mdW5jcy0+cmVhZF9zZW5zb3IoKHNtdSksIChzZW5zb3IpLCAoZGF0YSks IChzaXplKSkgOiAwKQo+ICAjZGVmaW5lIHNtdV9zbWNfcmVhZF9zZW5zb3Ioc211LCBzZW5zb3Is IGRhdGEsIHNpemUpIFwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBs YXkvc211X3YxMV8wLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9zbXVfdjExXzAu Ywo+IGluZGV4IGRiNWU5NGNlNTRhZi4uMWEzOGFmODQzOTRlIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L3NtdV92MTFfMC5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2FtZC9wb3dlcnBsYXkvc211X3YxMV8wLmMKPiBAQCAtMTIwOSw2ICsxMjA5LDE1IEBAIHN0 YXRpYyBpbnQgc211X3YxMV8wX3N0YXJ0X3RoZXJtYWxfY29udHJvbChzdHJ1Y3Qgc211X2NvbnRl eHQgKnNtdSkKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbnQgc211X3YxMV8w X3N0b3BfdGhlcm1hbF9jb250cm9sKHN0cnVjdCBzbXVfY29udGV4dCAqc211KQo+ICt7Cj4gKwlz dHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9IHNtdS0+YWRldjsKPiArCj4gKwlXUkVHMzJfU09D MTUoVEhNLCAwLCBtbVRITV9USEVSTUFMX0lOVF9FTkEsIDApOwo+ICsKPiArCXJldHVybiAwOwo+ ICt9Cj4gKwo+ICBzdGF0aWMgdWludDE2X3QgY29udmVydF90b192ZGRjKHVpbnQ4X3QgdmlkKQo+ ICB7Cj4gIAlyZXR1cm4gKHVpbnQxNl90KSAoKDYyMDAgLSAodmlkICogMjUpKSAvIFNNVTExX1ZP TFRBR0VfU0NBTEUpOwo+IEBAIC0xNzgzLDYgKzE3OTIsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IHNtdV9mdW5jcyBzbXVfdjExXzBfZnVuY3MgPSB7Cj4gIAkuZ2V0X2N1cnJlbnRfY2xrX2ZyZXEg PSBzbXVfdjExXzBfZ2V0X2N1cnJlbnRfY2xrX2ZyZXEsCj4gIAkuaW5pdF9tYXhfc3VzdGFpbmFi bGVfY2xvY2tzID0gc211X3YxMV8wX2luaXRfbWF4X3N1c3RhaW5hYmxlX2Nsb2NrcywKPiAgCS5z dGFydF90aGVybWFsX2NvbnRyb2wgPSBzbXVfdjExXzBfc3RhcnRfdGhlcm1hbF9jb250cm9sLAo+ ICsJLnN0b3BfdGhlcm1hbF9jb250cm9sID0gc211X3YxMV8wX3N0b3BfdGhlcm1hbF9jb250cm9s LAo+ICAJLnJlYWRfc2Vuc29yID0gc211X3YxMV8wX3JlYWRfc2Vuc29yLAo+ICAJLnNldF9kZWVw X3NsZWVwX2RjZWZjbGsgPSBzbXVfdjExXzBfc2V0X2RlZXBfc2xlZXBfZGNlZmNsaywKPiAgCS5k aXNwbGF5X2Nsb2NrX3ZvbHRhZ2VfcmVxdWVzdCA9IHNtdV92MTFfMF9kaXNwbGF5X2Nsb2NrX3Zv bHRhZ2VfcmVxdWVzdCwKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4