Message-ID: <5016A34B.5000406@windriver.com>
Date: Mon, 30 Jul 2012 11:07:55 -0400
From: Bruce Ashfield <bruce.ashfield@windriver.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:12.0) Gecko/20120430 Thunderbird/12.0.1
MIME-Version: 1.0
To: Leon Woestenberg <leon.woestenberg@gmail.com>
References: <1343483125-26065-1-git-send-email-sidebranch.openembedded@gmail.com>
In-Reply-To: <1343483125-26065-1-git-send-email-sidebranch.openembedded@gmail.com>
Cc: yocto@yoctoproject.org, Scott Garman <scott.a.garman@intel.com>,
	Leon Woestenberg <leon@sidebranch.com>
Subject: Re: [PATCH] kernel.bbclass: Iff exists, copy bounds.h for external module building.
Precedence: list
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit

On 12-07-28 09:45 AM, Leon Woestenberg wrote:
> From: Leon Woestenberg<leon@sidebranch.com>
>
> Signed-off-by: Leon Woestenberg<leon@sidebranch.com>
> ---
>   meta/classes/kernel.bbclass |    6 ++++++
>   1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index c21ab96..bd3e335 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -183,6 +183,12 @@ kernel_do_install() {
>   		cp arch/powerpc/lib/crtsavres.o $kerneldir/arch/powerpc/lib/crtsavres.o
>   	fi
>
> +	# make -C $kerneldir _mrproper_scripts deleted this file, but we need it for
> +	# building external modules like compat-wireless.
> +	if [ -f include/generated/bounds.h ]; then
> +		cp include/generated/bounds.h $kerneldir/include/generated/bounds.h
> +	fi

This change is definitely safer using and older kernel that doesn't have a
generated bounds.h .. but your tree is out of date. This should be on
top of:

commit 9247550642a536f83c6c711ce4bd340e5e5606b7
Author: Denis Carikli <GNUtoo@no-log.org>
Date:   Fri Jul 20 16:22:22 2012 -0700

     kernel.bbclass: fix external module building

     Without that fix we have the following while compiling compat-wireless.
       include/linux/mmzone.h:18:30: fatal error: generated/bounds.h: No 
such file or directory

     Note that the compat-wireless recipe will be added in another commit.

     make -C $kerneldir _mrproper_scripts deleted this file along with
     other things so we resurrect it with this patch.

     (From OE-Core rev: 2d114fd0cdf7486f18e53f2bf41c4f559e4b4a8d)

     Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
     Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
     Signed-off-by: Saul Wold <sgw@linux.intel.com>
     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>


Cheers,

Bruce

> +
>   	# Remove the following binaries which cause strip errors
>   	# during do_package for cross-compiled platforms
>   	bin_files="arch/powerpc/boot/addnote arch/powerpc/boot/hack-coff \