From: dirk.behme@gmail.com (Dirk Behme) Date: Sun, 05 Aug 2012 08:36:45 +0200 Subject: [PATCH v2 2/3] mtd: nand: Let MTD_NAND_GPMI_NAND depend on MXS_DMA In-Reply-To: <20120803100711.GC24458@pengutronix.de> References: <1343215100-24005-1-git-send-email-festevam@gmail.com> <1343215100-24005-2-git-send-email-festevam@gmail.com> <20120803100711.GC24458@pengutronix.de> Message-ID: <501E147D.5050707@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03.08.2012 12:07, Sascha Hauer wrote: > On Wed, Jul 25, 2012 at 08:18:19AM -0300, Fabio Estevam wrote: >> From: Fabio Estevam >> >> MTD_NAND_GPMI_NAND driver depends on MXS_DMA to be selected, otherwise the following error happens >> for imx_v6_v7_defconfig: >> >> drivers/built-in.o: In function `gpmi_dma_filter': >> clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh' >> make: *** [vmlinux] Error 1 >> >> Signed-off-by: Fabio Estevam > > Acked-by: Sascha Hauer > > As mentioned elsewhere in this thread: We should not select user visible > options, so this patch is the only thing we can do atm (apart from > 'fixing the tools' as David mentioned, but this is out of scope for an > -rc kernel) I asked Shawn about this and it seems that this patch is the way to go for the moment. So: Acked-by: Dirk Behme David: Artem: Building recent 3.6-rc1mainline with imx_v6_v7_defconfig is broken. We need this patch to get it working, again. It would be nice if this patch could go as a fix into 3.6-rcX mainline asap. Could you help with this? Many thanks and best regards Dirk > Additionally the imx_v6_v7_defconfig should be adjusted so that the gpmi > nand driver actually gets built. > > Sascha > >> --- >> Changes since v1: >> - Use 'depends' rather than 'select' >> drivers/mtd/nand/Kconfig | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig >> index a5d8a1b..da52c7d 100644 >> --- a/drivers/mtd/nand/Kconfig >> +++ b/drivers/mtd/nand/Kconfig >> @@ -463,6 +463,7 @@ config MTD_NAND_NANDSIM >> config MTD_NAND_GPMI_NAND >> bool "GPMI NAND Flash Controller driver" >> depends on MTD_NAND&& (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q) >> + depends on MXS_DMA >> help >> Enables NAND Flash support for IMX23, IMX28 or IMX6. >> The GPMI controller is very powerful, with the help of BCH >> -- >> 1.7.1 >> >> >