From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Thu, 20 Sep 2012 09:42:14 +0200 Subject: [PATCH] at91ether: return PTR_ERR if call to clk_get fails In-Reply-To: <1348124676-6627-1-git-send-email-devendra.aaru@gmail.com> References: <1348124676-6627-1-git-send-email-devendra.aaru@gmail.com> Message-ID: <505AC8D6.5080404@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/20/2012 09:04 AM, Devendra Naga : > we are currently returning ENODEV, as the clk_get may give a exact > error code in its returned pointer, assign it to the ret by using the > PTR_ERR function, so that the subsequent goto label will jump to the > error path and clean the driver and return the error correctly. > > Signed-off-by: Devendra Naga Acked-by: Nicolas Ferre Thanks, > --- > drivers/net/ethernet/cadence/at91_ether.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c > index 7788419..4e980a7 100644 > --- a/drivers/net/ethernet/cadence/at91_ether.c > +++ b/drivers/net/ethernet/cadence/at91_ether.c > @@ -1086,7 +1086,7 @@ static int __init at91ether_probe(struct platform_device *pdev) > /* Clock */ > lp->ether_clk = clk_get(&pdev->dev, "ether_clk"); > if (IS_ERR(lp->ether_clk)) { > - res = -ENODEV; > + res = PTR_ERR(lp->ether_clk); > goto err_ioumap; > } > clk_enable(lp->ether_clk); > -- Nicolas Ferre