From: Yasuaki Ishimatsu Date: Mon, 01 Oct 2012 07:38:44 +0000 Subject: Re: [RFC v9 PATCH 03/21] memory-hotplug: store the node id in acpi_memory_device Message-Id: <50694884.7090706@jp.fujitsu.com> List-Id: References: <1346837155-534-1-git-send-email-wency@cn.fujitsu.com> <1346837155-534-4-git-send-email-wency@cn.fujitsu.com> <506517C1.7050909@gmail.com> In-Reply-To: <506517C1.7050909@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ni zhan Chen Cc: wency@cn.fujitsu.com, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com Hi Chen, 2012/09/28 12:21, Ni zhan Chen wrote: > On 09/05/2012 05:25 PM, wency@cn.fujitsu.com wrote: >> From: Wen Congyang >> >> The memory device has only one node id. Store the node id when >> enable the memory device, and we can reuse it when removing the >> memory device. > > one question: > if use numa emulation, memory device will associated to one node or ...? Memory device has only one node, even if you use numa emulation. Thanks, Yasuaki Ishimatsu > >> >> CC: David Rientjes >> CC: Jiang Liu >> CC: Len Brown >> CC: Benjamin Herrenschmidt >> CC: Paul Mackerras >> CC: Christoph Lameter >> Cc: Minchan Kim >> CC: Andrew Morton >> CC: KOSAKI Motohiro >> CC: Yasuaki Ishimatsu >> Signed-off-by: Wen Congyang >> Reviewed-by: Yasuaki Ishimatsu >> --- >> drivers/acpi/acpi_memhotplug.c | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c >> index 2a7beac..7873832 100644 >> --- a/drivers/acpi/acpi_memhotplug.c >> +++ b/drivers/acpi/acpi_memhotplug.c >> @@ -83,6 +83,7 @@ struct acpi_memory_info { >> struct acpi_memory_device { >> struct acpi_device * device; >> unsigned int state; /* State of the memory device */ >> + int nid; >> struct list_head res_list; >> }; >> @@ -256,6 +257,9 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device) >> info->enabled = 1; >> num_enabled++; >> } >> + >> + mem_device->nid = node; >> + >> if (!num_enabled) { >> printk(KERN_ERR PREFIX "add_memory failed\n"); >> mem_device->state = MEMORY_INVALID_STATE; >