From: David Henningsson Subject: Re: [PATCH] ALSA: hda - Add missing hda_gen_spec to struct via_spec Date: Wed, 10 Oct 2012 09:30:36 +0200 Message-ID: <5075241C.8040107@canonical.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by alsa0.perex.cz (Postfix) with ESMTP id DD5FE2616B2 for ; Wed, 10 Oct 2012 09:30:36 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 10/10/2012 09:26 AM, Takashi Iwai wrote: > The commit [4b527b65 ALSA: hda - limit internal mic boost for Asus > X202E] introduced the use of auto-parser code, but it forgot to add > struct hda_gen_spec at the head of codec->spec which the auto-parser > assumes silently. Without this record, it may result in memory > corruption. > > This patch adds the missing piece. > > Cc: [v3.5+] > Signed-off-by: Takashi Iwai > --- > > David, I queued this fix now. I'm going to send a pull request > tomorrow or on Friday. Thanks for catching. Isn't patch_sigmatel.c missing one also? -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic