Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86FB9C6FD1D for ; Thu, 30 Mar 2023 09:30:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B654D85E02; Thu, 30 Mar 2023 11:30:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="WBzN5sXg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7594B85E17; Thu, 30 Mar 2023 11:30:47 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1687C85A4A for ; Thu, 30 Mar 2023 11:30:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=devarsht@ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32U9Ud3P009805; Thu, 30 Mar 2023 04:30:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680168639; bh=KIaqrexnjegfOEdvq4uAcOGlkXENp8CUtjp4F1fGdEA=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=WBzN5sXg7BA43xlnfY+wtVGVeotzjDFrGKAF/o9Px3tsljarQxTjEJ2Rn5CTNBDac LLg38v7hKEKVSW1q467poHnDyCseXgl+MMNJkLJB1EFSLeaQGUzkUIymcO9K5ogpz2 Kezc9EbkcAFUakkI6Y0i925X7ZvNtPLlxwQ8wp9A= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32U9Udx7032708 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 30 Mar 2023 04:30:39 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 30 Mar 2023 04:30:38 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 30 Mar 2023 04:30:38 -0500 Received: from [172.24.145.199] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32U9Uasb014923; Thu, 30 Mar 2023 04:30:36 -0500 Message-ID: <5091eb28-6fab-d04e-2f45-e52ccd3b1946@ti.com> Date: Thu, 30 Mar 2023 15:00:35 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 03/15] drivers: Makefile: Add rule to compile video driver Content-Language: en-US To: Nikhil M Jain , , CC: , , References: <20230329120119.72886-1-n-jain1@ti.com> <20230329120119.72886-4-n-jain1@ti.com> From: Devarsh Thakkar In-Reply-To: <20230329120119.72886-4-n-jain1@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Nikhil, Thanks for the patch. On 29/03/23 17:31, Nikhil M Jain wrote: > CONFIG_$(SPL_)VIDEO checks for CONFIG_SPL_VIDEO at SPL and CONFIG_VIDEO > at u-boot proper and compiles video driver at respective stage. > > Signed-off-by: Nikhil M Jain > --- > V4: > - No change > > V3 (patch introduced): > - Add rule to compile video driver at SPL > > drivers/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/Makefile b/drivers/Makefile > index 15d19d0c8a..6fd4d80206 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -38,6 +38,7 @@ obj-$(CONFIG_$(SPL_TPL_)TPM) += tpm/ > obj-$(CONFIG_XEN) += xen/ > obj-$(CONFIG_$(SPL_)FPGA) += fpga/ > obj-y += bus/ > +obj-$(CONFIG_$(SPL_)VIDEO) += video/imho it should be obj-y +=video here (see below) > ifndef CONFIG_TPL_BUILD > ifndef CONFIG_VPL_BUILD > @@ -96,7 +97,6 @@ obj-y += rtc/ > obj-y += scsi/ > obj-y += sound/ > obj-y += spmi/ > -obj-y += video/ Looks to me we are breaking backward compatibility here. For e.g. I think configs/pinebook_defconfig only enables CONFIG_VIDEO_BRIDGE now it has to enable CONFIG_VIDEO explicitly too ? Regards Devarsh