From: Chen Gang Subject: Re: [PATCH] synclink fix ldisc buffer argument Date: Wed, 05 Dec 2012 09:35:11 +0800 Message-ID: <50BEA4CF.2030207@asianux.com> References: <50B6E751.9000000@asianux.com> <20121129051335.GA4375@kroah.com> <50B6F967.3050000@asianux.com> <20121129183207.GA4688@kroah.com> <50B81F76.8020508@asianux.com> <50B8DDAC.8070901@microgate.com> <50B90D0D.9040401@microgate.com> <50BCDDB4.6010608@microgate.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from intranet.asianux.com ([58.214.24.6]:51094 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752329Ab2LEBeS (ORCPT ); Tue, 4 Dec 2012 20:34:18 -0500 In-Reply-To: <50BCDDB4.6010608@microgate.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Paul Fulghum Cc: Greg KH , Linux Kernel Mailing List , linux-serial@vger.kernel.org, Alan Cox =E4=BA=8E 2012=E5=B9=B412=E6=9C=8804=E6=97=A5 01:13, Paul Fulghum =E5=86= =99=E9=81=93: > Fix call to line discipline receive_buf by synclink drivers. > Dummy flag buffer argument is ignored by N_HDLC line discipline but m= ight > be of insufficient size if accessed by a different line discipline > selected by mistake. flag buffer allocation now matches max size of d= ata > buffer. Unused char_buf buffers are removed. >=20 > Signed-off-by: Paul Fulghum >=20 thank you very much. might we use macro instead of hard code number ? (such as 4096, 65535). it is only an idea, not means need regression. thanks. --=20 Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-serial"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html