From: Minkyu Kang Date: Tue, 08 Jan 2013 11:35:40 +0900 Subject: [U-Boot] [PATCH V4 3/4] video: Modify exynos_fimd driver to support LCD console In-Reply-To: <1356086122-4489-4-git-send-email-ajaykumar.rs@samsung.com> References: <1356086122-4489-1-git-send-email-ajaykumar.rs@samsung.com> <1356086122-4489-4-git-send-email-ajaykumar.rs@samsung.com> Message-ID: <50EB85FC.9080909@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Ajay Kumar, On 21/12/12 19:35, Ajay Kumar wrote: > Currently, exynos FIMD driver is being used to support only TIZEN LOGOs. > In order to get LCD console, we need to enable half word swap feature > of FIMD and use 16 BPP. > LCD console and proprietary Logo cannot be used simultaneously. > We use logo_on field inside vidinfo_t structure to decide whether > user wants Logo or Console. > > Signed-off-by: Ajay Kumar > --- Please add changelog here about what you changed since last version. > drivers/video/exynos_fb.c | 7 +++++++ > drivers/video/exynos_fimd.c | 12 ++++++++---- > 2 files changed, 15 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/exynos_fb.c b/drivers/video/exynos_fb.c > index d9a3f9a..ee916be 100644 > --- a/drivers/video/exynos_fb.c > +++ b/drivers/video/exynos_fb.c > @@ -45,6 +45,13 @@ short console_row; > > static unsigned int panel_width, panel_height; > > +#ifndef CONFIG_CMD_BMP > +int bmp_display(ulong addr, int x, int y) > +{ > + return 0; > +} > +#endif It's a common function of bmp command. Please do not redefine such a function. --- Thanks, Minkyu Kang.