From: "flichtenheld (Code Review)" Date: Tue, 4 Jun 2024 12:57:51 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <50abac374d6c37804cff35e0161a37bb5e31ddac-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="folQhVmYOUo="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: test_user_pass: Fix building with --enable-systemd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --folQhVmYOUo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/641?usp=3Demail to review the following change. Change subject: test_user_pass: Fix building with --enable-systemd ...................................................................... test_user_pass: Fix building with --enable-systemd Need to make sure that ENABLE_SYSTEMD is really disabled. Change-Id: Ic33c210f06e173a450534aa0969c57f140086655 Signed-off-by: Frank Lichtenheld --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/41/641/1 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index ac84654..b43e655 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -27,6 +27,8 @@ #endif #undef ENABLE_SYSTEMD +/* avoid redefining ENABLE_SYSTEMD in misc.c */ +#undef HAVE_CONFIG_H #include "syshead.h" #include "manage.h" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/641?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic33c210f06e173a450534aa0969c57f140086655 Gerrit-Change-Number: 641 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --folQhVmYOUo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

Vi= ew Change

test_user_pass: Fix building with --enable-systemd

Nee= d to make sure that ENABLE_SYSTEMD is really disabled.

Change-Id: Ic= 33c210f06e173a450534aa0969c57f140086655
Signed-off-by: Frank Lichtenheld= <frank@...2641...>
---
M tests/unit_tests/openvpn/test_user_pa= ss.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull =
ssh://gerrit.openvpn.net:29418/openvpn refs/changes/41/641/1
diff -=
-git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/openvpn=
/test_user_pass.c
index ac84654..b43e655 100644
<= span>--- a/tests/unit_tests/openvpn/test_user_pass.c
+++ b/= tests/unit_tests/openvpn/test_user_pass.c
@@ -27,6 +27,8 @@=
#endif

#undef ENABLE_S= YSTEMD
+/* avoid rede= fining ENABLE_SYSTEMD in misc.c */
+#undef HAVE_CONFIG_H

#inc= lude "syshead.h"
#include "manage.h"

To view, visit change 641. To unsubscribe, or= for help writing mail filters, visit settings.

<= /div>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic33c210f06e173a450534aa0969= c57f140086655
Gerrit-Change-Number: 641
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--folQhVmYOUo=--