From: "its_Giaan (Code Review)"
Date: Tue, 28 Jan 2025 15:07:20 +0000
In-Reply-To:
References:
Reply-To: gianmarco@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
gert@...1296..., a@...2181...
Message-ID: <50bebc4604e27fa7004c4e438a63964679a82fb9-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="S2Lr5pVj/fE="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: mroute/management:
fix uninitialized variable (UNINIT)
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: cron2 , plaisthos , flichtenheld , openvpn-devel
--S2Lr5pVj/fE=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/880?usp=3Demail )
Change subject: mroute/management: fix uninitialized variable (UNINIT)
......................................................................
Patch Set 1:
(2 comments)
File src/openvpn/manage.c:
http://gerrit.openvpn.net/c/openvpn/+/880/comment/3db554a6_f8736f38 :
PS1, Line 573: port, p3);
> passing 'foo' will lead to ascii2proto() returning -1, which in turn will=
lead to "no client found", [=E2=80=A6]
Done
File src/openvpn/mroute.c:
http://gerrit.openvpn.net/c/openvpn/+/880/comment/9c991771_22e29971 :
PS1, Line 441: if ((maddr.type & MR_WITH_PROTO))
> double `(())` braces...
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/880?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd3178eee1f60fff1
Gerrit-Change-Number: 880
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-CC: ordex
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Attention: flichtenheld
Gerrit-Attention: ordex
Gerrit-Comment-Date: Tue, 28 Jan 2025 15:07:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--S2Lr5pVj/fE=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, ordex, plais=
thos.
View C=
hange
2 comments:
Done
File src/openvpn/mroute.c:
To vie=
w, visit =
change 880. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd31=
78eee1f60fff1
Gerrit-Change-Number: 880
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gianmarco@...2786...=
..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: ordex <a@...2181...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: ordex <a@...2181...> <=
/div>
Gerrit-Comment-Date: Tue, 28 Jan 2025 15:07:20=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Comment-In-Reply-To: ordex <a@...2181...>=
;
Gerrit-MessageType: comment
--S2Lr5pVj/fE=--