From: "stipa (Code Review)" Date: Fri, 22 Nov 2024 15:35:43 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <50defc64372d918cb5f03a5aa86138d080c0d453-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="mGrPrJBurko="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when reset buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , openvpn-devel --mGrPrJBurko= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/814?usp=3Demail ) Change subject: mudp.c: keep offset value when reset buffer ...................................................................... Patch Set 1: (3 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/814/comment/535895da_8fa8d201 : PS1, Line 7: mudp.c: keep offset value when reset buffer > "resetting" Acknowledged File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/814/comment/c06e65ab_3f487764 : PS1, Line 57: /* dco-win server requres prepend with sockaddr, so prese= rve offset */ > "requires" Acknowledged http://gerrit.openvpn.net/c/openvpn/+/814/comment/7b8a5279_1096f128 : PS1, Line 58: buf_init(&c->c2.buffers->aux_buf, buf.offset); > buf_init can fail (buf_reset_len cannot). [=E2=80=A6] Will wrap it into ASSERT. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/814?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I145573555aaace5e94774b5f977d032d3747ed72 Gerrit-Change-Number: 814 Gerrit-PatchSet: 1 Gerrit-Owner: stipa Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Fri, 22 Nov 2024 15:35:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --mGrPrJBurko= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

3 comments: