From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amdgpu: replace iova debugfs file with iomem (v2) Date: Fri, 9 Feb 2018 19:17:24 +0100 Message-ID: <50edcafc-23dd-3c44-021f-cf5989d06dc2@gmail.com> References: <20180209172750.15675-1-tom.stdenis@amd.com> <4708aad9-9ff0-d09f-9bb6-453c01c848a4@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4708aad9-9ff0-d09f-9bb6-453c01c848a4-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Tom St Denis , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMDkuMDIuMjAxOCB1bSAxODoyOCBzY2hyaWViIFRvbSBTdCBEZW5pczoKPiBPbiAwOS8wMi8x OCAxMjoyNyBQTSwgVG9tIFN0IERlbmlzIHdyb3RlOgo+PiBGcm9tOiBDaHJpc3RpYW4gS8O2bmln IDxja29lbmlnLmxlaWNodHp1bWVya2VuQGdtYWlsLmNvbT4KPgo+IE9vcHMsIEknbGwgcmVtb3Zl IHRoaXMgZnJvbSB0aGUgY29tbWl0IG1lc3NhZ2UgYmVmb3JlIHB1c2hpbmcgOi0pCj4KPiBJIGRp ZCBnaXZlIHlvdSBjcmVkaXQgYmVsb3cgdGhvdWdoLgoKVGhlIHBhdGNoIGJlZm9yZSB0aGlzIG9u ZSBpc24ndCBtZXJnZWQgeWV0IGJlY2F1c2UgSSdtIHN0aWxsIG5vdCBzdXJlIGlmIAp0aGF0IHdv cmtzIHVuZGVyIGFsbCBjaXJjdW1zdGFuY2VzIG9yIG5vdC4KCkNvdWxkIHlvdSBnaXZlIGl0IHNv bWUgZXh0ZW5kZWQgdGVzdGluZz8gRXNwZWNpYWxseSBpZiBpdCB3b3JrIHdpdGggCmV2aWN0aW9u LgoKQ2hyaXN0aWFuLgoKPgo+IFRvbQo+Cj4+Cj4+IFRoaXMgYWxsb3dzIGFjY2VzcyB0byBwYWdl cyBhbGxvY2F0ZWQgdGhyb3VnaCB0aGUgZHJpdmVyIHdpdGggb3B0aW9uYWwKPj4gSU9NTVUgbWFw cGluZy4KPj4KPj4gdjI6IEZpeCBudW1iZXIgb2YgYnl0ZXMgY29waWVkIGFuZCBhZGQgd3JpdGUg bWV0aG9kCj4+Cj4+IE9yaWdpbmFsLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29l bmlnQGFtZC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IFRvbSBTdCBEZW5pcyA8dG9tLnN0ZGVuaXNA YW1kLmNvbT4KPj4gLS0tCj4+IMKgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90 dG0uYyB8IDExMCAKPj4gKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0KPj4gwqAgMSBm aWxlIGNoYW5nZWQsIDg5IGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jIAo+PiBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYwo+PiBpbmRleCBiMzcyZDhkNjUw YTUuLmQ2YzU2YjAwMWEyYyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X3R0bS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV90dG0uYwo+PiBAQCAtMTkyOSwzOCArMTkyOSwxMDYgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBm aWxlX29wZXJhdGlvbnMgCj4+IGFtZGdwdV90dG1fZ3R0X2ZvcHMgPSB7Cj4+IMKgIMKgICNlbmRp Zgo+PiDCoCAtc3RhdGljIHNzaXplX3QgYW1kZ3B1X2lvdmFfdG9fcGh5c19yZWFkKHN0cnVjdCBm aWxlICpmLCBjaGFyIAo+PiBfX3VzZXIgKmJ1ZiwKPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBzaXplX3Qgc2l6ZSwgbG9mZl90ICpwb3MpCj4+ICtzdGF0aWMgc3NpemVf dCBhbWRncHVfaW9tZW1fcmVhZChzdHJ1Y3QgZmlsZSAqZiwgY2hhciBfX3VzZXIgKmJ1ZiwKPj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHNpemVfdCBzaXplLCBsb2ZmX3QgKnBv cykKPj4gwqAgewo+PiDCoMKgwqDCoMKgIHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2ID0gZmls ZV9pbm9kZShmKS0+aV9wcml2YXRlOwo+PiAtwqDCoMKgIGludCByOwo+PiAtwqDCoMKgIHVpbnQ2 NF90IHBoeXM7Cj4+IMKgwqDCoMKgwqAgc3RydWN0IGlvbW11X2RvbWFpbiAqZG9tOwo+PiArwqDC oMKgIHNzaXplX3QgcmVzdWx0ID0gMDsKPj4gK8KgwqDCoCBpbnQgcjsKPj4gwqAgLcKgwqDCoCAv LyBhbHdheXMgcmV0dXJuIDggYnl0ZXMKPj4gLcKgwqDCoCBpZiAoc2l6ZSAhPSA4KQo+PiAtwqDC oMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4+ICvCoMKgwqAgZG9tID0gaW9tbXVfZ2V0X2Rv bWFpbl9mb3JfZGV2KGFkZXYtPmRldik7Cj4+IMKgIC3CoMKgwqAgLy8gb25seSBhY2NlcHQgcGFn ZSBhZGRyZXNzZXMKPj4gLcKgwqDCoCBpZiAoKnBvcyAmIDB4RkZGKQo+PiAtwqDCoMKgwqDCoMKg wqAgcmV0dXJuIC1FSU5WQUw7Cj4+ICvCoMKgwqAgd2hpbGUgKHNpemUpIHsKPj4gK8KgwqDCoMKg wqDCoMKgIHBoeXNfYWRkcl90IGFkZHIgPSAqcG9zICYgUEFHRV9NQVNLOwo+PiArwqDCoMKgwqDC oMKgwqAgbG9mZl90IG9mZiA9ICpwb3MgJiB+UEFHRV9NQVNLOwo+PiArwqDCoMKgwqDCoMKgwqAg c2l6ZV90IGJ5dGVzID0gUEFHRV9TSVpFIC0gb2ZmOwo+PiArwqDCoMKgwqDCoMKgwqAgdW5zaWdu ZWQgbG9uZyBwZm47Cj4+ICvCoMKgwqDCoMKgwqDCoCBzdHJ1Y3QgcGFnZSAqcDsKPj4gK8KgwqDC oMKgwqDCoMKgIHZvaWQgKnB0cjsKPj4gKwo+PiArwqDCoMKgwqDCoMKgwqAgYnl0ZXMgPSBieXRl cyA8IHNpemUgPyBieXRlcyA6IHNpemU7Cj4+ICsKPj4gK8KgwqDCoMKgwqDCoMKgIGFkZHIgPSBk b20gPyBpb21tdV9pb3ZhX3RvX3BoeXMoZG9tLCBhZGRyKSA6IGFkZHI7Cj4+ICsKPj4gK8KgwqDC oMKgwqDCoMKgIHBmbiA9IGFkZHIgPj4gUEFHRV9TSElGVDsKPj4gK8KgwqDCoMKgwqDCoMKgIGlm ICghcGZuX3ZhbGlkKHBmbikpCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRVBF Uk07Cj4+ICsKPj4gK8KgwqDCoMKgwqDCoMKgIHAgPSBwZm5fdG9fcGFnZShwZm4pOwo+PiArwqDC oMKgwqDCoMKgwqAgaWYgKHAtPm1hcHBpbmcgIT0gYWRldi0+bW1hbi5iZGV2LmRldl9tYXBwaW5n KQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVQRVJNOwo+PiArCj4+ICvCoMKg wqDCoMKgwqDCoCBwdHIgPSBrbWFwKHApOwo+PiArwqDCoMKgwqDCoMKgwqAgaWYgKHB0cikgewo+ PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByID0gY29weV90b191c2VyKGJ1ZiwgcHRyLCBieXRl cyk7Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGt1bm1hcChwKTsKPj4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqAgaWYgKHIpCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0 dXJuIC1FRkFVTFQ7Cj4+ICvCoMKgwqDCoMKgwqDCoCB9IGVsc2Ugewo+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCByZXR1cm4gLUVGQVVMVDsKPj4gK8KgwqDCoMKgwqDCoMKgIH0KPj4gKwo+PiAr wqDCoMKgwqDCoMKgwqAgc2l6ZSAtPSBieXRlczsKPj4gK8KgwqDCoMKgwqDCoMKgICpwb3MgKz0g Ynl0ZXM7Cj4+ICvCoMKgwqDCoMKgwqDCoCByZXN1bHQgKz0gYnl0ZXM7Cj4+ICvCoMKgwqAgfQo+ PiArCj4+ICvCoMKgwqAgcmV0dXJuIHJlc3VsdDsKPj4gK30KPj4gKwo+PiArc3RhdGljIHNzaXpl X3QgYW1kZ3B1X2lvbWVtX3dyaXRlKHN0cnVjdCBmaWxlICpmLCBjb25zdCBjaGFyIF9fdXNlciAK Pj4gKmJ1ZiwKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHNpemVfdCBzaXpl LCBsb2ZmX3QgKnBvcykKPj4gK3sKPj4gK8KgwqDCoCBzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRl diA9IGZpbGVfaW5vZGUoZiktPmlfcHJpdmF0ZTsKPj4gK8KgwqDCoCBzdHJ1Y3QgaW9tbXVfZG9t YWluICpkb207Cj4+ICvCoMKgwqAgc3NpemVfdCByZXN1bHQgPSAwOwo+PiArwqDCoMKgIGludCBy Owo+PiDCoCDCoMKgwqDCoMKgIGRvbSA9IGlvbW11X2dldF9kb21haW5fZm9yX2RldihhZGV2LT5k ZXYpOwo+PiAtwqDCoMKgIGlmIChkb20pCj4+IC3CoMKgwqDCoMKgwqDCoCBwaHlzID0gaW9tbXVf aW92YV90b19waHlzKGRvbSwgKnBvcyk7Cj4+IC3CoMKgwqAgZWxzZQo+PiAtwqDCoMKgwqDCoMKg wqAgcGh5cyA9ICpwb3M7Cj4+IMKgIC3CoMKgwqAgciA9IGNvcHlfdG9fdXNlcihidWYsICZwaHlz LCA4KTsKPj4gLcKgwqDCoCBpZiAocikKPj4gLcKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUZBVUxU Owo+PiArwqDCoMKgIHdoaWxlIChzaXplKSB7Cj4+ICvCoMKgwqDCoMKgwqDCoCBwaHlzX2FkZHJf dCBhZGRyID0gKnBvcyAmIFBBR0VfTUFTSzsKPj4gK8KgwqDCoMKgwqDCoMKgIGxvZmZfdCBvZmYg PSAqcG9zICYgflBBR0VfTUFTSzsKPj4gK8KgwqDCoMKgwqDCoMKgIHNpemVfdCBieXRlcyA9IFBB R0VfU0laRSAtIG9mZjsKPj4gK8KgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgcGZuOwo+PiAr wqDCoMKgwqDCoMKgwqAgc3RydWN0IHBhZ2UgKnA7Cj4+ICvCoMKgwqDCoMKgwqDCoCB2b2lkICpw dHI7Cj4+ICsKPj4gK8KgwqDCoMKgwqDCoMKgIGJ5dGVzID0gYnl0ZXMgPCBzaXplID8gYnl0ZXMg OiBzaXplOwo+PiArCj4+ICvCoMKgwqDCoMKgwqDCoCBhZGRyID0gZG9tID8gaW9tbXVfaW92YV90 b19waHlzKGRvbSwgYWRkcikgOiBhZGRyOwo+PiDCoCAtwqDCoMKgIHJldHVybiA4Owo+PiArwqDC oMKgwqDCoMKgwqAgcGZuID0gYWRkciA+PiBQQUdFX1NISUZUOwo+PiArwqDCoMKgwqDCoMKgwqAg aWYgKCFwZm5fdmFsaWQocGZuKSkKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1F UEVSTTsKPj4gKwo+PiArwqDCoMKgwqDCoMKgwqAgcCA9IHBmbl90b19wYWdlKHBmbik7Cj4+ICvC oMKgwqDCoMKgwqDCoCBpZiAocC0+bWFwcGluZyAhPSBhZGV2LT5tbWFuLmJkZXYuZGV2X21hcHBp bmcpCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRVBFUk07Cj4+ICsKPj4gK8Kg wqDCoMKgwqDCoMKgIHB0ciA9IGttYXAocCk7Cj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAocHRyKSB7 Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHIgPSBjb3B5X2Zyb21fdXNlcihwdHIsIGJ1Ziwg Ynl0ZXMpOwo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBrdW5tYXAocCk7Cj4+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGlmIChyKQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IHJldHVybiAtRUZBVUxUOwo+PiArwqDCoMKgwqDCoMKgwqAgfSBlbHNlIHsKPj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FRkFVTFQ7Cj4+ICvCoMKgwqDCoMKgwqDCoCB9Cj4+ICsK Pj4gK8KgwqDCoMKgwqDCoMKgIHNpemUgLT0gYnl0ZXM7Cj4+ICvCoMKgwqDCoMKgwqDCoCAqcG9z ICs9IGJ5dGVzOwo+PiArwqDCoMKgwqDCoMKgwqAgcmVzdWx0ICs9IGJ5dGVzOwo+PiArwqDCoMKg IH0KPj4gKwo+PiArwqDCoMKgIHJldHVybiByZXN1bHQ7Cj4+IMKgIH0KPj4gwqAgLXN0YXRpYyBj b25zdCBzdHJ1Y3QgZmlsZV9vcGVyYXRpb25zIGFtZGdwdV90dG1faW92YV9mb3BzID0gewo+PiAr c3RhdGljIGNvbnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgYW1kZ3B1X3R0bV9pb21lbV9mb3Bz ID0gewo+PiDCoMKgwqDCoMKgIC5vd25lciA9IFRISVNfTU9EVUxFLAo+PiAtwqDCoMKgIC5yZWFk ID0gYW1kZ3B1X2lvdmFfdG9fcGh5c19yZWFkLAo+PiArwqDCoMKgIC5yZWFkID0gYW1kZ3B1X2lv bWVtX3JlYWQsCj4+ICvCoMKgwqAgLndyaXRlID0gYW1kZ3B1X2lvbWVtX3dyaXRlLAo+PiDCoMKg wqDCoMKgIC5sbHNlZWsgPSBkZWZhdWx0X2xsc2Vlawo+PiDCoCB9Owo+PiDCoCBAQCAtMTk3Myw3 ICsyMDQxLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB7Cj4+IMKgICNpZmRlZiBDT05GSUdfRFJN X0FNREdQVV9HQVJUX0RFQlVHRlMKPj4gwqDCoMKgwqDCoCB7ICJhbWRncHVfZ3R0IiwgJmFtZGdw dV90dG1fZ3R0X2ZvcHMsIFRUTV9QTF9UVCB9LAo+PiDCoCAjZW5kaWYKPj4gLcKgwqDCoCB7ICJh bWRncHVfaW92YSIsICZhbWRncHVfdHRtX2lvdmFfZm9wcywgVFRNX1BMX1NZU1RFTSB9LAo+PiAr wqDCoMKgIHsgImFtZGdwdV9pb21lbSIsICZhbWRncHVfdHRtX2lvbWVtX2ZvcHMsIFRUTV9QTF9T WVNURU0gfSwKPj4gwqAgfTsKPj4gwqAgwqAgI2VuZGlmCj4+Cj4KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=